Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Fri, 8 Oct 2021 07:13:34 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Oleksandr Natalenko <oleksandr@natalenko.name>
Cc:     linux-kernel@vger.kernel.org,
        Eugene Shalygin <eugene.shalygin@gmail.com>,
        Denis Pauk <pauk.denis@gmail.com>,
        matt-testalltheway <sefoci9222@rerunway.com>,
        Kamil Dudka <kdudka@redhat.com>,
        Robert Swiecki <robert@swiecki.net>,
        Kamil Pietrzak <kpietrzak@disroot.org>, Igor <igor@svelig.com>,
        Tor Vic <torvic9@mailbox.org>, Poezevara <nephartyz@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@intel.com>,
        Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 1/3] hwmon: (nct6775) add Pro WS X570-ACE
Message-ID: <20211008141334.GA2079491@roeck-us.net>
References: <20211003133344.9036-1-oleksandr@natalenko.name>
 <20211003133344.9036-2-oleksandr@natalenko.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211003133344.9036-2-oleksandr@natalenko.name>
Precedence: bulk

On Sun, Oct 03, 2021 at 03:33:42PM +0200, Oleksandr Natalenko wrote:
> ASUS Pro WS X570-ACE board has got an nct6775 chip, but by default
> there's no use of it because of resource conflict:
> 
> ```
> ACPI Warning: SystemIO range 0x0000000000000295-0x0000000000000296 conflicts with OpRegion 0x0000000000000290-0x0000000000000299 (\AMW0.SHWM) (20210604/utaddress-204
> )
> ACPI: OSL: Resource conflict; ACPI support missing from driver?
> ACPI: OSL: Resource conflict: System may be unstable or behave erratically
> ```
> 
> A workaround is to use `acpi_enforce_resources=lax`, but a proper
> support needs to be added instead.
> 
> This commit adds Pro WS X570-ACE to the list of boards that can be monitored
> using ASUS WMI.
> 
> Tested by me on this hardware:
> 
> ```
> Base Board Information
>     Manufacturer: ASUSTeK COMPUTER INC.
>     Product Name: Pro WS X570-ACE
> 
> BIOS Information
>     Vendor: American Megatrends Inc.
>     Version: 3801
>     Release Date: 07/30/2021
> ```
> 
> Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/nct6775.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c
> index ba18c1cbf572..ff28ba70a8b3 100644
> --- a/drivers/hwmon/nct6775.c
> +++ b/drivers/hwmon/nct6775.c
> @@ -5000,6 +5000,7 @@ static int __init nct6775_find(int sioaddr, struct nct6775_sio_data *sio_data)
>  static struct platform_device *pdev[2];
>  
>  static const char * const asus_wmi_boards[] = {
> +	"Pro WS X570-ACE",
>  	"PRIME B360-PLUS",
>  	"PRIME B460-PLUS",
>  	"PRIME X570-PRO",