Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210915232722.10031-1-chunkuang.hu@kernel.org>
In-Reply-To: <20210915232722.10031-1-chunkuang.hu@kernel.org>
From:   Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date:   Fri, 8 Oct 2021 22:15:57 +0800
Message-ID: <CAAOTY_8BZ9BgWeQVsD_01ioP8H16c1_QUb_+yniU_4Wp91Nc7A@mail.gmail.com>
Subject: Re: [PATCH] soc: mediatek: cmdq: Use mailbox rx_callback instead of cmdq_task_cb
To:     Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>,
        Houlong Wei <houlong.wei@mediatek.com>,
        Bibby Hsieh <bibby.hsieh@mediatek.com>,
        Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Matthias:

Please ignore this patch because this patch depend on [1] which would
cause numerous warning message. So I would revert that patch in [2].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/comm=
it/drivers/gpu/drm/mediatek?h=3Dv5.15-rc4&id=3Dc1ec54b7b5af25c779192253f5a9=
f05e95cb43d7
[2] https://patchwork.kernel.org/project/linux-mediatek/patch/2021100723531=
0.14626-6-chunkuang.hu@kernel.org/

Regards,
Chun-Kuang.

Chun-Kuang Hu <chunkuang.hu@kernel.org> =E6=96=BC 2021=E5=B9=B49=E6=9C=8816=
=E6=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8A=E5=8D=887:27=E5=AF=AB=E9=81=93=EF=BC=
=9A
>
> rx_callback is a standard mailbox callback mechanism and could cover the
> function of proprietary cmdq_task_cb, so use the standard one instead of
> the proprietary one. Client has changed to use the standard callback
> machanism and sync dma buffer in client driver, so remove the proprietary
> callback in cmdq helper.
>
> Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> ---
>  drivers/soc/mediatek/mtk-cmdq-helper.c | 25 +------------------------
>  include/linux/soc/mediatek/mtk-cmdq.h  |  5 +----
>  2 files changed, 2 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediate=
k/mtk-cmdq-helper.c
> index 3c8e4212d941..c1837a468267 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -425,34 +425,11 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
>  }
>  EXPORT_SYMBOL(cmdq_pkt_finalize);
>
> -static void cmdq_pkt_flush_async_cb(struct cmdq_cb_data data)
> -{
> -       struct cmdq_pkt *pkt =3D (struct cmdq_pkt *)data.data;
> -       struct cmdq_task_cb *cb =3D &pkt->cb;
> -       struct cmdq_client *client =3D (struct cmdq_client *)pkt->cl;
> -
> -       dma_sync_single_for_cpu(client->chan->mbox->dev, pkt->pa_base,
> -                               pkt->cmd_buf_size, DMA_TO_DEVICE);
> -       if (cb->cb) {
> -               data.data =3D cb->data;
> -               cb->cb(data);
> -       }
> -}
> -
> -int cmdq_pkt_flush_async(struct cmdq_pkt *pkt, cmdq_async_flush_cb cb,
> -                        void *data)
> +int cmdq_pkt_flush_async(struct cmdq_pkt *pkt)
>  {
>         int err;
>         struct cmdq_client *client =3D (struct cmdq_client *)pkt->cl;
>
> -       pkt->cb.cb =3D cb;
> -       pkt->cb.data =3D data;
> -       pkt->async_cb.cb =3D cmdq_pkt_flush_async_cb;
> -       pkt->async_cb.data =3D pkt;
> -
> -       dma_sync_single_for_device(client->chan->mbox->dev, pkt->pa_base,
> -                                  pkt->cmd_buf_size, DMA_TO_DEVICE);
> -
>         err =3D mbox_send_message(client->chan, pkt);
>         if (err < 0)
>                 return err;
> diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/me=
diatek/mtk-cmdq.h
> index ac6b5f3cba95..2b498f4f3946 100644
> --- a/include/linux/soc/mediatek/mtk-cmdq.h
> +++ b/include/linux/soc/mediatek/mtk-cmdq.h
> @@ -268,8 +268,6 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt);
>   * cmdq_pkt_flush_async() - trigger CMDQ to asynchronously execute the C=
MDQ
>   *                          packet and call back at the end of done pack=
et
>   * @pkt:       the CMDQ packet
> - * @cb:                called at the end of done packet
> - * @data:      this data will pass back to cb
>   *
>   * Return: 0 for success; else the error code is returned
>   *
> @@ -277,7 +275,6 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt);
>   * at the end of done packet. Note that this is an ASYNC function. When =
the
>   * function returned, it may or may not be finished.
>   */
> -int cmdq_pkt_flush_async(struct cmdq_pkt *pkt, cmdq_async_flush_cb cb,
> -                        void *data);
> +int cmdq_pkt_flush_async(struct cmdq_pkt *pkt);
>
>  #endif /* __MTK_CMDQ_H__ */
> --
> 2.25.1
>