Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 8 Oct 2021 15:17:14 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Mel Gorman <mgorman@techsingularity.net>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, anthony.yznaga@oracle.com
Subject: Re: [PATCH v2] mm: Optimise put_pages_list()
Message-ID: <YWBS6iJr/4RJ+hNE@casper.infradead.org>
References: <20211007192138.561673-1-willy@infradead.org>
 <20211007123109.6a49c7c625e414acf7546c89@linux-foundation.org>
 <YV9eueky+lBfSWA3@casper.infradead.org>
 <20211007163554.d9088a65f0e293e2bd906a56@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211007163554.d9088a65f0e293e2bd906a56@linux-foundation.org>
Precedence: bulk

On Thu, Oct 07, 2021 at 04:35:54PM -0700, Andrew Morton wrote:
> On Thu, 7 Oct 2021 21:55:21 +0100 Matthew Wilcox <willy@infradead.org> wrote:
> > My first response is an appeal to authority -- release_pages() does
> > this same thing.  Only it takes an array, constructs a list and passes
> > that to put_unref_page_list().  So if that's slower (and lists _are_
> > slower than arrays), we should have a put_unref_page_array().
> 
> And put_unref_page_list() does two passes across the list!
> 
> <quietly sobs>
> 
> Here is my beautiful release_pages(), as disrtibuted in linux-2.5.33:

I think that looks much better!

> I guess the current version is some commentary on the aging process?

I blame the guy who sent cc59850ef940 to Linus back in 2011 ...

I think Anthony was going to look into this and perhaps revert us to
a pagevec_free() interface.