Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 8 Oct 2021 11:46:02 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Riccardo Mancini <rickyman7@gmail.com>
Cc:     Ian Rogers <irogers@google.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org
Subject: Re: [RFC PATCH v1 36/37] perf test/evlist-open-close: use inline
 func to convert timeval to usec
Message-ID: <YWBZqlg3hgsIWq+q@kernel.org>
References: <cover.1629490974.git.rickyman7@gmail.com>
 <b95035ec4a125355be8ea843f7275c4580da6398.1629490974.git.rickyman7@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b95035ec4a125355be8ea843f7275c4580da6398.1629490974.git.rickyman7@gmail.com>
Precedence: bulk

Em Sat, Aug 21, 2021 at 11:19:42AM +0200, Riccardo Mancini escreveu:
> This patch introduces a new inline function to convert a timeval to
> usec.
> This function will be used also in the next patch.

Thanks, applied.

- Arnaldo

 
> Signed-off-by: Riccardo Mancini <rickyman7@gmail.com>
> ---
>  tools/perf/bench/evlist-open-close.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/bench/evlist-open-close.c b/tools/perf/bench/evlist-open-close.c
> index c18aa85725281795..00d0aef564f80d44 100644
> --- a/tools/perf/bench/evlist-open-close.c
> +++ b/tools/perf/bench/evlist-open-close.c
> @@ -26,6 +26,11 @@ static int iterations = 100;
>  static int nr_events = 1;
>  static const char *event_string = "dummy";
>  
> +static inline u64 timeval2usec(struct timeval *tv)
> +{
> +	return tv->tv_sec * USEC_PER_SEC + tv->tv_usec;
> +}
> +
>  static struct record_opts opts = {
>  	.sample_time	     = true,
>  	.mmap_pages	     = UINT_MAX,
> @@ -197,7 +202,7 @@ static int bench_evlist_open_close__run(char *evstr)
>  
>  		gettimeofday(&end, NULL);
>  		timersub(&end, &start, &diff);
> -		runtime_us = diff.tv_sec * USEC_PER_SEC + diff.tv_usec;
> +		runtime_us = timeval2usec(&diff);
>  		update_stats(&time_stats, runtime_us);
>  
>  		evlist__delete(evlist);
> -- 
> 2.31.1

-- 

- Arnaldo