Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <81b122b0-8679-f6be-d193-537e95670cd0@opensynergy.com>
Date:   Fri, 8 Oct 2021 18:01:37 +0300
Subject: Re: [PATCH v4 0/1] iio/scmi: Add reading "raw" attribute.
Content-Language: en-US
To:     jbhayana@google.com, jic23@kernel.org
Cc:     lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, Vasyl.Vavrychuk@opensynergy.com
References: <20211008135842.21896-1-andriy.tryshnivskyy@opensynergy.com>
From:   Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com>
In-Reply-To: <20211008135842.21896-1-andriy.tryshnivskyy@opensynergy.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEIrQ2k0OFZrMGVFbDRDUHlzYTdvcFA3TTJqMDVSMkpTeWUvS3pkM05vUGRj?=
 =?utf-8?B?alR1QXdaZTJPZUlPTnFNNlQ5ekdHdlA5YXpDVzJuSCtLaEZVNStUdStuRVlm?=
 =?utf-8?B?S1NMc0hTWlR3aFpOdlludjFGQ0x5TlVPRUJJUFBQa2lrRUsyWHJxMXJTN3V0?=
 =?utf-8?B?R3VKOHBDZlN2UzhZaVMzVVBVRGhaWXpTN1h1THl2QVdiOG9hS1UzVjA1SUxL?=
 =?utf-8?B?WjFGM1Bic0c2ZCtrcFh1OUtDYlFRRDluNGxEc0RjSmFSNzFtTkVWc1I4eEdQ?=
 =?utf-8?B?dlZNcU1ONlVUTVdWZjcya3Q0RUpDSmMvelBZZ1k0aXlCUEZsdFRqc1IwZHR5?=
 =?utf-8?B?N2RsaGpsajc5UnlVQWptU2wvdWpXS3dJZDNqUUxCOVJNbjVyd1lwaEVJZ0lh?=
 =?utf-8?B?STFYT0hEeDk2WmVteEY0VEZGNXJya1YrNFMyMnA5TVRtMmdMOWkrV1NEdlp0?=
 =?utf-8?B?SWFPL255UzJyQjZta2t2a0hsbnFrT3NLVXBKaWNQM3h1TW9qOVA4ZVN6eVRB?=
 =?utf-8?B?b3dLOHNLNzhaNlZHT2drUkhXdUpWdjF3R3pJVU5qK0VXVHpXN1NOTWtXS2Zi?=
 =?utf-8?B?Mnk1VFcwSENndlpMVTJ2UGdKdXhxY2wxUkh0VTlKTVd5VjExbERvMHNsRTha?=
 =?utf-8?B?cXNUNFl3emxYL2UrMCtwQ05La0sxaTJ0WmFBUnVCNTV5ZDZUbGc2RWk4TkxY?=
 =?utf-8?B?Q01IQityYXFZNzJYM1B1NE5IbE54N0JreUtlMUxPOEZGSWZBMWdtK2JmbndB?=
 =?utf-8?B?d3RyZ2VNSUFTQ0orSFZwRC84dUpINnN3VDc1V2ttSytPRzRybHpDdjVUbmVR?=
 =?utf-8?B?T0d6TTNHT2ZUSWNSYjhLMXhVQXBacW9iQmplNG11cUpIaTBoa1MzNndDcmE3?=
 =?utf-8?B?YmpuNnFpanV3dXk2Z1BoTHlQbzhXYlYvWWN4K1I1WnFvOTNEemNFbXdOR3dD?=
 =?utf-8?B?bzRYREQveDdyUFhqRzM0cG8wOFBzV21Bb0VLczdranMxSERZeTYyWWRNRS9D?=
 =?utf-8?B?cTBUZzJPeExXb2t4dzZSMnhubVg1dEQzcWh0OGFDTjNKSzBsNlNGUGd0NFBa?=
 =?utf-8?B?aWFjYkw2blEzbisvSVN1bkRvOGlGMm1yR1pzMU12Y2NFT01ZcUU2SFZFSlJk?=
 =?utf-8?B?U0N5aWt2bE4xeUlnbkVFdUo5UzcyL1FkRE5GeGtDcnRPN3p5NmwrVTM1eUV5?=
 =?utf-8?B?Y05xS2wzNXQyaU9ZbWVyOFdXWURBR3k5OTRnVUdJcjRaTFJuN2FJMGk4UWMx?=
 =?utf-8?B?eXpMU0EzcTZOeFoyUE9nZlRHNFpqb0lsSXlqMUVSaUVBNVI5OHVQNGU4b1Jt?=
 =?utf-8?B?ZFViVFZMMkllc0Q1SWtlTHlDTnR2TmZHV3dRWW9wNTdHdHlpdklYNlA0MVRs?=
 =?utf-8?B?a013RFYxS0ozV2pKdU9rZ1RTdGxueUJhZzNJY2F4Y1o4UkpWSUJsaUFhL0Nr?=
 =?utf-8?B?QjVDeFBDdmh3L0dWYmt4V1kwRXVyZ0hEUmlaUTdOd2xySktKVVMyQVdLUEZj?=
 =?utf-8?B?U3ZwMldBcXRqUkZKYWVWaEVUWFNtVWZDVTFRdVZRbUp5d0FLdE5PaWczMW1I?=
 =?utf-8?B?RlJ3LzZ4RkNLcFRKcWl4Y05MS1ZBcitscVZ1alRyR2lHWkRUUVRYUDh5ZWNN?=
 =?utf-8?B?b2tFQkdobWs1QVY3MlAxVXMyMnZ6UUg3RTA2TXhKVzZxY0pjL0tIZndrR0M4?=
 =?utf-8?B?VHl1b0RHY0NJMHEvaUcrNVEySUNwcC85bFR6QU5kcVhieVIrbkRVTERZV09Z?=
 =?utf-8?Q?okvaN8wCjrWq4QKm/Z/1kMBskOI3oxMtN1R6Y+t?=
X-OriginatorOrg: opensynergy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dd195536-9f67-4919-5b80-08d98a6c87f1
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6359.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 15:01:39.2817
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 800fae25-9b1b-4edc-993d-c939c4e84a64
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v3pj1o4X+winZYwuDneMJhHuGJm6ckw+0q7mORl2BCq+4R05okW6thDJLnrtaB3lUkGfBkcBxb2ATBneDyfSmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3846
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi All,

Please do not review this patch version, since iio_device_release_direct_mode is missing in error path.

Thanks,
Andriy.

On 08.10.21 16:58, Andriy Tryshnivskyy wrote:

> This patch implements reading "raw" attribute.
>
> The patch is based on v5.14.
>
> Comparing to the previous version it has:
> * do not use scmi_iio_get_raw() for reading raw attribute due to 32bit
>    return value limitation (actually I reverted the previous v3)
> * introduce scmi_iio_read_raw to scmi_iio_ext_info[] which can return 64 bit
>    value
> * enabling/disabling and reading raw attribute is done in direct mode
>
> Any comments are very welcome.
>
> Thanks,
> Andriy.
>
> Andriy Tryshnivskyy (1):
>    iio/scmi: Add reading "raw" attribute.
>
>   drivers/iio/common/scmi_sensors/scmi_iio.c | 66 ++++++++++++++++++++++
>   1 file changed, 66 insertions(+)
>
>
> base-commit: 7d2a07b769330c34b4deabeed939325c77a7ec2f