Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <d794e44d-e67a-e51e-93b0-9b23edba2e21@axentia.se>
Date:   Fri, 8 Oct 2021 17:27:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.2
Subject: Re: [PATCH v2 2/3] dt-bindings: iio: io-channel-mux: Add property for
 settle time
Content-Language: en-US
To:     Vincent Whitchurch <vincent.whitchurch@axis.com>,
        Rob Herring <robh@kernel.org>
Cc:     kernel <kernel@axis.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "lars@metafoo.de" <lars@metafoo.de>,
        "jic23@kernel.org" <jic23@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
References: <20211007134641.13417-1-vincent.whitchurch@axis.com>
 <20211007134641.13417-3-vincent.whitchurch@axis.com>
 <1633661172.633248.1409599.nullmailer@robh.at.kernel.org>
 <20211008135610.GA16402@axis.com>
From:   Peter Rosin <peda@axentia.se>
Organization: Axentia Technologies AB
In-Reply-To: <20211008135610.GA16402@axis.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2V2a3IzUVdOVkRlK0FtRFd6OGg0VW5HTGpDR0NhenA4SHdiNHJuZkw3S2RZ?=
 =?utf-8?B?NFk4elFNb3pJYVhYR2c3eThxVmhON2xlUWR2TEMyR0dOZlk2R1M5NXBWWGox?=
 =?utf-8?B?c3h2ZkFiZTM4OXQwa2Z0U0s3dmVvd1Q5REhLWUZBMjVQT0ZGYUxPdHhpaWZu?=
 =?utf-8?B?TnhqNEZOZ0dQQk1JUzE0TWlLL3JoUWpPS25XcWR0N3JXV2orUEhnQnRIZ2ly?=
 =?utf-8?B?allHbmFobWZ0b0FDZHpOcTVGWitYSmdTZHFsbytLM3dCRUZndjNmdUFuTDNG?=
 =?utf-8?B?SExzeHhhcUFObjBxRTlaMHJTT1gvK0pJcENrREJ5aU8wbGR2SGFwQzErTS9O?=
 =?utf-8?B?S3FYZ28vd3hNN1BnRGthajJnSWd4Mk1OaXR2ODhSNUU3Qnd4UXBpTENQVm5u?=
 =?utf-8?B?eHVRWDN1bU5MTjBTWVJkZ2hiejBZck5na2JXWGQ2NUdnYmQ0dndTNVljUzE1?=
 =?utf-8?B?ZzdmK0VhRHczamRWL2xpYWhNbkZ4Zzk3WTY5V21nTE92WEx4aEZwdm4ySmVD?=
 =?utf-8?B?ODlrZjNwSHRUQ2tsZ0QybW1ld283Rjh1aGRCY1VoUUtaRVZkRmxwSGRoMWc4?=
 =?utf-8?B?TzBQZnlCMmxFL0lXQzFSYUlEVHJUZ1kvcGFhczZOM1dQb2Q3Lzg1T2tkNk1r?=
 =?utf-8?B?Q0gyRnl4dm95bnpTaElEL3ErNkNlbVdKNnAyWmdrbEdLTDVWY3cyRG9tSkwz?=
 =?utf-8?B?ZVpqYWFLdmR1aVZDVXdRblcwTUhISnEyQ3NjSFoyaktZRi9XeEZDQ1hUUjVN?=
 =?utf-8?B?ejJSOGZMOVRjb3ZDcm5DR0hMSncrY3BYVGpSM3dPVVp4NjluWHFZRWtPWVEx?=
 =?utf-8?B?TklCeWxTaDFNNHdCcmZSZzZIYXZyNHdueUJiTXZpTm9pSFNQZmF4Q3dJZ0Mx?=
 =?utf-8?B?MkVpQmR5NGkzMnB3c3M1Y0I1N3kyZjVpYnYyVjRibTloTStPbk01VVdONFlH?=
 =?utf-8?B?bE4xN2pWT0RxMkRhNUZpclEvN2hId2ZaUEh3NlJBZlpyUkdTWVVRQ2sveXUr?=
 =?utf-8?B?aUNyN0YzanMrOWVlRGJCVGM4MmZ2dmhjeFFoZUtmOHNQQVlGWU1ULzArOWZL?=
 =?utf-8?B?bkVHaUJ0L0dVeWhHcVJscjUyK3B3OUlLbzJzY1kyYmo1L2t5dmpZbTdwVmdQ?=
 =?utf-8?B?NXVRYjNuaS80dzlTYmU5R2V0TlA3TmxSb3FXOUZRU3BMK0ZIcnZjZ2JhVGU1?=
 =?utf-8?B?T1UxalhiVnh3WHdYVVdvaUVyRUk5WTVRcUlDdG5SNkpERzhOUDZuWVE0cWdu?=
 =?utf-8?B?eWYvSndnRmtvVnJmLzFPVFhRWUVITUJDQjJiQ1NuM1lvTWpPZGFhaFN0Umhu?=
 =?utf-8?B?MXNFd052aWxRc1h4MlN1eW8yU3lUaVRYZUc1S05ZbE5EUlhybXE2VGNCWlFT?=
 =?utf-8?B?b25XLzZ4cjRSUGM5UVhScGdnY1Z2VVZXYzFnZjhqbnhBTXczVkVhalRHMjNZ?=
 =?utf-8?B?RlBiNGdkVUlUTWo1dkJKZldpYU9ZUTRMZFhUNW9ndFYzOTVybGg3ZkM0NWtE?=
 =?utf-8?B?MUdYTjJMTGpBd1kwbUQ1WDlBTG9sRUVWUzBGNlkwZU9mZVZMaVc5OXl0TUdM?=
 =?utf-8?B?aW1FS0Irb2VCSUdENkdsRWtiem1BVmd4OXI3TTd4MG12UXVPRXJDV0NSQk5I?=
 =?utf-8?B?eFNHcUpSNDdJcGR0blpJa2QwcForQmhsUUduRXpiRlFJQURZekxyeklsVkw5?=
 =?utf-8?B?YWZvVHMxRlZYK0xWc095akFBeEEwM2VndXJUOGdPMmpxTXJBWG9HZjVkZGJr?=
 =?utf-8?Q?bl5YNmZqlTEDageifK5vpJ5wqC+bw8IPe+8uzYy?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: ea69a555-2635-420e-b797-08d98a7028c9
X-MS-Exchange-CrossTenant-AuthSource: DB8PR02MB5482.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 15:27:37.6293
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NsmsgYVyBv6MHAJGaD8G3PyFXBJl15+UGxNd50eitscU70ZUiZhAEr68GiuMg56d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR02MB3064
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021-10-08 15:56, Vincent Whitchurch wrote:
> On Fri, Oct 08, 2021 at 04:46:12AM +0200, Rob Herring wrote:
>> On Thu, 07 Oct 2021 15:46:40 +0200, Vincent Whitchurch wrote:
>>> Hardware may require some time for the muxed analog signals to settle
>>> after the muxing is changed.  Allow this time to be specified in the
>>> devicetree.
>>>
>>> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
>>> ---
>>>  .../devicetree/bindings/iio/multiplexer/io-channel-mux.yaml  | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>
>> Running 'make dtbs_check' with the schema in this patch gives the
>> following warnings. Consider if they are expected or the schema is
>> incorrect. These may not be new warnings.
> 
> Yes, these are not new warnings.
> 
>> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
>> This will change in the future.
>>
>> Full log is available here: https://patchwork.ozlabs.org/patch/1537724
>>
>>
>> adc0mux: '#io-channel-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
>> 	arch/arm/boot/dts/aspeed-bmc-ampere-mtjade.dt.yaml
>>
>> adc10mux: '#io-channel-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
>> 	arch/arm/boot/dts/aspeed-bmc-ampere-mtjade.dt.yaml
> [...]
> 
> I think the fix for these is to add a "#io-channel-cells": const 1 to
> the schema.

Agreed.

>> envelope-detector-mux: channels: ['', '', 'sync-1', 'in', 'out', 'sync-2', 'sys-reg', 'ana-reg'] has non-unique elements
>> 	arch/arm/boot/dts/at91-tse850-3.dt.yaml
> 
> This one looks like an error in that particular devicetree.
> 
The double '' is intentional; this mux is 8-way but only 6 legs are
connected, with the first two unused. I don't know how or where to make
changes to dodge the warning. I don't want to put names on things that
do not exist, and the iio-mux driver is using empty names as a hint to
not configure any child channel for those indices that have empty names.
If e.g. channels 0-5 are in use, then this is not a problem since you
can just end early with 6 names instead of 8, but alas, channels 2-7
was what the hw-crowd fancied in this case.

Cheers,
Peter