Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Cc:     brijesh.singh@amd.com, Marc Orr <marcorr@google.com>,
        Joerg Roedel <jroedel@suse.de>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        David Rientjes <rientjes@google.com>,
        John Allen <john.allen@amd.com>,
        "David S. Miller" <davem@davemloft.net>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: ccp - Consolidate sev INIT logic
To:     Peter Gonda <pgonda@google.com>, thomas.lendacky@amd.com
References: <20211005195213.2905030-1-pgonda@google.com>
From:   Brijesh Singh <brijesh.singh@amd.com>
Message-ID: <fdf0c263-38e9-7780-d0ac-943b6d2dd3a3@amd.com>
Date:   Fri, 8 Oct 2021 10:52:05 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <20211005195213.2905030-1-pgonda@google.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzBQQnFtYW16cmJMVkFuZE9JRjRNM1doOXVndGQ2azlicXpGQ2VWdEE5Uks5?=
 =?utf-8?B?UFRGaitvV1h5Mm9JbU01VzRCQUxSWldTUU1DL1l5SkpZK0sxaEsyLzhnMzJK?=
 =?utf-8?B?M3RJSjMvVy8wVk1XeEsvMkFmQi94aC9xTkVNOFF4ODVhY2NlMzNsaWI3ZGlS?=
 =?utf-8?B?aTM4UXJkQStSRk0vNUJwYlBFK0NDWXJFY1hHbVhIcTM1NUFDQXp1TlNKMmRS?=
 =?utf-8?B?czU0ZHFTWFBUWnNyQjgxYWhPdkFIemtWRmhyNy9FUkYzWmljRGlpMTRCMVlQ?=
 =?utf-8?B?QlpIWCtjTDBXK2UrV01xcXhsREE4SFdhMVA2N2hOY0lUbXVHRFpYa2ZnU0s3?=
 =?utf-8?B?aUJXRmpQcVVkY1IrZXkvcVV5eDBMUExwNFF1U1VGSG5yNnRxUlN5NWVqMSt1?=
 =?utf-8?B?TjVKdXFjTHlzRWNXUHJ4dWtMU1Y3SklxZFJBTjlyUGVwMHNxK3ZZZzFhazgr?=
 =?utf-8?B?WExRMSs1c0U4TEFSNWY1YlFQNHJLTFB6S1hlU0xIeC9yM1BOcjYvYmdMNDZU?=
 =?utf-8?B?dHNzV09WUFdzcW95bWhDZ2RtVDJkSjZKTURwYmI4SytUVFFTTHdCSUdVWVRx?=
 =?utf-8?B?MjN5K0QrdEpyODZiV29vNGFRTEwrd09hMWtjWDZwWWFOWFpRUTFGNDBkMlhh?=
 =?utf-8?B?cmNyMDJ5SUh6Rmpxemx6dytxbzdRTVcwMnZIV3JETzNvM2V5V2NCb3FzZ1R5?=
 =?utf-8?B?bjVLbFFjaWxZN0RXRWJLd2VEZE5IWktBNkZFUjRRc1ppdms2MVlHOTFJckln?=
 =?utf-8?B?UG5ySTYzcHBJUEdseDhJRVdrY3kxQ2dUQzl6NnF3SkM5OWpDNk1jQnY5R3FG?=
 =?utf-8?B?b3BpdnVHTWNFUTJXZDQzeGlwWFJKakpoclhyNzB3c0tUNFBHckdUbEpYaW5B?=
 =?utf-8?B?bEdKS0tvUGlzL0gwTHQ1bkpBTU9qT1JmdW54Si9MZ0NsODRnWkRpNFJiMzlw?=
 =?utf-8?B?Vkh6YnFCM2hzNGl1WXdFMWVkazFrN2k1WFMyQUQ5WHFBdGpCRnA1Nm9ZUkZJ?=
 =?utf-8?B?cmJQRGFIOE1BY3k5YmRWVnRBdk9zc2EyR3ZVbFBsaWhLRkphdmVhTTFDL3Ar?=
 =?utf-8?B?Sng4L3ZLekROaFhHaGxuTWxxS1VOWXlabFEyQk9KL3NqNyt2My81NVBKRS9N?=
 =?utf-8?B?aExjWGtXcUt3V2pHQU9jSGRVZ0tnRW1TSU51MTU0MXlGNEN4R01pZm9TQXI5?=
 =?utf-8?B?clpSZklnaFh2ZmsyMVA1MHJTdGJFeUF3T1RhZk5vTm16ZStubDYrSVdydFR5?=
 =?utf-8?B?VUJnZmhicTlyOWNaT2VqdndCNFRMM0FKR0UwWUhmWmNuYnN0emJ6TktGNmZu?=
 =?utf-8?B?Tml3UFFJclJaejRTNThrSFA1VGtCNmtaQlE3RWpxWUY3YzM3VDlRMXdrdUZz?=
 =?utf-8?B?SnVpaGZuN1g0KzdIQTBESGxWNWcwZDhnR1QzMmRkNEdLb1dFK2VWbGV4UkVN?=
 =?utf-8?B?MlQ3dmtaQ2drc1BqcHJ0THh3YnVxWFVZam5BZmU3UG5lTE82d2ZGNlB6WFFF?=
 =?utf-8?B?K2poejk4YjlwQ25kaXgxTHhrQVo4U1dGbEtIN0UzQmRndVpvZUFRRTArRTNS?=
 =?utf-8?B?MkFQMktlanZ1UzdQVVh0VktaVHlmRlphMjFWSVFNclo4YkFLVFptWWx2cHJT?=
 =?utf-8?B?c3RqRCtOVjNyWmtrZWZERHQwdE00ekw4SWxQVEtsNTNOaFo1MDBHM2E3UEFo?=
 =?utf-8?B?NEtSTGtTblNMTCtDb0c2c3V4VHI0TDdoZFZicW1GT0R0cXhTVEU4eTN4Ni84?=
 =?utf-8?Q?J+9gbYAc1jrYCa6l+ExIx14oa0EveU6TlWEhqMx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e9590b0-59bb-4259-fe4b-08d98a73958b
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 15:52:08.6126
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4VK/2KY5wtgqxxz5slpVVNOIaHRMa2cCmDA9NR9SCyO7iXhxLxC4YbBacy6Mxwd6udRzRc9W0Jfa8C0oEFfEWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2688
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/5/21 12:52 PM, Peter Gonda wrote:
>  
> +static int sev_init_if_required(int cmd_id, bool writable,
> +				struct sev_issue_cmd *argp)
> +{
> +	struct sev_device *sev = psp_master->sev_data;
> +
> +	lockdep_assert_held(&sev_cmd_mutex);
> +
> +	if (!writable)
> +		return -EPERM;
> +
> +	if (cmd_id == SEV_FACTORY_RESET || cmd_id == SEV_PLATFORM_STATUS ||
> +	    cmd_id == SEV_GET_ID || cmd_id == SEV_GET_ID2)
> +		return 0;
> +
> +	if (sev->state == SEV_STATE_UNINIT)
> +		return __sev_platform_init_locked(&argp->error);
> +
> +	return 0;
> +}
> +
>  static long sev_ioctl(struct file *file, unsigned int ioctl, unsigned long arg)
>  {
>  	void __user *argp = (void __user *)arg;
> @@ -840,8 +825,11 @@ static long sev_ioctl(struct file *file, unsigned int ioctl, unsigned long arg)
>  
>  	mutex_lock(&sev_cmd_mutex);
>  
> -	switch (input.cmd) {
> +	ret = sev_init_if_required(input.cmd, writable, &input);
> +	if (ret)
> +		goto copy_out;

We need to call this function only for the SEV commands (i.e input.cmd
>=0 && input.cmd <= SEV_GET_ID2). Otherwise a invalid command may
trigger SEV_INIT. e.g below sequence:

1) SEV_FACTORY_RESET   // this will transition the fw to UNINIT state.

2) <INVALID_CMD_ID>   // since fw was in uninit this invalid command
will initialize the fw and then later switch will fail.

thanks