Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 8 Oct 2021 08:49:49 -0700
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Valentin Schneider <valentin.schneider@arm.com>
Cc:     Frederic Weisbecker <frederic@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Uladzislau Rezki <urezki@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Boqun Feng <boqun.feng@gmail.com>,
        Neeraj Upadhyay <neeraju@codeaurora.org>,
        Josh Triplett <josh@joshtriplett.org>,
        Joel Fernandes <joel@joelfernandes.org>, rcu@vger.kernel.org
Subject: Re: [PATCH 00/11] rcu: Make rcu_core() safe in PREEMPT_RT with NOCB
 + a few other fixes
Message-ID: <20211008154949.GQ880162@paulmck-ThinkPad-P17-Gen-1>
Reply-To: paulmck@kernel.org
References: <20210929221012.228270-1-frederic@kernel.org>
 <87fstkmybc.mognet@arm.com>
 <87ee8vlill.mognet@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87ee8vlill.mognet@arm.com>
Precedence: bulk

On Fri, Oct 08, 2021 at 03:03:02PM +0100, Valentin Schneider wrote:
> On 01/10/21 18:47, Valentin Schneider wrote:
> > On 30/09/21 00:10, Frederic Weisbecker wrote:
> >> PREEMPT_RT has made rcu_core() preemptible, making it unsafe against
> >> concurrent NOCB (de-)offloading.
> >>
> >> Thomas suggested to drop the local_lock() based solution and simply
> >> check the offloaded state while context looks safe but that's not
> >> enough. Here is a bit of rework.
> >>
> >> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> >>       rcu/rt
> >>
> >> HEAD: aac1c58961446c731f2e989bd822ca1fd2659bad
> >>
> >> Thanks,
> >>       Frederic
> >
> > FWIW I've had RCU torture with NOCB toggling running for half a day on my
> > Arm Juno and nothing to report. I still need to rebase this on an -rt tree
> > and give it a spin with CONFIG_PREEMPT_RT.
> 
> Rebased on top of v5.15-rc4-rt7-rebase with Thomas' patch reverted and ran
> the same thing under CONFIG_PREEMPT_RT, nothing seems to catch on fire, so:
> 
> Tested-by: Valentin Schneider <valentin.schneider@arm.com>

Thank you!!!

							Thanx, Paul