Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211007094723.202330-1-allen.chen@ite.com.tw>
In-Reply-To: <20211007094723.202330-1-allen.chen@ite.com.tw>
From:   Robert Foss <robert.foss@linaro.org>
Date:   Fri, 8 Oct 2021 18:00:50 +0200
Message-ID: <CAG3jFyu-nG8jttSfkZ-ZZAg7W9SRFFDWsA9=g7Z1JbNhxBLuyw@mail.gmail.com>
Subject: Re: [PATCH v9] drm/bridge: add it6505 driver
To:     allen <allen.chen@ite.com.tw>
Cc:     Kenneth Hung <Kenneth.Hung@ite.com.tw>,
        Jau-Chih Tseng <Jau-Chih.Tseng@ite.com.tw>,
        Hermes Wu <Hermes.Wu@ite.com.tw>,
        Hsin-Yi Wang <hsinyi@google.com>,
        Hsin-yi Wang <hsinyi@chromium.org>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hey Allen,

I was running the pre-merge checks, and hit some build issues. This
was built against todays drm-misc-next branch, which I would like you
to rebase your patch against.

drivers/gpu/drm/bridge/ite-it6505.c: In function =E2=80=98it6505_bridge_ato=
mic_enable=E2=80=99:
drivers/gpu/drm/bridge/ite-it6505.c:2919:15: error: implicit
declaration of function =E2=80=98drm_bridge_new_crtc_state=E2=80=99; did yo=
u mean
=E2=80=98drm_atomic_get_new_crtc_state=E2=80=99?
[-Werror=3Dimplicit-function-declaration]
 2919 |  crtc_state =3D drm_bridge_new_crtc_state(bridge, old_state);
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~
      |               drm_atomic_get_new_crtc_state
drivers/gpu/drm/bridge/ite-it6505.c:2919:13: warning: assignment to
=E2=80=98const struct drm_crtc_state *=E2=80=99 from =E2=80=98int=E2=80=99 =
makes pointer from integer
without a cast [-Wint-conversion]
 2919 |  crtc_state =3D drm_bridge_new_crtc_state(bridge, old_state);
      |             ^