Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp2561457pxb; Fri, 8 Oct 2021 10:12:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwA1ZfHs5EfbZI+EZs9x2Ukz3B6Y00nrvGKrb1Bik1dT0FfLwi6JyiyBEZDMxjPM0tEdUrM X-Received: by 2002:a05:6402:4409:: with SMTP id y9mr5883998eda.184.1633713127002; Fri, 08 Oct 2021 10:12:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633713126; cv=none; d=google.com; s=arc-20160816; b=wbnr8rKfw0x5QGHOfc7qEd6rP5jtYV9FIwrWMy5eZ5ntb3IYxridUiSg+fqpAbKdzT XLeUypxJqVbj3xzwfiBj+p+GPUyXinFVNnqgjJIX/7oeCXd8XDn/sjmL7nktS51KoSAB NvQ1wzom/sC3F6R7JUR2TAfD4to2u1K1Kj7VWSAIsaCvE0w9kK5aCXRIkK04IlHwi0IX vhTj6XpZpi7Nu9bhe2ottVPIN1Kfi025/nNdkyFFSJ1qKLH/38FD680aA2VFKcPvdQ+J MbqP27R5RzQA3iSKIxOBDC/NYbEvtCz0h+QBQVQjlXWgHic6IALH4ipRDqyI3UzZECC9 R8ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=YADg2bJ6URqNQ6akWofk5URBWNU7r80NIt+/8xbfWZQ=; b=eb/p6ewMUv/P7qp+ygRxDVDC2p+8WGytXtWhuhzy1lnJ+khMGYc8MnbzKQEQMJ+DpY dPDfk/611CCNfH2n/Oe2dDOicKpkqkODzhT6xlajU4h69pvMVdDIRz5RDsZhM4k4keaG XorAg96V80jjwvmBcXX410Tyhbvq92t6xq7nU1kKQBH2iX3DtmoOUM4ozYy75M5dwj8x Rmxo+NJmpGO0WWFuQon1YMn9TtzXgWRCr5e3/llvnB6SCysn2+tlwt9PO14U1+1YkMdz zFTVx6c+v2YXVpGy9wdHCZfvxJssSNTMyuFyXEMDVvqwDrhDRXhYFVWFl4MvrgYpfAaY lejg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XYMfQwSv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j2si4186258edp.491.2021.10.08.10.11.42; Fri, 08 Oct 2021 10:12:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XYMfQwSv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231261AbhJHRHs (ORCPT + 99 others); Fri, 8 Oct 2021 13:07:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:55456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231217AbhJHRHr (ORCPT ); Fri, 8 Oct 2021 13:07:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AFB4A60F92; Fri, 8 Oct 2021 17:05:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633712752; bh=7kTIwLlgRp0iDs1cBmHL2s0Lz6D5wpQ13P8G7hwfwHU=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=XYMfQwSv0q8lwftf+OFgxpV89YKNDcdVihFUHcLKr30vJcCseb6MRhMXweW40Q50n c+Vsrf5ReO4V5uEF6HEL9FcVNT/3+Px07w2bZVa97XCw+NDf4BTgGOVWJ6sToLSkbJ CxBmA29RdR2uCFybTxpT+cm671Gaq7v7FFNTlmGTNsbnDTAE/fMNwc7BEVbhhTBlvY eAtjkv4VgIDTRJ+2d+WOb1tTZvRUTJeO740yI67blEqD7rvoYCdhOgxaBK1T8r/Gdm 9LOaCvLdoZs7/E2kyyd03QJLwYQp8UKSj9hj5JR7+/+nYTYH98OsZONNlwBFMh3NfK 2cO6QkOTebBeA== Date: Fri, 8 Oct 2021 12:05:50 -0500 From: Bjorn Helgaas To: kelvin.cao@microchip.com Cc: kurt.schwemmer@microsemi.com, logang@deltatee.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kelvincao@outlook.com Subject: Re: [PATCH 0/5] Switchtec Fixes and Improvements Message-ID: <20211008170550.GA1352932@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210924110842.6323-1-kelvin.cao@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 24, 2021 at 11:08:37AM +0000, kelvin.cao@microchip.com wrote: > From: Kelvin Cao > > Hi, > > Please find a bunch of patches for the switchtec driver collected over the > last few months. Question: Is there a reason this driver should be in drivers/pci/? It doesn't use any internal PCI core interfaces, e.g., it doesn't include drivers/pci/pci.h, and AFAICT it's really just a driver for a PCI device that happens to be a switch. I don't really *care* that it's in drivers/pci; I rely on Kurt and Logan to review changes. The only problem it presents for me is that I have to write merge commit logs for the changes. You'd think that would be trivial, but since I don't know much about the driver, it does end up being work for me. Bjorn