Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp2649398pxb; Fri, 8 Oct 2021 12:03:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyk1qsHQYrpA17ewrlkmGephOsVBVW6AnH678xMPoyWJPOHdziNi5Bt33Uuf5GEblNI++Fe X-Received: by 2002:a50:d4cd:: with SMTP id e13mr16916538edj.29.1633719780947; Fri, 08 Oct 2021 12:03:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633719780; cv=none; d=google.com; s=arc-20160816; b=DbTCQQvQheVFOoqurpI/lqfwXQxh9VGgj7Uq/wnVuDPSRgyNNdI9Le+IYPJoRj8rMt 93z8JIwtOSPdjFj9rK4YARDHVbqnGej6PIegFjYhgFSHAFtieVuZK6CB6SRRfFzEgwXO dCuNJ+qVwoHyPaTG7KK98X80W7Pn0bSZq1/gvcpS5CVai6hi1XRWGLtXuQGkrwJFcaKJ +3hH/JBRecqgMHcdbYJUd8SnkBG9TqNlL3K0snKUsrbS8sdeB6zCx7u59dW61Aqa2rIk mnKAOMNDBwAxzUFcgE6rsfjdB5nsj7f3BZ57YFXuVguQvSFNiEpVwDaBPxXuzovsb4Ye VYrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=n3vYnjG8u3vTkoNpWinsMsFEpE/inATha2M58OKPYGM=; b=KzCyGB671oL4xHVYihELLvWsQVjofauxrvljf8dwjjX71XGVkNjG/3Wl5jpszXArdF U6B5RO/CCAu7WkKw4lkvpfRZXTtfSm5ok1v1Xrav1ARjdBJzv+pVyvhXRBKgWVrCeFka QSjF6sKGMJbzrrfYpIbWlT4zzT2Xdeo20A+qmArl5HF0nsJNzzXzWVNWaBPvoNeJiQrL tKzZk1fZzpdSbHSKO4hliK6iW4V7QKmJCga4ndYpR34r3D/FTQWFrMW8lF5Wdhne+b+S 3Ci4QoLtjMI0hD79+mjDQQnYv8XKZ/2Lf+XjT5n8LmPnzCgrVnavipavRfberLzTP9DH gNWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BPbxW1Z+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n2si206961edi.381.2021.10.08.12.02.36; Fri, 08 Oct 2021 12:03:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BPbxW1Z+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231725AbhJHTCa (ORCPT + 99 others); Fri, 8 Oct 2021 15:02:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:45872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231312AbhJHTC2 (ORCPT ); Fri, 8 Oct 2021 15:02:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6BB5360FE8; Fri, 8 Oct 2021 19:00:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633719632; bh=X2+TA7D/QVQQ3sstjV8Bo85mIJKFkSjBOXOLiXSWzZE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BPbxW1Z+XZF5OG7GpRFqxh4JOAvuLoGL/hnbOpxZdQOkl5mHTKG6Ap5Zy3vrL9v3y GbkoH52HrxXMi4XirU2usdotE4A659Xleq/rbGzXDjSzsg4sLdAoijy3KeD8RJphVQ hOsqzKFmu5xJ8t13RPYPmLOptZ++kjibZ7FKPcfpOqtakaU3/B6n5J6PmXsNwIRy4H 8zlbWuCkPOUknhfTf8x6aIAG4+Hw2x+8qKa2/rmsZWKwKY3oHuv3PHQxvpoRiSW0mq n2PSPPXOJrqkkT1kJ/KSmM1R4cZuXUJ5BonT2V2ITyXIFLcoviRnYoUjwbTJUOD2qI mu+RGbSoawX4w== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 12191410A1; Fri, 8 Oct 2021 16:00:30 -0300 (-03) Date: Fri, 8 Oct 2021 16:00:30 -0300 From: Arnaldo Carvalho de Melo To: kajoljain Cc: James Clark , john.garry@huawei.com, ak@linux.intel.com, linux-perf-users@vger.kernel.org, Nick.Forrington@arm.com, Andrew.Kilroy@arm.com, Will Deacon , Mathieu Poirier , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] perf tools: Enable strict JSON parsing Message-ID: References: <20211007110543.564963-1-james.clark@arm.com> <5947c093-cff9-f70e-af20-75bc053edf5f@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5947c093-cff9-f70e-af20-75bc053edf5f@linux.ibm.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Oct 08, 2021 at 04:56:55PM +0530, kajoljain escreveu: > > > On 10/8/21 3:32 PM, James Clark wrote: > > > > > > On 08/10/2021 08:43, kajoljain wrote: > >> > >> > >> On 10/7/21 4:35 PM, James Clark wrote: > >>> After a discussion on "[PATCH 1/4] perf vendor events: Syntax corrections in Neoverse N1 json", > >>> John Garry suggested that we can just modify the parser to make it more strict. Hopefully this will > >>> remove the need to apply any future JSON comma fixup commits. > >>> > >>> Applies on top of "[PATCH v2 1/3] perf vendor events: Syntax corrections in Neoverse N1 json" on > >>> perf/core. > >>> > >>> Also available at: > >>> git clone --branch james-json-parse-fix git@git.gitlab.arm.com:linux-arm/linux-jc.git > >> > >> Hi James, > >> Do we have any dependency patches on top of this patch series. I am > >> reviewing and testing it, but in both powerpc and x86 system I am > >> getting build issue. Not sure if I am missing something> > >> I am trying your changes on top of upstream perf. > >> > >> pmu-events/arch/test/test_soc/sys/uncore.json: json error Invalid > >> character inside JSON string > > > > Hi Kajol, > > > > A trailing comma was fixed in this file 3 weeks ago at b8b350a. Can you > > confirm if you have updated to get this commit on perf core? > > > > Alternately you could pull from my branch above which is up to date enough > > to include it. > > Hi James, > Thanks for pointing it. Not getting build issue now. > > > > The file is in pmu-events/arch/test/ so I would expect it to fail on all platforms. > > > >> make[3]: *** [pmu-events/Build:18: pmu-events/pmu-events.c] Error 1 > >> make[3]: *** Deleting file 'pmu-events/pmu-events.c' > >> make[2]: *** [Makefile.perf:667: pmu-events/pmu-events-in.o] Error 2 > >> make[2]: *** Waiting for unfinished jobs.... > >> make[1]: *** [Makefile.perf:238: sub-make] Error 2 > >> make: *** [Makefile:70: all] Error 2 > >> > >> Also, Is it possible to add line number along with file name while > >> showing this error `json error Invalid character inside JSON string`. > >> It might make it easy to fix. > > > > I can add a character number with the following fix if you think that would > > be good enough? A line number might be a bigger change and involve keeping > > track of newline characters. > > Sure. I think then we can skip this change. Not sure if character > number will be helpful. > > Patch-set looks good to me. > > Reviewed-by Kajol Jain Applied ok as-is to my perf/core branch, applied and added your Reviewed-by, thanks. - Arnaldo > Thanks, > Kajol Jain > > > > > diff --git a/tools/perf/pmu-events/json.c b/tools/perf/pmu-events/json.c > > index 0544398d6e2d..41a14e1543bf 100644 > > --- a/tools/perf/pmu-events/json.c > > +++ b/tools/perf/pmu-events/json.c > > @@ -99,7 +99,7 @@ jsmntok_t *parse_json(const char *fn, char **map, size_t *size, int *len) > > res = jsmn_parse(&parser, *map, *size, tokens, > > sz / sizeof(jsmntok_t)); > > if (res != JSMN_SUCCESS) { > > - pr_err("%s: json error %s\n", fn, jsmn_strerror(res)); > > + pr_err("%s: json error at character %u '%s'\n", fn, parser.pos, jsmn_strerror(res)); > > goto error_free; > > } > > if (len) > > > > > > It prints this for the same error you have above> > > pmu-events/arch/test/test_soc/sys/uncore.json: json error at character 213 'Invalid character inside JSON string' > > > > Although funnily enough after re-introducing that extra comma it doesn't fail the build for me, > > it just prints the error message. But I may have noticed some dependency tracking issues around > > the json files. > > > > James > > -- - Arnaldo