Date: Thu, 21 Dec 2006 09:27:20 -0500 (EST)
From: Nicolas Pitre <nico@cam.org>
Subject: Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers
In-reply-to: <200612202244.03351.david-b@pacbell.net>
To: David Brownell <david-b@pacbell.net>
Cc: Andrew Morton <akpm@osdl.org>,
       Linux Kernel list <linux-kernel@vger.kernel.org>,
       Andrew Victor <andrew@sanpeople.com>,
       Bill Gatliff <bgat@billgatliff.com>,
       Haavard Skinnemoen <hskinnemoen@atmel.com>, jamey.hicks@hp.com,
       Kevin Hilman <khilman@mvista.com>, Russell King <rmk@arm.linux.org.uk>,
       Tony Lindgren <tony@atomide.com>,
       pHilipp Zabel <philipp.zabel@gmail.com>
Message-id: <Pine.LNX.4.64.0612210925130.18171@xanadu.home>
MIME-version: 1.0
Content-type: TEXT/PLAIN; charset=US-ASCII
Content-transfer-encoding: 7BIT
References: <200611111541.34699.david-b@pacbell.net>
 <200612201312.36616.david-b@pacbell.net>
 <20061220221252.732f4e97.akpm@osdl.org>
 <200612202244.03351.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 768
Lines: 24

On Wed, 20 Dec 2006, David Brownell wrote:

> On Wednesday 20 December 2006 10:12 pm, Andrew Morton wrote:
> > Why not implement them as inline functions?
> 
> I just collected and forwarded the code from Philip...
> the better not to lose such stuff!  :)
> 
>  
> > Or non-inline functions, come to that.
> 
> In this case I think that'd be preferable; see what those macros
> expand to on pxa27x CPUs.

Only if the gpio argument is not constant please.  When it is constant 
this expands to a single word store.


Nicolas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/