Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 5/5 v3] sh: fix READ/WRITE redefinition warnings
To:     Rob Landley <rob@landley.net>, linux-kernel@vger.kernel.org
Cc:     Yoshinori Sato <ysato@users.sourceforge.jp>,
        Rich Felker <dalias@libc.org>, linux-sh@vger.kernel.org,
        John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Takashi YOSHII <takasi-y@ops.dti.ne.jp>
References: <20211005001914.28574-1-rdunlap@infradead.org>
 <20211005001914.28574-6-rdunlap@infradead.org>
 <1191978c-be37-87b1-bbc9-f0aa128d0961@landley.net>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <754abc70-d539-296a-8993-3a66656e44b1@infradead.org>
Date:   Fri, 8 Oct 2021 12:46:53 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <1191978c-be37-87b1-bbc9-f0aa128d0961@landley.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/8/21 11:39 AM, Rob Landley wrote:
> On 10/4/21 7:19 PM, Randy Dunlap wrote:
>> kernel.h defines READ and WRITE, so rename the SH math-emu macros
>> to MREAD and MWRITE.
> 
> This one doesn't apply for me. My file has:
> 
> #define WRITE(d,a)      ({if(put_user(d, (typeof (d)*)a)) return -EFAULT;})
> 
> But your patch tries to remove:
> 
> -#define WRITE(d,a)     ({if(put_user(d, (typeof (d) __user *)a)) return -EFAULT;})
> 
> Which is odd because git log says my tree is current as of today, but git log on
> this file says it was last updated:
> 
> commit 2e1661d2673667d886cd40ad9f414cb6db48d8da
> Author: Eric W. Biederman <ebiederm@xmission.com>
> Date:   Thu May 23 11:04:24 2019 -0500
> 
> What did I miss?

Hi Rob,

I am making patches to linux-next, which contains this:

commit ca42bc4b7bda
Author: Al Viro <viro@zeniv.linux.org.uk>
Date:   Thu Dec 31 23:23:01 2020 +0000

     sh: fix trivial misannotations

which adds the __user annotations...


-- 
~Randy