Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/4 V9] KVM: SEV: Add support for SEV-ES intra host
 migration
To:     Peter Gonda <pgonda@google.com>
Cc:     kvm list <kvm@vger.kernel.org>, Marc Orr <marcorr@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        David Rientjes <rientjes@google.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <20211005141357.2393627-1-pgonda@google.com>
 <20211005141357.2393627-3-pgonda@google.com>
 <5f6e6f61-0d34-e640-caea-ff71ac1563d8@amd.com>
 <CAMkAt6oF52BDB4UX7DhVxQygYANfietT=gqJMQOvKJifHpivTQ@mail.gmail.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <cbc2a728-8c4d-08f9-4524-d198aba7d369@amd.com>
Date:   Fri, 8 Oct 2021 14:56:01 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <CAMkAt6oF52BDB4UX7DhVxQygYANfietT=gqJMQOvKJifHpivTQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDUvbnpwYmZrSll6REowU2R2ZStxeVE4TzJIRlJzQjdSQnNHeWdHUUxmOCtr?=
 =?utf-8?B?SlVZcENTaXRQMnduVmx1YXdDRmMzRnk1aWVVZG1NcU1TUGxmU1FrVzRrdEda?=
 =?utf-8?B?cU1zQTZQQXpQemVvWHIvUGNUb1JJa1luVlVMeGUrUWk0eFdQeWI4YzMwMDhR?=
 =?utf-8?B?UjVRUUkrcUJXdEJ6OVFlaU5NakpEOEVVYlJqMVNUaDIyNjlQaXdHQmtrSENE?=
 =?utf-8?B?aEtucDU0SUE1S1VaMy9QYmRzV1JJM2tmUDN4R2h1cEJQSTlqUUxSdXJaUEw5?=
 =?utf-8?B?cFczRWwrbzI2WStCY1hOQkw5ejEyZEY2cnpRVXFEMlNJNXh3dzdYTjBBRStB?=
 =?utf-8?B?d01tOGtENXZCQUpQU3lIR3h1ODF5Y0JXRHltMG4rNFNKbjJnWXVscVFadHh1?=
 =?utf-8?B?aXBZVE56RFdGb2Vra08zc1JQYVRVME1QVGtrYW9yYisrUmd0ZEtRNmtOUXln?=
 =?utf-8?B?R0hyNzhNY3NacnZHRFdra2JGMmlzYXRzcWVJMlZkdXBWR0dRLzNVaTl2RDhJ?=
 =?utf-8?B?cFpsWHBrcm01enZyc1ZCTkxzUEw2UjhMZWdDcXNVamU0UkM1QWcyQ3JwN3hI?=
 =?utf-8?B?Z0E0UEtveml0OTA1N1lST1JuRTFlNHIwKzNZRnBURi9lR0ZOeXZ1U3lhNWhI?=
 =?utf-8?B?cFpUTGZJQitSc0VZS1JTOUVaT1BxMlhWSG9vc1UxdXY4Q1pvcitiRmJ5YlBy?=
 =?utf-8?B?YjVHRHk5RUFvMEhwZVdDOE9lTktaR3pTLzdzZW5nMXgvem8rUGUyWDA2MmtI?=
 =?utf-8?B?eEhUOUJRK3czVXZHTDhDODd5cm5FaU9IRDRnY0cxdnYrOStxTHExaTl6dDVw?=
 =?utf-8?B?SlpzKzBlK1dZNlA2cUU0WjAzeDFZaldNeEVvOU9Ud3ZoczVIUk5Kc2dGZ0JV?=
 =?utf-8?B?TXl4ODVpbXVJRVJiUytMTDJkYUJxL1lLY0xrQVNHeExTRnkrL0h4aXYySDJa?=
 =?utf-8?B?TnNkRXZPRnRsUExZbFB5M1Yzdm9tNHkzT1IwUWs0aWlDK3pjWjNjMmloWmZV?=
 =?utf-8?B?M29rcXdvR2k3SDQxWGg3bG5oZ3AxY3psNXJyVmRObDNCZUlpSzZ4K2NpM2ZI?=
 =?utf-8?B?NE5VeDc4M1MySitYNkRDSHNzdGtsR05ZR0N5WGRNRTFXYmhJdXpYOUpaUHZM?=
 =?utf-8?B?VzFKOWFuUWpiK3RuR0Ftc2Z0NGpBcmMrV1JnS1EyRXZuNStEWUxEamFRUmRV?=
 =?utf-8?B?NVp4YjZaQlRWc3NhcUdZYndiN3NXaEc5NTZWemp2bEdNSkpaRFhGeFcxYVZs?=
 =?utf-8?B?ejRUUXVNQndRTzJ0Ty9VQ2d2SXNrNmFESzB3TWxrVE9wU2VNYW9ZbWNablZR?=
 =?utf-8?B?b0ovUlBBVlZJdm5FUVVBVi9DMks0SzZnZ1JSanBBZXFsUTNERzI3Ly9TNHVV?=
 =?utf-8?B?Mm5oQjE1K09kdGVnTERZZng5WmNKRUo3bVdRN29RSFVMZ3lPWHRScGxhNC9k?=
 =?utf-8?B?M3pVYnp0aTl4SHA2TithNHVEdGxtZEVkTytvSnQrVm42bkxjalZYb2RmZGpS?=
 =?utf-8?B?b2hwMjRHYmZqemU2WkR0c3RpQnVPQWp5b21UaW83M0IzdGhNTW9rWkU5My9T?=
 =?utf-8?B?Y0NtWFNPNXY4NDlMNGNPUlpmSFNLbTBNanFEZlNxcUs1SklqZ1VjemJGUUJQ?=
 =?utf-8?B?dUc5U21PSlZnYmk5d3huZjI1SUs5ZElVaUNYZ0poRFBVS1lCRDFheTJWb0Fv?=
 =?utf-8?B?VG9mNjFTaGpjME5xdThrS0hudjc1bjdXcllidUJKNU13c1lHaTJkeTdROXZh?=
 =?utf-8?Q?/yF2j5Kp5mMfg4ILyLPf5Q9ePh4tM7FYLMh4Cft?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d9afbc02-5876-40dd-cd5d-08d98a95a8b3
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 19:56:03.6359
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Iujexkk0SPMS3cxet/ukMmUHjOXziuhuhUCUlHNSwz3QxbSfuuKLlspqF09QIhJx8Glv73rrQzZJ03XmlveMsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5213
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/8/21 12:26 PM, Peter Gonda wrote:
> On Fri, Oct 8, 2021 at 9:38 AM Tom Lendacky <thomas.lendacky@amd.com> wrote:
>>
>> Would it make sense to have a pre-patch that puts these fields into a
>> struct? Then you can just copy the struct and zero it after. If anything
>> is ever added for any reason, then it could/should be added to the struct
>> and this code wouldn't have to change. It might be more churn than it's
>> worth, just a thought.
>>
> 
> That sounds like a good idea to me. I'll add a new patch to the start
> of the series which adds in something like:
> 
> struct vcpu_sev_es_state {
>    /* SEV-ES support */
>    struct vmcb_save_area *vmsa;
>    struct ghcb *ghcb;
>    struct kvm_host_map ghcb_map;
>    bool received_first_sipi;
>    /* SEV-ES scratch area support */
>    void *ghcb_sa;
>    u64 ghcb_sa_len;
>    bool ghcb_sa_sync;
>    bool ghcb_sa_free;
> };
> 
> struct vcpu_svm {
> ...
> struct vcpu_sev_es_state sev_es_state;
> ...
> };
> 
> I think that will make this less tedious / error prone code. Names
> sound OK or better suggestion?

Those names seem fine to me. If you want to shorten them, you could always 
drop the "_state" portion.

Thanks,
Tom

>