Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <7c14fabc-8811-5875-15a0-67884e2da78d@axentia.se>
Date:   Sat, 9 Oct 2021 01:09:56 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.2
Subject: Re: [PATCH v2 0/3] Add settle time support to iio-mux
Content-Language: en-US
To:     Vincent Whitchurch <vincent.whitchurch@axis.com>, jic23@kernel.org,
        devicetree@vger.kernel.org
Cc:     kernel@axis.com, lars@metafoo.de, linux-iio@vger.kernel.org,
        robh+dt@kernel.org, linux-kernel@vger.kernel.org
References: <20211007134641.13417-1-vincent.whitchurch@axis.com>
From:   Peter Rosin <peda@axentia.se>
Organization: Axentia Technologies AB
In-Reply-To: <20211007134641.13417-1-vincent.whitchurch@axis.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjVxMGx2THVWNFdqSTM3bFRzdEtLemNPeUVLMFZnMDhpREtGZ2hmb0dBODJv?=
 =?utf-8?B?dlFCSlVsdjJmTDNuTmtsb3VibURHTUcyVVoySnlFa2FBRGovYzFYQStwM2hl?=
 =?utf-8?B?WG04b3hka2E3OSszMWxtaHVZNmlickJKMEdwbUdxNTBMK1lGb3luN3Z2eTVz?=
 =?utf-8?B?ZzA5TlJuaUF1a2JDVUUyYTJ0NEZMTVVlRC9CMlpZN3VXa3pqRXpZM2lzV2VY?=
 =?utf-8?B?Y045SFdKV0JHSzVPdTFYRHp4eTI0WTA0ZXZ1eWZWSzRTLzY3OTd2aFI1OWtV?=
 =?utf-8?B?SUh5QnhvanVVWDlxVWhPemR5T05IS2xtNnNTM200VzRabXNMNnJhbmFMbXpM?=
 =?utf-8?B?R013cUZYSXpWeHg0cFlvcVFsVEx6bXpJMWljQURkdFg1S2p1OHYwUFVicmdN?=
 =?utf-8?B?UzM1ZmxReDk4NVRmdG43U3VTeElNeDNQanJmUWlGbDJJMTFNQXFKWkw3U1FP?=
 =?utf-8?B?TjhHMjI4YXo3Z3NZTGNVcFRxMjJha3dEanZ3b1JpZmhhdGJmV29IbmladWJz?=
 =?utf-8?B?RDcyRzRiVXpwcm1tUXhRS1diTVdoZXEvNlYxWVE5R1QvT083cnhTNlJYOWE1?=
 =?utf-8?B?aEJSQkpSNHBmbzhyYVJLalRDTEhWOVdYZnU1WWlGV3l4cnlwbVkyVkw1N0NH?=
 =?utf-8?B?MlNSS0lEYzYzQU9XNnAwWkJNMHBsTFpLUUdsS2U2ajY5M09KUnRLV0l5UnBC?=
 =?utf-8?B?cUNEZWdoSjhaRGdpdDExeUIvanM2UExpSnBxb2VoNDJJUFdPUUtUc2kwOUZY?=
 =?utf-8?B?SWZRSGVFdkU5ZW5mY282WFpmY2pLRmdXUnRVckI0YkZmOWZnSzBiRUI1TlI1?=
 =?utf-8?B?RWRTNlVZQmZQdnB6WGptS005WUZWQ1Bwb1Z2eUJ0RkV3KzNETXh5NDAzdnla?=
 =?utf-8?B?THBnZ3JMc3JNN0dnSkx0a3VQU3lMVVh2ZDZvNklKQkg1V3dwNXNPRTFpSU9B?=
 =?utf-8?B?azRmd0JQQlBvUi9LR0I3K3ExR09POG9FL3BESC8wMzRocm13TlJkci83OWZi?=
 =?utf-8?B?M0xNaGFYWEREcFd5bmtZZnp6dW8vZjcybFdiWTJTSUNrdXNFOWcxVk1oUEZU?=
 =?utf-8?B?ak5hM0h5M0IxSGJHVHRya0tYSUJLYWV1a3QwSjF1TTNmVVdyNCtVeGROaUp5?=
 =?utf-8?B?VHliTW9BMkZJaVJMRjh5aTVqMHdla0hjSnRXTkdlaTR3MkFkM1gzU2JWTHNy?=
 =?utf-8?B?K1krZWNSZ3c3d2J3SDZiTTV1UHVKUnJVTkZOL09kTHNKSGU5WDZmekZJREJR?=
 =?utf-8?B?dDZRTnZ6WVdqYlJwa1hWc2pEakJySVhuSkpCbGVSc1VjZ2ZZc21VNEJobkwr?=
 =?utf-8?B?QllwV1c0S1prY2pidm01V3JobDVndlR2SWQzV0o1blJsL2JBaTRKUmh5eWtj?=
 =?utf-8?B?eXRka1pndUQ5Y3p2Yis2NEpmUmZtemdJZEhwV3VmSG43aFl3UlRoK2MyUjd2?=
 =?utf-8?B?a3RncS8yTjlMSm43ZnNMZmVYVHZJUFlBdnpsSjUwSXUvWnNWMi9WZXRYcE9i?=
 =?utf-8?B?UW1jb1Bza244b1VDVU1zc2EyaWRYRVpLc015S3VXUG5KbENmVE9LQ0Z0VzJy?=
 =?utf-8?B?QUtWRWFML0RONjVJcWFmUTBIM3lCK0IyK2dXZlJwaFk1eWx1Z3hZWkNBeTN4?=
 =?utf-8?B?MTFUT00rcEdtTXVxcUt0U3d4YUVXZUpCOHFuRkZZODFFR0R6SVpGUUJ5d0cr?=
 =?utf-8?B?MW5yTU01TGtDRE15WXcwZ3lpTWhsdC9BbElLZ3oxZ2ZhNHl3cmxKc3BMZnFN?=
 =?utf-8?Q?h+S/u7Edt6sKsb0F2fo1aAk4uiCyWSVc3wCGBkP?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b08e5bb-9a7d-4204-40e9-08d98ab0c007
X-MS-Exchange-CrossTenant-AuthSource: DB8PR02MB5482.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 23:09:59.1812
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +EncLeFwRpTtyj7lg8aJi23+6Lf4R9P9kKxGZYeVJ4mdU9EM9sFQxbCO9X9dp34+
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR02MB4347
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vincent!

On 2021-10-07 15:46, Vincent Whitchurch wrote:
> On one of our boards we use gpio-mux with iio-mux to read voltages using an ADC
> from a few different channels, and on this board the input voltage needs some
> time to stabilize after a switch of the mux.
> 
> This series add devicetree and driver support for this kind of hardware which
> requries a settle time after muxing.
> 
> v1 -> v2:
> - Move property support to iio-mux and delay handling to mux core as suggested
>   by Peter.
> 
> v1: https://lore.kernel.org/all/20211004153640.20650-1-vincent.whitchurch@axis.com/
> 
> Vincent Whitchurch (3):
>   mux: add support for delay after muxing
>   dt-bindings: iio: io-channel-mux: Add property for settle time
>   iio: multiplexer: iio-mux: Support settle-time-us property
> 
>  .../iio/multiplexer/io-channel-mux.yaml       |  5 +++
>  drivers/iio/multiplexer/iio-mux.c             |  7 +++-
>  drivers/mux/core.c                            | 36 ++++++++++++++++---
>  include/linux/mux/consumer.h                  | 23 +++++++++---
>  include/linux/mux/driver.h                    |  4 +++
>  5 files changed, 65 insertions(+), 10 deletions(-)
> 

This looks really nice, thank you! The only question I see is if it should
go via my (virtually unused) mux tree or via the iio tree. Yes, the meat is
in mux/core.c, but I'm happy to just ack these patches and have Jonathan
handle them. But, I'm also fine with handling it in the mux tree (but I'm
getting old and forgetful, and it's been so many moons that I need to
re-learn the steps).

Jonathan, you or me? If you, you can add:

Acked-by: Peter Rosin <peda@axentia.se>

Cheers,
Peter