Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1632477717-5254-1-git-send-email-john.garry@huawei.com>
 <1632477717-5254-2-git-send-email-john.garry@huawei.com> <20211004113121.GA27373@willie-the-truck>
 <b8b51f52-1a8d-46fe-69ca-0acaf8d399f2@huawei.com>
In-Reply-To: <b8b51f52-1a8d-46fe-69ca-0acaf8d399f2@huawei.com>
From:   Yongji Xie <xieyongji@bytedance.com>
Date:   Sat, 9 Oct 2021 11:12:34 +0800
Message-ID: <CACycT3sMT7SxxS9qtZdwSENDk3fNgPHvy5X9iibaRs4na5fNzw@mail.gmail.com>
Subject: Re: [PATCH 1/5] iova: Move fast alloc size roundup into alloc_iova_fast()
To:     John Garry <john.garry@huawei.com>
Cc:     Will Deacon <will@kernel.org>, joro@8bytes.org,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        Robin Murphy <robin.murphy@arm.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        iommu@lists.linux-foundation.org,
        virtualization <virtualization@lists.linux-foundation.org>,
        linuxarm@huawei.com, thunder.leizhen@huawei.com,
        baolu.lu@linux.intel.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Oct 9, 2021 at 12:17 AM John Garry <john.garry@huawei.com> wrote:
>
> On 04/10/2021 12:31, Will Deacon wrote:
> > On Fri, Sep 24, 2021 at 06:01:53PM +0800, John Garry wrote:
> >> It really is a property of the IOVA rcache code that we need to alloc a
> >> power-of-2 size, so relocate the functionality to resize into
> >> alloc_iova_fast(), rather than the callsites.
> >>
> >> Signed-off-by: John Garry<john.garry@huawei.com>
> >> ---
> >>   drivers/iommu/dma-iommu.c            | 8 --------
> >>   drivers/iommu/iova.c                 | 9 +++++++++
> >>   drivers/vdpa/vdpa_user/iova_domain.c | 8 --------
> >>   3 files changed, 9 insertions(+), 16 deletions(-)
> > Acked-by: Will Deacon<will@kernel.org>
>
> Cheers
>
>  >
>
> Any chance of an ack from the vdpa guys on the change to their code?
>

Looks good to me.

Reviewed-by: Xie Yongji <xieyongji@bytedance.com>

Thanks,
Yongji