Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Wang, Wei W" <wei.w.wang@intel.com>
To:     "Yamahata, Isaku" <isaku.yamahata@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        "erdemaktas@google.com" <erdemaktas@google.com>,
        "Connor Kuehl" <ckuehl@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
CC:     "Yamahata, Isaku" <isaku.yamahata@intel.com>,
        "isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Kai Huang <kai.huang@linux.intel.com>,
        "Li, Xiaoyao" <xiaoyao.li@intel.com>
Subject: RE: [RFC PATCH v2 07/69] KVM: TDX: define and export helper functions
 for KVM TDX support
Thread-Topic: [RFC PATCH v2 07/69] KVM: TDX: define and export helper
 functions for KVM TDX support
Thread-Index: AQHXb45gwUyUjxU7oUmevY7jRUUgu6vK2P1A
Date:   Sat, 9 Oct 2021 07:50:57 +0000
Message-ID: <bd974cdc810443748d8e4e3c7d1677a5@intel.com>
References: <cover.1625186503.git.isaku.yamahata@intel.com>
 <4fe4ce4faf5ad117f81d411deb00ef3b9657c842.1625186503.git.isaku.yamahata@intel.com>
In-Reply-To: <4fe4ce4faf5ad117f81d411deb00ef3b9657c842.1625186503.git.isaku.yamahata@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.200.16
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk

On Saturday, July 3, 2021 6:04 AM, Isaku Yamahata wrote:
> Subject: [RFC PATCH v2 07/69] KVM: TDX: define and export helper functions
> for KVM TDX support
> +/*
> + * Setup one-cpu-per-pkg array to do package-scoped SEAMCALLs. The
> +array is
> + * only necessary if there are multiple packages.
> + */
> +int __init init_package_masters(void)
> +{
> +	int cpu, pkg, nr_filled, nr_pkgs;
> +
> +	nr_pkgs = topology_max_packages();
> +	if (nr_pkgs == 1)
> +		return 0;
> +
> +	tdx_package_masters = kcalloc(nr_pkgs, sizeof(int), GFP_KERNEL);


Where is the corresponding kfree() invoked? (except the one invoked on error conditions below)


> +	if (!tdx_package_masters)
> +		return -ENOMEM;
> +
> +	memset(tdx_package_masters, -1, nr_pkgs * sizeof(int));
> +
> +	nr_filled = 0;
> +	for_each_online_cpu(cpu) {
> +		pkg = topology_physical_package_id(cpu);
> +		if (tdx_package_masters[pkg] >= 0)
> +			continue;
> +
> +		tdx_package_masters[pkg] = cpu;
> +		if (++nr_filled == topology_max_packages())
> +			break;
> +	}
> +
> +	if (WARN_ON(nr_filled != topology_max_packages())) {
> +		kfree(tdx_package_masters);
> +		return -EIO;
> +	}

Best,
Wei