Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 9 Oct 2021 10:37:30 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-next@vger.kernel.org,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] MIPS: asm: pci: define arch-specific
 'pci_remap_iospace()' dependent on 'CONFIG_PCI_DRIVERS_GENERIC'
Message-ID: <YWFUyhO5uRoks6sd@kroah.com>
References: <20211008095311.26475-1-sergio.paracuellos@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211008095311.26475-1-sergio.paracuellos@gmail.com>
Precedence: bulk

On Fri, Oct 08, 2021 at 11:53:11AM +0200, Sergio Paracuellos wrote:
> Some MIPS defconfigs that don't define 'CONFIG_PCI_DRIVERS_GENERIC' but
> define 'CONFIG_PCI_DRIVERS_LEGACY' or none of them, can fail when they are
> built since definition for 'pci_remap_iospace' is being done in include
> file 'arch/mips/include/asm/pci.h' and the specific function implemented
> in 'arch/mips/pci/pci-generic.c'. MIPS PCI drivers that don't use generic
> PCI core APIs don't really need 'pci_remap_iospace' to be defined at all.
> Hence, change definition for 'pci_remap_iospace' to be dependent on the
> preprocessor 'CONFIG_PCI_DRIVERS_GENERIC' definition to avoid possible
> build problems.
> 
> CC: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Fixes: 9f76779f2418 ("MIPS: implement architecture-specific 'pci_remap_iospace()'")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
> Hi Greg, Thomas, Stephen,
> 
> I guess this should also go through the staging-tree.

Now queued up, thanks!

greg k-h