Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp3110953pxb; Sat, 9 Oct 2021 01:59:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyD/3U1RU4jG1DU7TRRYEazSN/VCBPea8LYDHmrHKeD5YShEjZAxObEl2lrFtEjCvlzQsh X-Received: by 2002:a05:6a00:15d6:b0:44c:238e:8269 with SMTP id o22-20020a056a0015d600b0044c238e8269mr14341857pfu.15.1633769971123; Sat, 09 Oct 2021 01:59:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633769971; cv=none; d=google.com; s=arc-20160816; b=Lf87ESLEdsO+BZGzBQwpcXuGUyMa7mEZEUvjvMuc2XctDA61npTw+zLChPJQhj2d3p omLZD4OuOJaDszADu+NAZcKMDkR+7nbWWN3mXIjPECfdELWq1oP73/+e8P2hkXqT3Ssu PHvcjX0GJB9PfnXjv4+dXDXraIZB6whi5ZC3OqTjvrZy+90zczOTj6UWdMR1e0mwJjdX 6KkHd1dfKqe2v4AJEWWmYiQdCo+nfFayw5iyXtMQL44oTgIdr7xcpkP3kvxGwDJYHpNz ndlvtu16WMPaf33YOYe2E0HYNYqP9JofAR3P9AfTUlrx7QSfjTJ6XSDl/Zl4BOpR/Dp+ arnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=aTETtMCppr4tGbUb2o/oFTUtvUEuIA4LrxQYmVuG5UA=; b=X4YZbrr/jfHcTcOdbViFhIkdP1mB4HMxN7ZOH0BI3kKDYZe0KxwgeeIczCf6DG0SSE docIBn9pL8iprwggqrRxObYQNJMG6WtGCoioyh28c2seKrXEj7Iv2D4B3tbmZLSC6cZM Lus7+yq7u0BhYL3Rh+aEiz1soAAMohJcB9WTffkxOKmY5FUnE5xfDy8BXzRmABvz2znz Eh5DAy3sLUi91htPj+zydWGfYrggUeIKMoG4CDu+loxcMvX1WSJCx/EQEePH9fVHGpsL toRcaB8z8nmjLGlcYtNPnJfiGPzRWJ3lwQQQlYXOfmqvzJGkFLMVflv2mYnwI1Gi54eB JDeQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h3si926290pjz.157.2021.10.09.01.59.18; Sat, 09 Oct 2021 01:59:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231761AbhJII7d (ORCPT + 99 others); Sat, 9 Oct 2021 04:59:33 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:28903 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231344AbhJII7c (ORCPT ); Sat, 9 Oct 2021 04:59:32 -0400 Received: from dggeme764-chm.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4HRJjx6KNlzbn03; Sat, 9 Oct 2021 16:53:09 +0800 (CST) Received: from compute.localdomain (10.175.112.70) by dggeme764-chm.china.huawei.com (10.3.19.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Sat, 9 Oct 2021 16:57:34 +0800 From: Jing Xiangfeng To: , , CC: , , , Subject: [PATCH] drm/virtio: fix the missed drm_gem_object_put() in virtio_gpu_user_framebuffer_create() Date: Sat, 9 Oct 2021 17:09:20 +0800 Message-ID: <1633770560-11658-1-git-send-email-jingxiangfeng@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.112.70] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggeme764-chm.china.huawei.com (10.3.19.110) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org virtio_gpu_user_framebuffer_create() misses to call drm_gem_object_put() in an error path. Add the missed function call to fix it. Signed-off-by: Jing Xiangfeng --- drivers/gpu/drm/virtio/virtgpu_display.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index a6caebd4a0dd..5b00310ac4cd 100644 --- a/drivers/gpu/drm/virtio/virtgpu_display.c +++ b/drivers/gpu/drm/virtio/virtgpu_display.c @@ -308,8 +308,10 @@ virtio_gpu_user_framebuffer_create(struct drm_device *dev, return ERR_PTR(-EINVAL); virtio_gpu_fb = kzalloc(sizeof(*virtio_gpu_fb), GFP_KERNEL); - if (virtio_gpu_fb == NULL) + if (virtio_gpu_fb == NULL) { + drm_gem_object_put(obj); return ERR_PTR(-ENOMEM); + } ret = virtio_gpu_framebuffer_init(dev, virtio_gpu_fb, mode_cmd, obj); if (ret) { -- 2.26.0.106.g9fadedd