Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] RDMA/hns: Use dma_alloc_coherent() instead of
 kmalloc/dma_map_single()
To:     Jason Gunthorpe <jgg@nvidia.com>,
        Cai Huoqing <caihuoqing@baidu.com>
References: <20210926061116.282-1-caihuoqing@baidu.com>
 <20210927115913.GA3544071@ziepe.ca> <20211004195224.GA2576309@nvidia.com>
CC:     Lijun Ou <oulijun@huawei.com>, Weihang Li <liweihang@huawei.com>,
        "Doug Ledford" <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
From:   Wenpeng Liang <liangwenpeng@huawei.com>
Message-ID: <07922740-2d3d-50dc-7239-421e39c42142@huawei.com>
Date:   Sat, 9 Oct 2021 17:50:50 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <20211004195224.GA2576309@nvidia.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021/10/5 3:52, Jason Gunthorpe wrote:
> On Mon, Sep 27, 2021 at 08:59:13AM -0300, Jason Gunthorpe wrote:
>> On Sun, Sep 26, 2021 at 02:11:15PM +0800, Cai Huoqing wrote:
>>> Replacing kmalloc/kfree/dma_map_single/dma_unmap_single()
>>> with dma_alloc_coherent/dma_free_coherent() helps to reduce
>>> code size, and simplify the code, and coherent DMA will not
>>> clear the cache every time.
>>>
>>> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
>>>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 20 +++++---------------
>>>  1 file changed, 5 insertions(+), 15 deletions(-)
>>
>> Given I don't see any dma_sync_single calls for this mapping, isn't
>> this a correctness fix too?
> 
> HNS folks?
> 
> Jason
> .
> 

Our SoC can keep cache coherent, so there is no exception even if
dma_sync_single* is not called, but the driver should not make
assumptions about SoC.

So using dma_alloc_coherent() instead of kmalloc/dma_map_single()
can simplify the code and achieve the same purpose.

Wenpeng Liang