Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 9 Oct 2021 12:49:08 -0400
From:   Joe Korty <joe.korty@concurrent-rt.com>
To:     Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Steven Rostedt <rostedt@goodmis.org>,
        Clark Williams <williams@redhat.com>,
        Jun Miao <jun.miao@windriver.com>,
        linux-rt-users <linux-rt-users@vger.kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5.10-rt+] drm/i915/gt: transform irq_disable into
 local_lock.
Message-ID: <20211009164908.GA21269@zipoli.concurrent-rt.com>
Reply-To: Joe Korty <joe.korty@concurrent-rt.com>
References: <20211007165928.GA43890@zipoli.concurrent-rt.com>
 <20211007171929.hegwwqelf46skjyw@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211007171929.hegwwqelf46skjyw@linutronix.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ANCZK1U39C0Qla6+fPUoeO0KhdoTkzACENldBzJBhaxVT/lzjwhJvZLrzrAe?=
 =?us-ascii?Q?H8MLCG8hPrHwjp+Ov4grwFVfNBP9ipUWS5D+CoGJsl/JXgxxlaKXTppyxC3h?=
 =?us-ascii?Q?YHqNh+oEfc1qIcC3c/JS0NU+FeiHQjAs3Pe83a3BpdWUpincyAmnkdkPVPSf?=
 =?us-ascii?Q?Y4zMB4QvG+JF2SLiJAJEq75lCymGUSLlDM86cuedsMTJNZq+/qUApRnhgg0X?=
 =?us-ascii?Q?/ROkXVh5Bj0TaQu9k/yBRUdOx3DCLuf8nVPXnsml+mDXVGlKutBjVpsGUtGv?=
 =?us-ascii?Q?KmJLzAeiWV0ow7jk8GoBBjt1kHqTlGROHW1wc57wzdsu0jZ7KkaNaRvnHQxh?=
 =?us-ascii?Q?Ig02XHC3D/VT8VNtbVUWs4LNhhdgWe2egBu1pgiFedCO/22jMSSXvpNYlydC?=
 =?us-ascii?Q?wltZsBLCQM+UN5Vxd7hMsWmNut3Dcn0X85Whh0rrZ8zqk96rCkYoomfhEByx?=
 =?us-ascii?Q?4XYqAXZnv04Mp/2Gc9Q+eLauqpLT/SU30gKmZpOMyV3qxDBlAIbIg3l66Oyk?=
 =?us-ascii?Q?2w6wussUklzixII/pmBwQweKY7NU4m2Ru1XYI/4N9xJGCjIFRZitbzuQhYZQ?=
 =?us-ascii?Q?9MZ3gEkFFptz18uu80x6E/A85yPiSoi3B378f+dXPr+pj7vJx+xb8JCXwFJx?=
 =?us-ascii?Q?6wpuQZ9xHkbTC9YzhzR9FzuFLVUEEZt81ZYNr2DSiziyOMr1mf5eoA9aieQ8?=
 =?us-ascii?Q?e0xwvrvU2h18MEzdp9zvkt62yD/Fr6ofFKfNKTjhm0QUqpD19Notpq8hrP8X?=
 =?us-ascii?Q?W0xwZNDvvAegiodaO16SKjCCudwVmaY619OlQBo0m8EkpKMRxM0HsNAgA+ht?=
 =?us-ascii?Q?P1mK2ekSVDVmPDsbfcQOcnjk+HoAluSPoCaWYLZvpUuxTr1o6Aqqg4/zaBdO?=
 =?us-ascii?Q?wvFEEi1po0yS7Y33gstMCXtKxW3gv6dkAPPfyWFM7pJc/16gN8ongttFXjZS?=
 =?us-ascii?Q?wDs+VAyVUbVVE+Er96lK1NgCG8/paFfaMOMhX4bfpnuRGjI9NCzC9xpZWE+d?=
 =?us-ascii?Q?scbtm2+G+r9d8Zb22v/EzXUPCKApH5iiyE2NpN3gyynO/lLfIxladCTvX2EI?=
 =?us-ascii?Q?mhP53aBp657T8A9HBNJwIa/NlpVLvPvIZ7uWDRE/+TrP+e3tVD8uuwA4qujN?=
 =?us-ascii?Q?2L1GlPYmjIdQlUHjLYa9FH+mEAISq/wJQZvxAJMGwJ2VOfz1FlYKOXaAyMLT?=
 =?us-ascii?Q?4bnC8X/OCnI2irB5nwSVJwqNPiANoMwJX8lBWdn6Z14Tp+LAx70oTWn74nv9?=
 =?us-ascii?Q?1FYe7wKqSpf6HuKghHCRWHomar+A6LHRY5cq0GgOr2Cvu23UNPWB38iBHrd0?=
 =?us-ascii?Q?2a01NJqEEqTwiUGHgV4YzdCQ?=
X-OriginatorOrg: concurrent-rt.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3322e61c-0373-4964-dcd8-08d98b44b8b9
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB2007.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2021 16:49:13.8594
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38747689-e6b0-4933-86c0-1116ee3ef93e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KM7CyVVhjCOc3g4cSyMxSWeQCTZwTt2tWI/aKpgRQPaU2bBD+cMV+UZmpJvn3Hx2G95YwZaTNncnOejGeOySUVu85fCfBMuUexV7q3os584=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1559
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 07, 2021 at 07:19:29PM +0200, Sebastian Andrzej Siewior wrote:
> On 2021-10-07 12:59:28 [-0400], Joe Korty wrote:
> > Convert IRQ blocking in intel_breadcrumbs_park() to a local lock.
> > 
> > Affects 5.10-rt and all later releases, up to and including when
> > rt was merged into mainline.
> 
> RT was merged into mainline? Nobody tells me anything anymore??? 
> 
> > This problem has been reported in two other linux-rt-users postings,
> >   
> >    [PREEMPT_RT] i915: fix PREEMPT_RT locking splats (Clark Williams)
> >    [linux-5.12.y-rt] drm/i915/gt: Fix a lockdep warning with interrupts enabled (Jun Miao)
> > 
> > Neither of these submit the obvious solution, nor,
> > AFAICT, has either yet been acted on.  So I muddy the
> > waters further by submitting this, a third fix.
> 
> 5.12 is longer maintained. Could you please take the latest devel tree
> for testing and participate in
>   https://lore.kernel.org/all/20211005150046.1000285-1-bigeasy@linutronix.de/
> 
> If anything I would prefer those patches backported into v5.10 if it is
> affected.


Hi Sebastian,
Please add my 'Tested-by' to the below patch.  

   [linux-5.12.y-rt] drm/i915/gt: Fix a lockdep warning with interrupts enabled (Jun Miao)

What was tested was a backport to 5.10-rt.  One reject
was encountered, trivially resolved.  No other adjustments
were made.

My regression tests of last night all passed without any
of the usual lockdep splats occuring.  Prior to this,
I could be assured of a large enough flood of splats to
overwhelm the kernel log.

My test stand is a Supermicro C7Z170-SQ.  This is tthe
only system I have on which I could trigger the problem.

I could not find this patch in the 5.12-rt or the 5.15-rt
tree, so I fetched a copy out of the linux-rt-users
archives, and backported that.

Tested-by: Joe Korty <joe.korty@concurrent-rt.com>