Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <0f625a108a2905c4f7d7ebb5b0db62b42f865338.camel@perches.com>
Subject: Re: [PATCH v3 02/10] cxl/pci: Remove dev_dbg for unknown register
 blocks
From:   Joe Perches <joe@perches.com>
To:     Dan Williams <dan.j.williams@intel.com>, linux-cxl@vger.kernel.org
Cc:     Ben Widawsky <ben.widawsky@intel.com>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, hch@lst.de
Date:   Sat, 09 Oct 2021 09:48:10 -0700
In-Reply-To: <163379784717.692348.3478221381958300790.stgit@dwillia2-desk3.amr.corp.intel.com>
References: <163379783658.692348.16064992154261275220.stgit@dwillia2-desk3.amr.corp.intel.com>
         <163379784717.692348.3478221381958300790.stgit@dwillia2-desk3.amr.corp.intel.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.0-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sat, 2021-10-09 at 09:44 -0700, Dan Williams wrote:
> From: Ben Widawsky <ben.widawsky@intel.com>
> 
> While interesting to driver developers, the dev_dbg message doesn't do
> much except clutter up logs.

So?  This isn't enabled by default.  How does it 'clutter' logs?

> This information should be attainable
> through sysfs, and someday lspci like utilities. This change
> additionally helps reduce the LOC in a subsequent patch to refactor some
> of cxl_pci register mapping.
> 
> Signed-off-by: Ben Widawsky <ben.widawsky@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> ?drivers/cxl/pci.c |    3 ---
> ?1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
> index 64180f46c895..ccc7c2573ddc 100644
> --- a/drivers/cxl/pci.c
> +++ b/drivers/cxl/pci.c
> @@ -475,9 +475,6 @@ static int cxl_pci_setup_regs(struct cxl_mem *cxlm)
> ?		cxl_decode_register_block(reg_lo, reg_hi, &bar, &offset,
> ?					  &reg_type);
> ?
> 
> -		dev_dbg(dev, "Found register block in bar %u @ 0x%llx of type %u\n",
> -			bar, offset, reg_type);
> -
> ?		/* Ignore unknown register block types */
> ?		if (reg_type > CXL_REGLOC_RBI_MEMDEV)
> ?			continue;
>