Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 10 Oct 2021 00:50:57 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Tao Zhou <tao.zhou@linux.dev>
Cc:     linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>
Subject: Re: [PATCH] sched/fair: Check idle_cpu in select_idle_core/cpu()
Message-ID: <20211009225057.GB174703@worktop.programming.kicks-ass.net>
References: <20211009180941.20458-1-tao.zhou@linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211009180941.20458-1-tao.zhou@linux.dev>
Precedence: bulk

On Sun, Oct 10, 2021 at 02:09:41AM +0800, Tao Zhou wrote:
> In select_idle_core(), the idle core returned may have no cpu
> allowed. I think the idle core returned for the task is the one
> that can be allowed to run. I insist on this semantics.
> 
> In select_idle_cpu(), if select_idle_core() can not find the
> idle core, one reason is that the core is not allowed for the
> task, but the core itself is idle from the point of
> sds->has_idle_cores. I insist on this semantics.
> 
> No others, just two additional check.
> ---
>  kernel/sched/fair.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index f6a05d9b5443..a44aca5095d3 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -6213,7 +6213,7 @@ static int select_idle_core(struct task_struct *p, int core, struct cpumask *cpu
>  			*idle_cpu = cpu;
>  	}
>  
> -	if (idle)
> +	if (idle && *idle_cpu != -1)
>  		return core;

In that case, core would be nr_cpu_ids (==nr_cpumask_bits), and then the caller checks:

	(unsigned)i < nr_cpumask_bits

>  	cpumask_andnot(cpus, cpus, cpu_smt_mask(core));
> @@ -6324,7 +6324,7 @@ static int select_idle_cpu(struct task_struct *p, struct sched_domain *sd, bool
>  		}
>  	}
>  
> -	if (has_idle_core)
> +	if (has_idle_core && *idle_cpu != -1)
>  		set_idle_cores(target, false);

And this one I'm completely failing, why shouldn't we mark the core as
non-idle when there is a single idle CPU found? That's just worng.