Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH v3 2/2] PCI/sysfs: use NUMA_NO_NODE macro
To:     Bjorn Helgaas <helgaas@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     <hch@infradead.org>, <linux-kernel@vger.kernel.org>,
        <linux-pci@vger.kernel.org>, <bhelgaas@google.com>,
        <stefanha@redhat.com>, <oren@nvidia.com>, <kw@linux.com>
References: <20211008222550.GA1385680@bhelgaas>
From:   Max Gurtovoy <mgurtovoy@nvidia.com>
Message-ID: <a947cd7e-c847-4d44-5a65-51bbdceb1a1d@nvidia.com>
Date:   Sun, 10 Oct 2021 11:36:49 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211008222550.GA1385680@bhelgaas>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2021 08:37:00.9921
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 57f34661-50e9-4f82-2c92-08d98bc92139
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT019.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1835
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/9/2021 1:25 AM, Bjorn Helgaas wrote:
> On Mon, Oct 04, 2021 at 04:34:53PM +0300, Max Gurtovoy wrote:
>> Use the proper macro instead of hard-coded (-1) value.
>>
>> Suggested-by: Krzysztof Wilczyński <kw@linux.com>
>> Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> These two patches are independent, so I applied this patch only to
> pci/sysfs for v5.16, thanks!
>
> I assume Greg will take the drivers/base patch.

I saw both patches in his 
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 
driver-core-next

So I guess there is no need for taking it separately, right Greg ?

>> ---
>>   drivers/pci/pci-sysfs.c | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
>> index 7fb5cd17cc98..f807b92afa6c 100644
>> --- a/drivers/pci/pci-sysfs.c
>> +++ b/drivers/pci/pci-sysfs.c
>> @@ -81,8 +81,10 @@ static ssize_t pci_dev_show_local_cpu(struct device *dev, bool list,
>>   	const struct cpumask *mask;
>>   
>>   #ifdef CONFIG_NUMA
>> -	mask = (dev_to_node(dev) == -1) ? cpu_online_mask :
>> -					  cpumask_of_node(dev_to_node(dev));
>> +	if (dev_to_node(dev) == NUMA_NO_NODE)
>> +		mask = cpu_online_mask;
>> +	else
>> +		mask = cpumask_of_node(dev_to_node(dev));
>>   #else
>>   	mask = cpumask_of_pcibus(to_pci_dev(dev)->bus);
>>   #endif
>> -- 
>> 2.18.1
>>