Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] staging: rtl8723bs: hal: remove duplicate check
To:     Saurav Girepunje <saurav.girepunje@gmail.com>,
        gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
        marcocesati@gmail.com, dan.carpenter@oracle.com,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc:     saurav.girepunje@hotmail.com
References: <YWKRfYpTioAmTWa0@user>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <6c589c93-b224-1490-5f38-63947f02ff6a@redhat.com>
Date:   Sun, 10 Oct 2021 14:45:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <YWKRfYpTioAmTWa0@user>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 10/10/21 9:08 AM, Saurav Girepunje wrote:
> Remove 'bPerformance' from if condition check. As on previous
> if condition it is already check for same variable.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

> ---
>  drivers/staging/rtl8723bs/hal/odm_DIG.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/odm_DIG.c b/drivers/staging/rtl8723bs/hal/odm_DIG.c
> index beda7b8a7c6a..7e92c373cddb 100644
> --- a/drivers/staging/rtl8723bs/hal/odm_DIG.c
> +++ b/drivers/staging/rtl8723bs/hal/odm_DIG.c
> @@ -544,7 +544,7 @@ void odm_DIG(void *pDM_VOID)
>  	/* 1 Adjust initial gain by false alarm */
>  	if (pDM_Odm->bLinked && bPerformance) {
> 
> -		if (bFirstTpTarget || (FirstConnect && bPerformance)) {
> +		if (bFirstTpTarget || FirstConnect) {
>  			pDM_DigTable->LargeFAHit = 0;
> 
>  			if (pDM_Odm->RSSI_Min < DIG_MaxOfMin) {
> --
> 2.32.0
>