Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3] dt-bindings: net: nfc: nxp,pn544: Convert txt bindings
 to yaml
To:     Rob Herring <robh@kernel.org>, David Heidelberg <david@ixit.cz>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        devicetree@vger.kernel.org, ~okias/devicetree@lists.sr.ht
References: <20211009161941.41634-1-david@ixit.cz>
 <1633894316.431235.3158667.nullmailer@robh.at.kernel.org>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Message-ID: <1a315cff-fa34-0fac-8312-9a96d56966c7@canonical.com>
Date:   Sun, 10 Oct 2021 23:01:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <1633894316.431235.3158667.nullmailer@robh.at.kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/10/2021 21:31, Rob Herring wrote:
> On Sat, 09 Oct 2021 18:19:42 +0200, David Heidelberg wrote:
>> Convert bindings for NXP PN544 NFC driver to YAML syntax.
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>> v2
>>  - Krzysztof is a maintainer
>>  - pintctrl dropped
>>  - 4 space indent for example
>>  - nfc node name
>> v3
>>  - remove whole pinctrl
>>  .../bindings/net/nfc/nxp,pn544.yaml           | 61 +++++++++++++++++++
>>  .../devicetree/bindings/net/nfc/pn544.txt     | 33 ----------
>>  2 files changed, 61 insertions(+), 33 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml
>>  delete mode 100644 Documentation/devicetree/bindings/net/nfc/pn544.txt
>>
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
> 
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/patch/1538804
> 
> 
> pn547@28: 'clock-frequency' is a required property
> 	arch/arm64/boot/dts/qcom/msm8992-msft-lumia-octagon-talkman.dt.yaml
> 	arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dt.yaml
> 

I think clock-frequency should be dropped from I2C slave device.
Similarly to this one:
https://lore.kernel.org/linux-nfc/f955726a-eb2d-7b3e-9c5f-978358710eb6@canonical.com/T/#u


Best regards,
Krzysztof