Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <16d2a19b-5092-763b-230c-5b0a6237d852@gmail.com>
Date:   Sun, 10 Oct 2021 18:50:39 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.2
Subject: Re: [net-next PATCH v5 04/14] dt-bindings: net: dsa: qca8k: Document
 support for CPU port 6
Content-Language: en-US
To:     Ansuel Smith <ansuelsmth@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211011013024.569-1-ansuelsmth@gmail.com>
 <20211011013024.569-5-ansuelsmth@gmail.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <20211011013024.569-5-ansuelsmth@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/10/2021 6:30 PM, Ansuel Smith wrote:
> The switch now support CPU port to be set 6 instead of be hardcoded to
> 0. Document support for it and describe logic selection.
> 
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
>   Documentation/devicetree/bindings/net/dsa/qca8k.txt | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> index cc214e655442..aeb206556f54 100644
> --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> @@ -29,7 +29,11 @@ the mdio MASTER is used as communication.
>   Don't use mixed external and internal mdio-bus configurations, as this is
>   not supported by the hardware.
>   
> -The CPU port of this switch is always port 0.
> +This switch support 2 CPU port. 

Plural: ports.

> Normally and advised configuration is with
> +CPU port set to port 0. It is also possible to set the CPU port to port 6
> +if the device requires it. The driver will configure the switch to the defined
> +port. With both CPU port declared the first CPU port is selected as primary
> +and the secondary CPU ignored.

Is this universally supported by all models that this binding covers? If 
not, you might want to explain that?
-- 
Florian