Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jiping Ma <jiping.ma2@windriver.com>
To:     jejb@linux.ibm.com, martin.petersen@oracle.com,
        scott.benesh@microchip.com, don.brace@microchip.com,
        scott.teel@microchip.com, kevin.barnett@microchip.com,
        Murthy.Bhat@microchip.com, jiping.ma2@windriver.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        yue.tao@windriver.com
Subject: [PATCH] scsi: smartpqi: Enable sas_address sys fs for SATA device type.
Date:   Sun, 10 Oct 2021 19:46:11 -0700
Message-Id: <20211011024611.152626-1-jiping.ma2@windriver.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?v8fgzsFnMg0GRb+NGlkYkFYf+8BSWrpzNhgO6RlPNG79LmjITjV5HhJs8BNM?=
 =?us-ascii?Q?djszJYhmuoMG2VzD1VkiOGSKcfa7SfJLRnPDyS572RpyWh0D5N3Ch5uXIRSx?=
 =?us-ascii?Q?I8Tv6o8JZA3bPxkYPPo+YfulcwuerVbF+2Cxsi/MtRSw8IFyL9BdOBd8fzqb?=
 =?us-ascii?Q?ZZZoZWdxtb2S3LxRlVwrdW4JKajvCyyqbtqE5LE7/R3tpYChQn30IshroQhn?=
 =?us-ascii?Q?Lju8kisPmVnNuXwqBihd+WK991O1IeRtg9vo5IE/muNeRnhrJirIYH6K3xGl?=
 =?us-ascii?Q?ABFvPBXDU6zaONErqIyiOX4kngFzI1SbTZ91g0xl6PzZRCe7+VhfqJkfBDTr?=
 =?us-ascii?Q?ZWjYASv0fKhrmmSwfuHLMVOqgYcDWwojwvZHfXOdR6ir4BdEo5RW9QLJ4UyB?=
 =?us-ascii?Q?iAAYhbiJr8zpFfqyafPDfbKYG6UvkK2U33PcEUxDp6oWtPoPfRC6eBfaLQPt?=
 =?us-ascii?Q?u3spK1dHfPteaTpw0k052wTwHT2NcoTy8ub//8PwqnregwnBq34be8r/jWTd?=
 =?us-ascii?Q?oIcFircVx2taLcbaIBFSXl87ZF//dgQzSEPusSFl7ZiltBVTjabTlm/+Qn71?=
 =?us-ascii?Q?xGPyNCPIc7ztOBAwWw+U6IHe7xoS4dQ0MXiNWsSUkYCwl8NpRqCZWYIy2/rT?=
 =?us-ascii?Q?LTim1sL+zfhURAUm6ytrsDUUF3XagyjaPzJnM1mAvGFaB7khVazVsBddSbv0?=
 =?us-ascii?Q?CPboYUbBF9CNCnGXE7DxsFxaaOE4LSyB/LhDvlRKt92W+JswxPp5aXjerN5d?=
 =?us-ascii?Q?NdkApixgdFLYX+iWx7bOJj7EV6ds5txuU4Jyuu0UDzxgQ92G3MS564dO9s/x?=
 =?us-ascii?Q?w+e0TNnIWvNpTPPn2zehFGKwPCA5R7MfOOcDAqsW/9JzD5Uj/UeRkEYpkx9H?=
 =?us-ascii?Q?4BnwurWbIGOleXObcjgrcH1jBWF/9zhhYlFOMSoQjkKyV+uLUfQUKN28vNYt?=
 =?us-ascii?Q?zieicH5uU8+GSfF2Fkvnu7i8YzLwuj9WrxLBW87kYo+rP8ptYsjY3KogGHkN?=
 =?us-ascii?Q?Qj7P7tI24w/s/zhCpOR0AdbftlWEVoN7NRcUDjyoW910ZFciN5WNl5Sjw+QP?=
 =?us-ascii?Q?0xukoErjNFipOpqqNgI8WTmpAujW9FsLSbmfBQ2gjxlhh5VKJSNb23LoxYhH?=
 =?us-ascii?Q?u6DMAHROpydGlOWQQU4llnAMdVLKqofmWtaUmtncSX/dwUPGkylKZvnxGuLM?=
 =?us-ascii?Q?k3QZHQS1I2WjAGNwGkHu8p/mgI1FcX4Alfyhw0wNPtGs3W5EFJGPItD2CT6p?=
 =?us-ascii?Q?N4vNu0Wz2jl8Xf8I8uz4pIycm2eiC+ToiGqlwiX3oBWvT0Nizc2Tp6GMVin/?=
 =?us-ascii?Q?9h6RLKij7jDyyj45D6FISHRr?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3158f7e-7b24-478a-ef45-08d98c614d17
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2747.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 02:46:18.5474
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OmYSeXbTMGBtzmof+kswoxoIpbxjyP1ZPQJx0pkLfv8mcFIsvR8AJgHeQ1NOHi8my8PEay8GhfovjR/QwSyQFFi8lFXM15qAe89cnVac5yI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5501
X-Proofpoint-ORIG-GUID: 7dN6nTa8kYmIsTIIQE_c8sbKTwYWeCtS
X-Proofpoint-GUID: 7dN6nTa8kYmIsTIIQE_c8sbKTwYWeCtS
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-10-10_07,2021-10-07_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 suspectscore=0 priorityscore=1501 adultscore=0 spamscore=0 malwarescore=0
 phishscore=0 mlxscore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=986
 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110110014
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Current version:
/sys/devices/pci0000:36/0000:36:02.0/0000:3b:00.0/host0/scsi_host/host0$
find -name sas_address -print -exec cat {} \;
./port-0:3/end_device-0:3/sas_device/end_device-0:3/sas_address
0x0000000000000000
./port-0:3/end_device-0:3/target0:0:2/0:0:2:0/sas_address
cat: ./port-0:3/end_device-0:3/target0:0:2/0:0:2:0/sas_address:
No such device
./port-0:1/end_device-0:1/target0:0:0/0:0:0:0/sas_address
cat: ./port-0:1/end_device-0:1/target0:0:0/0:0:0:0/sas_address:
No such device
./port-0:1/end_device-0:1/sas_device/end_device-0:1/sas_address
0x0000000000000000
./port-0:4/end_device-0:4/sas_device/end_device-0:4/sas_address
0x0000000000000000
./port-0:4/end_device-0:4/target0:0:3/0:0:3:0/sas_address
cat: ./port-0:4/end_device-0:4/target0:0:3/0:0:3:0/sas_address:
No such device
./port-0:2/end_device-0:2/sas_device/end_device-0:2/sas_address
0x0000000000000000
./port-0:2/end_device-0:2/target0:0:1/0:0:1:0/sas_address
cat: ./port-0:2/end_device-0:2/target0:0:1/0:0:1:0/sas_address:
No such device

After patch applied:
/sys/devices/pci0000:36/0000:36:02.0/0000:3b:00.0/host0/scsi_host/host0$
find -name sas_address -print -exec cat {} \;
./port-0:3/end_device-0:3/sas_device/end_device-0:3/sas_address
0x31402ec001d92985
./port-0:3/end_device-0:3/target0:0:2/0:0:2:0/sas_address
0x31402ec001d92985
./port-0:1/end_device-0:1/target0:0:0/0:0:0:0/sas_address
0x31402ec001d92983
./port-0:1/end_device-0:1/sas_device/end_device-0:1/sas_address
0x31402ec001d92983
./port-0:4/end_device-0:4/sas_device/end_device-0:4/sas_address
0x31402ec001d92986
./port-0:4/end_device-0:4/target0:0:3/0:0:3:0/sas_address
0x31402ec001d92986
./port-0:2/end_device-0:2/sas_device/end_device-0:2/sas_address
0x31402ec001d92984
./port-0:2/end_device-0:2/target0:0:1/0:0:1:0/sas_address
0x31402ec001d92984

Signed-off-by: Jiping Ma <jiping.ma2@windriver.com>
---
 drivers/scsi/smartpqi/smartpqi_init.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index ecb2af3f43ca..df16e0a27a41 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -2101,6 +2101,7 @@ static inline void pqi_mask_device(u8 *scsi3addr)
 static inline bool pqi_is_device_with_sas_address(struct pqi_scsi_dev *device)
 {
 	switch (device->device_type) {
+	case SA_DEVICE_TYPE_SATA:
 	case SA_DEVICE_TYPE_SAS:
 	case SA_DEVICE_TYPE_EXPANDER_SMP:
 	case SA_DEVICE_TYPE_SES:
-- 
2.31.1