Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 Oct 2021 09:15:53 +0200
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc:     Marc Kleine-Budde <mkl@pengutronix.de>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Rob Herring <robh@kernel.org>,
        Paul Burton <paulburton@kernel.org>,
        linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
        linux-mips@vger.kernel.org,
        Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH v1] MIPS: Malta: fix alignment of the devicetree buffer
Message-ID: <20211011071553.GA24717@pengutronix.de>
References: <20210902071951.28722-1-o.rempel@pengutronix.de>
 <20210902090324.GA6429@alpha.franken.de>
 <20210902101432.t3pmkb2od2j4kwth@pengutronix.de>
 <alpine.DEB.2.21.2110101148550.12214@angie.orcam.me.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.21.2110101148550.12214@angie.orcam.me.uk>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Sun, Oct 10, 2021 at 11:58:24AM +0200, Maciej W. Rozycki wrote:
> On Thu, 2 Sep 2021, Marc Kleine-Budde wrote:
> 
> > > > Starting with following patch MIPS Malta is not able to boot:
> > > > | commit 79edff12060fe7772af08607eff50c0e2486c5ba
> > > > | Author: Rob Herring <robh@kernel.org>
> > > > | scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9
> > 
> > If the above patch broke malts, IMHO the fixes tag should be:
> > 
> > Fixes: 79edff12060f ("scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9")
> 
>  It's not clear either from this patch description or from the commit 
> referred what the actual *purpose* of the alignment check is and therefore 
> I think it's hard to say which of the two commits needs to be indicated as 
> the offender.  Without further data I tend to agree it's 79edff12060f that 
> ought to be referred, being the immediate cause of the regression, as 
> things obviously worked before, for 5+ years.

This patch was already taken. Do I need to do any thing?

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |