Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1378799pxb; Mon, 11 Oct 2021 04:53:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxaeOKAhE5o0kNqmbhIPJNiyyuHQqkxQ8IFvrFDRmkEHroEwjoyWvGeS8+AiDV/NBxqDif X-Received: by 2002:a17:902:ba85:b0:13e:c846:c92e with SMTP id k5-20020a170902ba8500b0013ec846c92emr24027799pls.57.1633953228922; Mon, 11 Oct 2021 04:53:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633953228; cv=none; d=google.com; s=arc-20160816; b=cF+veMieZm9CY9ArAnnfXA7AkBfe97io8nWDwVnvexABfmQOhalN8G6ikKFtRrdR95 mlR92CgB214IekKzOtR9m78soz+cAGsi2m+04jh5hPFgTQi4KnfJf+6S8aDPjnuznFgS s10n7DN8S1zhI0t9l2w5WD06vAb2CAHHCaMYBIJRzES8FYDqJPfXXP5yDxCRXvYlCCXk QEUC0NqeHqMicfxUCKRqt+F74YmHmuwOp/77oxBvpbvVo4XCbJa0XkS6ECIMmvnOaU2n JuHOgbUvS9Cn3wpAfO6/R9u6QQ0DtbHg15OVOholOnykCB97BH5kgiIQ67K6I64b5wTF JycA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=gHNgfHow63T/drt8fJVqk4QWoa1U7LxcuqZcJgrfwsU=; b=CsCOT1cIMKQVvSXqhnZXwKHTpXC/zPw+i7siQ5DAUnrQK1yKjFCvhIvWaVZNniuP17 hVZqpkcKwMFS6Qum35TRMcvavSM4V0IREaymiruEKHV4RvCov/ZNTTZXNF1npsd63lcT MoZWhf7IDG5xuRRmXEr6X1282lsYfLLWSi/NR1aa+//3RIBAxyeizdcz9eql7oXhErRr OIEYzgAz6VUOfkeerBUuuRAJipSnix7oNGNXCSmvbB/qgrFQ7K2mPOdcq0TVM0ZOAA2K Ng2QHFkc7EVGtQ7NzLqRwCVreWMPQTs4aUne2X26vsxYrjt7yTp45qjO404n+kTM6Mc9 qqtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w13si11560190pjg.25.2021.10.11.04.53.37; Mon, 11 Oct 2021 04:53:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234497AbhJKHfv (ORCPT + 99 others); Mon, 11 Oct 2021 03:35:51 -0400 Received: from verein.lst.de ([213.95.11.211]:36155 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234401AbhJKHfu (ORCPT ); Mon, 11 Oct 2021 03:35:50 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id AF37268AFE; Mon, 11 Oct 2021 09:33:48 +0200 (CEST) Date: Mon, 11 Oct 2021 09:33:48 +0200 From: Christoph Hellwig To: Simon Ser Cc: Alex Deucher , Christoph Hellwig , Stephen Rothwell , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: build failure after merge of the amdgpu tree Message-ID: <20211011073348.GA10672@lst.de> References: <20211008113116.4bdd7b6c@canb.auug.org.au> <20211008192910.600a188d@canb.auug.org.au> <_POw9ikafXoqSFqiOb8SZb_uvRZ4okgD4qrl4EtJ0UBiQTV7pwV3pJIM20eIzmpuFWDeBF9NPD00r72ttX0mZZ0bNeH_J44MoaB-jfjrQSU=@emersion.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <_POw9ikafXoqSFqiOb8SZb_uvRZ4okgD4qrl4EtJ0UBiQTV7pwV3pJIM20eIzmpuFWDeBF9NPD00r72ttX0mZZ0bNeH_J44MoaB-jfjrQSU=@emersion.fr> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 08, 2021 at 06:07:33PM +0000, Simon Ser wrote: > Would it be reasonable to re-export get_mm_exe_file? amdgpu uses it here: > > https://gitlab.freedesktop.org/agd5f/linux/-/commit/0d4da915c7098eca2aa6f559f42e33b5e9c7c5e8 Seriously? No, it obviously not. Unexporting it is important to catch utter crap like in that commit which should have never made it into a maintainer tree.