Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 13/13] ASoC: amd: enable yc machine driver build
To:     Vijendar Mukunda <Vijendar.Mukunda@amd.com>, broonie@kernel.org,
        alsa-devel@alsa-project.org
Cc:     Alexander.Deucher@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, Mario.Limonciello@amd.com,
        Richard.Gong@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20211011055621.13240-1-Vijendar.Mukunda@amd.com>
 <20211011055621.13240-14-Vijendar.Mukunda@amd.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <7d58fea8-cd45-c25d-300f-1e7438079c94@infradead.org>
Date:   Mon, 11 Oct 2021 00:55:26 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211011055621.13240-14-Vijendar.Mukunda@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/10/21 10:56 PM, Vijendar Mukunda wrote:
> Enable YC platform dmic machine driver build.
> 
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> ---
>   sound/soc/amd/Kconfig     | 7 +++++++
>   sound/soc/amd/yc/Makefile | 2 ++
>   2 files changed, 9 insertions(+)
> 
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index 42825e8ad2ad..864d80f14421 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -67,3 +67,10 @@ config SND_SOC_AMD_ACP6x
>   	depends on X86 && PCI
>   	help
>   	 This option enables ACP v6.x DMIC support on AMD platform
> +

For the help text above here and the one below:

a. End the sentence with a period ('.').

b. Pay attention to the documented/accepted kernel style:

(from Documentation/process/coding-style.rst, section 10):

For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different.  Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.

> +config SND_SOC_AMD_YC_MACH
> +        tristate "AMD YC support for DMIC"
> +        select SND_SOC_DMIC
> +        depends on SND_SOC_AMD_ACP6x
> +        help
> +         This option enables machine driver for DMIC endpoint


thanks.
-- 
~Randy