Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 13/13] ASoC: amd: enable yc machine driver build
To:     Randy Dunlap <rdunlap@infradead.org>, broonie@kernel.org,
        alsa-devel@alsa-project.org
Cc:     Alexander.Deucher@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, Mario.Limonciello@amd.com,
        Richard.Gong@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20211011055621.13240-1-Vijendar.Mukunda@amd.com>
 <20211011055621.13240-14-Vijendar.Mukunda@amd.com>
 <7d58fea8-cd45-c25d-300f-1e7438079c94@infradead.org>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
Message-ID: <b104b4e6-dfed-59ea-f9ec-90c0f2c103c8@amd.com>
Date:   Mon, 11 Oct 2021 13:55:41 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <7d58fea8-cd45-c25d-300f-1e7438079c94@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3JGYVBUWjAzTVJ0WEgrRGcrUzFrbjBiN2RybHR6RjBBNUpFM3ZnaXZFSXhS?=
 =?utf-8?B?WE83eSt3S2E5azMzZDNtR0M1S0I3M0FDZUVtbHE2d0t5WktQZldseGNLbE80?=
 =?utf-8?B?TFM5SGgxMGdIQzdLTVpvcXVRRzNzdm5TdUlBMk1uYXVxWGVTOUNuYmlnczRl?=
 =?utf-8?B?S2MyRzMrZ29kR3J2bUZZK3V1SHp0aGRTRDh6YStsMVdWM2lJajNIUHdXR1dt?=
 =?utf-8?B?cWIyclNqL29BeVh5YnRhWjJLS25iK3VwbTFadkllN2ZzVEViTFpwQkl2Umlm?=
 =?utf-8?B?YXFlajNjZFVVQWE5NVNubUdwMW5lSlFHVFg4TEUyNmJBTHNlOWcwSHZuZFlH?=
 =?utf-8?B?TVpCL0lmR2lKQnJLbVpRcS8yanpGM0hDNVN0REVBVWcrUTdNc05FN1NEYTRF?=
 =?utf-8?B?RjRzclBzWEZGaEhMaHQ4Y3NGMEJ0bVNaN2QyaVZtZkhMT1kwUmxSeWJrbGZS?=
 =?utf-8?B?MU1Vb2prZ1dEZHp6eXMvK2xkZnhzOCtaeC83RWVPV3BZUzFWcVhxZU1hcnNL?=
 =?utf-8?B?Um9zK1c5S3VSL1MwRTVWLzN4dkFOZGdpUmY2dHZNYTI1R0RhcWZWa3JsMlZP?=
 =?utf-8?B?amxxSTdySkhrZGZOSG5LMnc0c3owWngxM0dEVndKb3pYZ0grUEo5d3FHSnBr?=
 =?utf-8?B?ZEhoTjFpVmhIQ3FOL2tDMWU5NG1uSy9ndDB6RzFJRUNHeTl0NkZ0WnN0VXox?=
 =?utf-8?B?TGlkaTdSYXV6MTZqMjIxWGNFVkJqZVZLM3o3S0dSc3RuMnRPcVM3a3dLWVEr?=
 =?utf-8?B?Vmxwdkt0RXNranduK2NvaVR6UmxEa1MxOS9wM2pIcEhPcXJOT3cyU2Y3NnRH?=
 =?utf-8?B?c2lBRzJONCs4S2VMUlAzSWtKWjlIYXlJUklJV3cxUlp2bjBzTnR4VmIxVGRU?=
 =?utf-8?B?aEZ3b1UxdzNhOEpXM3NjNEw4VTB5ek1FZll5TmwwZURzT3RReWE2SXNrZTdF?=
 =?utf-8?B?Y2Q4bXFEdkJiZWpQUEFPckx2YXlPYVFmSFBjanEwZzN6bjNHenlZWFlKLzVu?=
 =?utf-8?B?NEpQZTFWMUhOcEZVanFheXJrK20xY1VIckhsNkxLRFp5R0VmNExIa3pYalRt?=
 =?utf-8?B?V1MrV0k3SzFjdTNPNnNKVnFNTkU5akd5bkRBbHhQMmZvQ2dtRmE0RTllbldl?=
 =?utf-8?B?TENkWHR6WXIrYTZPZjVBYUxiSk02SjR4eHdGSmxPcVU1NmhNbUJBNVE4TjhK?=
 =?utf-8?B?SUNxQnc3VlpsUmlyaVcyMEpQWmNzUXI0elZJTllmZ05vcmlCU3lBZ3VqSUxU?=
 =?utf-8?B?MmRFVytIV1k4TWhjRUQzUUVBWmE4OFNjZGJ0UnZEaVpPVDNyUFQra0ptNVVY?=
 =?utf-8?B?U2hkaTlyMFZ5bW1sNTVlYjdZbFNRVEVyMjZlOVQzNEM5TFFaNEd6dVBOc1ZE?=
 =?utf-8?B?UEdYYStrKzByUVlxNWpwT2NDTWpIU3podWk5enBzMHUycUp3VG1Lc01yS1R0?=
 =?utf-8?B?Z1J2UVVWR2lUKzR0QW9Cc0loaFVKRlFQTVFyUjJPRXdZa0NTQzl0MHJzUVFO?=
 =?utf-8?B?V0hkRDFsZi9zdnY3SVVBc2UrTk1CTEhhZTNqSXhYM1U0cHpFZnpEODI5bDBH?=
 =?utf-8?B?R2RUM3VlaUNrTTdDOXdBN1cvZDRPbEprT2o4a1RRWFJIcU9UcU1MOEZGVFV1?=
 =?utf-8?B?bTR2WWwvNlNQN3BMUXBSZTV5anVMQTZrdklONG8rVytuMWx0SU1RWkx4OUVS?=
 =?utf-8?B?am9MSWk4SlB6dEsxYVFVKzZ5TUtOTnI0alVnekxMbWZ6NnU1aUZ6QXlsbHg5?=
 =?utf-8?Q?rqi4iotiavs+zkBtyWhT89WcIyhihn8uUkceZSg?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3529b95-b9c8-4cf2-5a96-08d98c8e18d9
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 08:06:58.1759
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dYfVbkPS+D3csdjVfC9htkcLERLFLxRGGB0JaRhWJfP/R3vWBZ3/Hb99jOxiVp2HWKZw834xgWTKZP/ncJ5mMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4465
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/11/21 1:25 PM, Randy Dunlap wrote:
> On 10/10/21 10:56 PM, Vijendar Mukunda wrote:
>> Enable YC platform dmic machine driver build.
>>
>> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
>> ---
>>   sound/soc/amd/Kconfig     | 7 +++++++
>>   sound/soc/amd/yc/Makefile | 2 ++
>>   2 files changed, 9 insertions(+)
>>
>> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
>> index 42825e8ad2ad..864d80f14421 100644
>> --- a/sound/soc/amd/Kconfig
>> +++ b/sound/soc/amd/Kconfig
>> @@ -67,3 +67,10 @@ config SND_SOC_AMD_ACP6x
>>       depends on X86 && PCI
>>       help
>>        This option enables ACP v6.x DMIC support on AMD platform
>> +
> 
> For the help text above here and the one below:
> 
> a. End the sentence with a period ('.').
> 
> b. Pay attention to the documented/accepted kernel style:
> 
> (from Documentation/process/coding-style.rst, section 10):
> 
> For all of the Kconfig* configuration files throughout the source tree,
> the indentation is somewhat different.  Lines under a ``config`` definition
> are indented with one tab, while help text is indented an additional two
> spaces.
> 
Will fix it and post the new version.

>> +config SND_SOC_AMD_YC_MACH
>> +        tristate "AMD YC support for DMIC"
>> +        select SND_SOC_DMIC
>> +        depends on SND_SOC_AMD_ACP6x
>> +        help
>> +         This option enables machine driver for DMIC endpoint
> 
> 
> thanks.