Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 06/13] ASoC: amd: add acp6x irq handler
To:     Joe Perches <joe@perches.com>, broonie@kernel.org,
        alsa-devel@alsa-project.org
Cc:     Alexander.Deucher@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, Mario.Limonciello@amd.com,
        Richard.Gong@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20211011055621.13240-1-Vijendar.Mukunda@amd.com>
 <20211011055621.13240-7-Vijendar.Mukunda@amd.com>
 <e71f1db7fecefa1f8eccd29d5a6cad3c126a1753.camel@perches.com>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
Message-ID: <0035a9a6-b018-8b4a-41b8-357c11c8a08c@amd.com>
Date:   Mon, 11 Oct 2021 14:58:32 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <e71f1db7fecefa1f8eccd29d5a6cad3c126a1753.camel@perches.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFp2TXRCaExLdFF4Q1dOSFAvT0RPbmsxK0ZhV2UwV2pBNWJ0c1VSVnQ3dTA2?=
 =?utf-8?B?clJpcjFVbHVPNzZCWVQ4am5JeXZJbmpjdUdWTEZNM3lsbzdsS3pMcVJnc2NH?=
 =?utf-8?B?K0YrOTlRcVNoRlJHSlVIemdMTmdJcnExS1NQanNaOVdRb296amwyWHc0VGN5?=
 =?utf-8?B?QzN2L2dpck9rcDdDYS94b0JwK0xlR1l3WDFYbndaVnhVVHJibjFhT250elhy?=
 =?utf-8?B?TlhvR2ZwdGVIN0JDQ2F0SEYrUGdhM2xoR042VWVYYkVjdWFMaklqL1cxVE5P?=
 =?utf-8?B?blRJZ2FqOEx0MjJMUXhnSzkrK2lzZ1VrNG5qdWNxbXR1SVdNc1ZqMnY5QUZR?=
 =?utf-8?B?dk9RMDl1Vy80OUthRTY1VSt0SnB1V1FUTkxiMHdLRE5GWW53WVZwR2hiWVRB?=
 =?utf-8?B?SDQxaHppd3lmSFZubnFnMGNIcVl6c3gwVFYrZjlsMHdjS1BJRGtEdFc2aWhL?=
 =?utf-8?B?WXJYUUdoSTVSUk56Umd4MVgyTndDellmMTl4MXFDaEZuZ1ZDY0hBRFZkMm1z?=
 =?utf-8?B?dkVaZ0cvS01VR1hZNUZFdW5mTC85UzJNQTR1dE0wMWRoYkhHR0paRTg0WXdK?=
 =?utf-8?B?dXM3bG56aUc3M3h5Nkh3bE1NZlg0UWFyU2wyakgrNzJGeXpheEVvcjRVVndX?=
 =?utf-8?B?QlE4Nmp6YVhGUnpDQUtxWWRuWGlsc00yQURIbUZ6R25YL1ByNjFaZWV1VGJO?=
 =?utf-8?B?MkpOb2lYZ20zMDJwZFBLLzZFeDRFNStidDg1NGl4QTJURkR3RW5oejRKSzd2?=
 =?utf-8?B?cEhFRUZnVzdGZWxiS0lCYXpmZ0FOQUc0b2VrWHJVSTRVMk05Sy9CSXlZZFlx?=
 =?utf-8?B?THJiQ1g3dmNFRC9GK0NUaUs4SEtrRzQ4NjJQZUk3WkJnYlJBVWNwdk5mdlVi?=
 =?utf-8?B?eXVEeFlJU2FzbnNsYkhkWXpIakhDczV1M0F5NFFvbzdldnJOR2NtK0lwY0Rh?=
 =?utf-8?B?dEVOWEUybGw4RW9jank0R1RSMVRibUd5endsclY4dFNqeGw0K2twNnFvT3d1?=
 =?utf-8?B?cGdZTC9DVThvOGJ2eEowNUszMEQrK3pVZWpIWXdPbmtNV0JnYVVoaHpsaEY1?=
 =?utf-8?B?SVExMjE0UjlvYVRlY3UraUViZXZ4c0FVTjdUZXFMT3l5bmt4VHNjVURONjA5?=
 =?utf-8?B?RWZvNU5INWxVRnNpcTNTZjZRb01ZZFhhR040OXBRVjVKd05DVU42QnpoUFhO?=
 =?utf-8?B?S0l0OEZ0SDhtWDZhbjdhbTV0R082T0RVaGFtZEYxaDRhbW5PWm9nQ0o2NWxt?=
 =?utf-8?B?OXhtdUFXTWZzUDZNdU9jd0NDcG14UjhIZTJ6WW80RmJCMmltMEdJSWlRS01M?=
 =?utf-8?B?VVVXTmRpbzlpME4vZGExYW1Dd0hUYUtxRXBkdW1rU3VVK1VHOGo0Y3NaUW1J?=
 =?utf-8?B?M05FY3RmVnc1aDRRUjM4TzlhS2tzbnVLV2lFRjYxaGxEelZWeEhkbTBTT2ZU?=
 =?utf-8?B?VnZzNU5aR1V1STFvV1ZLYWN2YXNOcTJvSWw5WHJkdUR0S3lEckJVMzE3UkZm?=
 =?utf-8?B?aldHdjliWFZlR09EbUdMTHkxVVdsTFhsSitGbXNFVnVaYlB3c0F0RHVmMXlE?=
 =?utf-8?B?dnB6MGQ3UUF1VHBkV2RaN2pVandtL2QzcFh4VS9vM1hWQ3ZiOXBobmdzc1Ay?=
 =?utf-8?B?UUVyQnpRWUczdXFWR1Y1Y2oyVVN1c0Uxc3A0RDlKSUhNOW5NSlJSZG80QXVP?=
 =?utf-8?B?eEh4eFdhMWpRU1ZrdjEzU3ZkdDF0NnhjME9CMlRBVjZUWkVwbFkxNjVzTVdI?=
 =?utf-8?Q?jR3rG3CKq1Dl0xYzKq2NQcAUh7+1ZusK9g1oWxz?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a399f6e-0d63-45db-fdd1-08d98c96e07c
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 09:09:49.0639
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +9TkTZlW2yGXN+L2EdmGa5JF2UdYTsVNwZLPr00IPgzLJhZXobxesMJBpauynODlFXM5mLnkd1mw9dmuDFsxAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3146
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/11/21 2:28 PM, Joe Perches wrote:
> On Mon, 2021-10-11 at 11:26 +0530, Vijendar Mukunda wrote:
>> Add ACP6x irq handler for handling irq events for ACP IP.
>> Add pdm irq events handling.
>> Whenever audio data equal to the PDM watermark level are consumed,
>> interrupt is generated. Acknowledge the interrupt.
> 
>> diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
> []
>> @@ -116,6 +118,33 @@ static int acp6x_deinit(void __iomem *acp_base)
>>  	return 0;
>>  }
>>
>> +static irqreturn_t acp6x_irq_handler(int irq, void *dev_id)
>> +{
>> +	struct acp6x_dev_data *adata;
>> +	struct pdm_dev_data *yc_pdm_data;
>> +	u16 irq_flag;
> 
> irq_flag seems unnecessary.
> 
>> +	u32 val;
>> +
>> +	adata = dev_id;
>> +	if (!adata)
>> +		return IRQ_NONE;
>> +
>> +	irq_flag = 0;
>> +	val = acp6x_readl(adata->acp6x_base + ACP_EXTERNAL_INTR_STAT);
>> +	if (val & BIT(PDM_DMA_STAT)) {
>> +		yc_pdm_data = dev_get_drvdata(&adata->pdev[0]->dev);
>> +		acp6x_writel(BIT(PDM_DMA_STAT), adata->acp6x_base + ACP_EXTERNAL_INTR_STAT);
>> +		if (yc_pdm_data->capture_stream)
>> +			snd_pcm_period_elapsed(yc_pdm_data->capture_stream);
>> +		irq_flag = 1;
> 
> Could be:
> 
> 		return IRQ_HANDLED;
  will fix it and post the new version.
> 
>> +	}
>> +
>> +	if (irq_flag)
>> +		return IRQ_HANDLED;
>> +	else
>> +		return IRQ_NONE;
> 
> and
> 	return IRQ_NONE;
> 
>> +}
> 
>