Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 Oct 2021 12:09:41 +0100
From:   Will Deacon <will@kernel.org>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc:     yajun.deng@linux.dev, catalin.marinas@arm.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next v2] arm64: PCI: Introduce pcibios_free_irq()
 helper function
Message-ID: <20211011110940.GC4068@willie-the-truck>
References: <20210921154731.GA2756@lpieralisi>
 <20210826060406.12571-1-yajun.deng@linux.dev>
 <b821ee0489f71a90a74c1d905c4fa530@linux.dev>
 <20210922162201.GA24429@lpieralisi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210922162201.GA24429@lpieralisi>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Wed, Sep 22, 2021 at 05:22:01PM +0100, Lorenzo Pieralisi wrote:
> On Wed, Sep 22, 2021 at 02:49:13AM +0000, yajun.deng@linux.dev wrote:
> > September 21, 2021 11:47 PM, "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com> wrote:
> > 
> > > On Thu, Aug 26, 2021 at 02:04:06PM +0800, Yajun Deng wrote:
> > > 
> > >> pcibios_alloc_irq() will be called in pci_device_probe(), but there
> > >> hasn't pcibios_free_irq() in arm64 architecture correspond it.
> > >> pcibios_free_irq() is an empty weak function in drivers/pci/pci-driver.c.
> > > 
> > > "pcibios_alloc_irq() is a weak function called to allocate IRQs for
> > > a device in pci_device_probe(); arm64 implements it with
> > > ACPI specific code to enable IRQs for a device.
> > > 
> > > When a device is removed (pci_device_remove()) the pcibios_free_irq()
> > > counterpart is called.
> > > 
> > > Current arm64 code does not implement a pcibios_free_irq() function,
> > > and therefore, the weak empty stub is executed, which means that the
> > > IRQ for a device are not properly disabled when a device is removed.
> > > 
> > > Add an arm64 pcibios_free_irq() to undo the actions carried out in
> > > pcibios_alloc_irq()."
> > > 
> > > This is a stub commit log. Then you need to describe the bug you
> > > are fixing (if any, or it is just code inspection ?)
> > > 
> > It is just code inspection.
> 
> Before merging it it must be tested, which would prove it is needed.

Ok, I'll ignore this patch for now then. Please yell if you want me to pick
it up.

Will