Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 Oct 2021 13:41:41 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Saurav Girepunje <saurav.girepunje@gmail.com>
Cc:     Fabio Aiuto <fabioaiuto83@gmail.com>, saurav.girepunje@hotmail.com,
        gregkh@linuxfoundation.org, marcocesati@gmail.com,
        lee.jones@linaro.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: hal: remove if condition which is
 always false
Message-ID: <20211011104141.GP2083@kadam>
References: <YWKXKGuA/Io9sEjf@user>
 <YWLFf1zPvK9gz+7+@agape.jhs>
 <9dca9f7e-f987-5be5-9523-7dd08c2b364e@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9dca9f7e-f987-5be5-9523-7dd08c2b364e@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?p68/fJBj6u75CgtfmgRR9/x/sXN3DMIrgrklEH/Jfu2ycD9juzc7PdPOaMD5?=
 =?us-ascii?Q?T/D1E6iatL+TtUVmhzDRxdZpm7rjZj90/bKAMnznsvX1uLUm3ByliPJjjDBd?=
 =?us-ascii?Q?xImepWzQMeqkznRQEB/dvB/zrauFFAePwiA62iqqi9mcDZWmHhBjkxa2+UHM?=
 =?us-ascii?Q?vH2s85f+Z9zQCsoFi4XV0SdlBPhEZRmbXdziKCpBPaYZB5Dd12OQ7fYWaouP?=
 =?us-ascii?Q?Se8qFOJfLx6ouiX7IB/N0BYJR4rprWFLckN7JllzdCTg4DgLlo+PHtpePD6k?=
 =?us-ascii?Q?gxQqu5eOoDf4UurGrCmei9BwzdGG1pNMXrLE3mJ72Q4AfQrWgAb7mFFzhnEd?=
 =?us-ascii?Q?K5hVac+6sXkMF6Y6+k5knMfDTKPrDOBEbkbd0KB94Dhvgmm4b22VpN6CD/Vp?=
 =?us-ascii?Q?rQy1KWZHD3XIoYzXqYG+FwnMUAD0puqBif8xvnM2HHY15YQLgrnZs5xl8Q1Z?=
 =?us-ascii?Q?Q2u+2wiBtE4wENyNIcngGbLs2IPCBdLzRR7GNgeNzsSfe6PSMcOmaQlhTme4?=
 =?us-ascii?Q?3QxheApZbZjdCI0ec1Awru0mPwheNS43CYPJQqsEx4E6XQ8gr/2i8EbMdj0K?=
 =?us-ascii?Q?A+q4h8db0g3mWt8iZ6KRtj+ApE1ldTutElowa7nTplc0LuZ27GoO+IiShLAj?=
 =?us-ascii?Q?5WzRUJLOjIIQ5DPO5dVyMk3g6PZ3nTJxtvcCLCvZSO5wkK+kArCJfNZV6ikt?=
 =?us-ascii?Q?xFWRLbPB4c41nJfJ4KwwRz0sGazWX0zZw+AMsNU7gBGPFSeb5pF56Puz+03R?=
 =?us-ascii?Q?1xHzGe+Un0sFV5vJkbWvhIRCSp1NnvQRT1lqtYogPVlULN+f7MGiImT6qfzT?=
 =?us-ascii?Q?IIViPOOu3YRSMGIyHlAKybryLsQGaxBk5c1v1Mf/SP4zJ/ht2nH5+bvet7NB?=
 =?us-ascii?Q?gmZXZ+Yy1+vevpzBOqzPeCzYXfOyhEXy1/ZZbta/I8iLeQ+DIiEU6x/aWZ4U?=
 =?us-ascii?Q?jWhNpCr3KIXDenQqJfiX24YvhEsw9vrKvLO2BhPZLAtiSmwOvp8q1GTRvWpH?=
 =?us-ascii?Q?21kpcmyCtdMfdyEjqxco2bgIAtXZ8THZp5U+T+tzSgyv1ixz8Ucya8bMIMgM?=
 =?us-ascii?Q?wQvs/EPdI+iD0c6HhLkcOeN8a5xEQhiKmp3ZsuYe31101A73X9K5lE5vxmTb?=
 =?us-ascii?Q?61t4UEZ+AJIvMQ18As/tN2/AfuFvnBj3IYH8Cm/TQuJCN+hVOxoJadWOo+67?=
 =?us-ascii?Q?QzIq+8hrvSMUdauZZMqDsktiYdd/uVtUgjvtq4F39+jDtHbTaTeNvs8FHSuT?=
 =?us-ascii?Q?nvTKM9dFwdgQbUtivvNYTFcYy4Xwsk5Ogvb1Ig0Amgd006Ht7E03lNZLTIxs?=
 =?us-ascii?Q?jexDttJ173/0+P8Mz5GRX2fZ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d71516a9-7725-4e2f-d2d8-08d98ca3c189
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 10:42:00.5957
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qkLUnckGX0jiZoBxNztEQYnpI6zM+ztb3OGYX7pqVaKlVgF0w5y0nwnVyUWRcPZ/UtEqVv0iqwtxMsBo7EDS2M0dxzpPeh/PYD22MFMAtz0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2127
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10133 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 adultscore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=901
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110110060
X-Proofpoint-GUID: YATX1ribNQrqECJIfHPwEpHI4pLJJqZ3
X-Proofpoint-ORIG-GUID: YATX1ribNQrqECJIfHPwEpHI4pLJJqZ3
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Yep.  And please go through the function and clean up all the references
to max_rf_path.  Change the "max_rf_path = 0" to 1 and delete the other
assignment.  Delete the comments about "max_rf_path == 2".

regards,
dan carpenter