Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 02/13] ASoC: amd: add Yellow Carp ACP PCI driver
To:     "Gong, Richard" <richard.gong@amd.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc:     "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Hiregoudar, Basavaraj" <Basavaraj.Hiregoudar@amd.com>,
        "Dommati, Sunil-kumar" <Sunil-kumar.Dommati@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20211011055621.13240-1-Vijendar.Mukunda@amd.com>
 <20211011055621.13240-3-Vijendar.Mukunda@amd.com>
 <e61fa81d-bf63-8b41-03d8-12bd3e61af59@amd.com>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
Message-ID: <95e0a6c8-c4fa-6471-d19b-27fd8e5599f7@amd.com>
Date:   Mon, 11 Oct 2021 17:13:50 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <e61fa81d-bf63-8b41-03d8-12bd3e61af59@amd.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1E5OGo4WXZuSURVZTl5YWkxUm9UOGNsSjBWK3gvWitHTTg1NSs0OVVSVG53?=
 =?utf-8?B?dXhWRVQ0bzQxNzlveWh3cTNBZmsvTVFrakQ4azFjTXpla0hKRkxhK1JEK1VT?=
 =?utf-8?B?NlkxNTAzdUJmSVEwZm1vZDI2U2tyME9zZVlERXUwbUs0eUxXMUlSd1N2QXZ3?=
 =?utf-8?B?MTl1QllzRFp6cFVrQlpWMVJMbnNuVEorWlB3UDJ4a3RLL2FUbitsOU9CMUVi?=
 =?utf-8?B?V3lCa3NobCthZlArYTVCYWNKZWNsajByRDJ1U0FXYmhWeHhkenVJQzl5Tnp6?=
 =?utf-8?B?dG9za25kSWNuZlBndXhrT0lPbG1NRHJSNDBVYnFhTGxHMGFhcFJYRzlHR2t6?=
 =?utf-8?B?ZkJZZW1CdnoyeC91SlI0UlJZTlAzeHFLaTUyS2FHeXcyYWE3eE1XbDJoUDB5?=
 =?utf-8?B?cmlKZC8vcHhqSzcvMlBORjQ0aHB4LytQL3VoNXp6eEFpUE9rTDR0Zk9UVysv?=
 =?utf-8?B?UmRScWM5ejBlc2tCVVlXY0htbkdkT2dZTS9NeEs1SGxDNVRjYTV6cEtCd0V3?=
 =?utf-8?B?YzBhYzdRZFNBYWkwVGdmN1ppemlDQk1jTFFZckJKVFB5amN6UXR0U216MG14?=
 =?utf-8?B?TkUycjBUZTUrVUQwT0wrd29LeUVQWHZqeXJRamJrUUhQa08yZGJoR1ZwcTlM?=
 =?utf-8?B?b3d1aEdRdXdxRG40SzBtUnpNTDdrdWEzaHVvbEdHOTlxUUh2Nm1Db1BNM3Y0?=
 =?utf-8?B?NjZZVnBqWUZVSmdiYkFnTThOVXhnYXZ1VWg0M1IvNnBlMERHOCtpSytGUXJh?=
 =?utf-8?B?WXBwaUp2bkczanUvYjNFK0VaU3dDZjBUY3JVci9RNVJVNUxnaWd0R05qbXdr?=
 =?utf-8?B?ZTlnU2V1c21GRDdYS2hscEkwcHh2MDl5cDFvam8vd0ZRcEYxaCtzNGNsUXZY?=
 =?utf-8?B?QXVGMXlGOTZmK1YzV2p0NVZ1Q05mUW02K2tJZFZhRWt6N042SWdtTkF5OEpo?=
 =?utf-8?B?cENPUzJNVU9RYWRuZWhld2t2S3FFSVIwMXR6WExadFNzRk5nTUU3RnVsL0xT?=
 =?utf-8?B?cVpPZk9LZy91blQxOHFMOGZjMUlOZnhEZEN2RGJLdFlHZk9VQ3Zmb0JUMWIz?=
 =?utf-8?B?dWhzbEZUUDJ4Y0lEbGRtV1VHVkMrQTR4Q2FLUThLbVNyeEhranZTdTBZYS9H?=
 =?utf-8?B?UFVueEszZjlIbzdLSTk1QzBOY1g2V09LMmpPNjdsaGsrRG1TTEtkQXdoMFNi?=
 =?utf-8?B?ZlZORWd0T0NCZnJ3TjZBdWF2RTFkcENreldHeHhsRVgvdFhUVk9GMHR2MGl5?=
 =?utf-8?B?d2RwNTNFWHhGb3pBRXJwejBpRndyNUhGdks0UjJZMjc4bWI5N1VXVGNqY2VV?=
 =?utf-8?B?NmVQT2UxNkpKRHgrTGdxNE5vbkdxRXJKcm5nYm9tb3J5UE5mZUFGczFaLzdE?=
 =?utf-8?B?cENRRFhoRHAvLzVBbWJkZXNUdFduU2VMTHpWQXR5QmFYVDA4U3RtMk5QeHVE?=
 =?utf-8?B?QURRc0IzTkFIUnhXc2RwdFRnSnQ2VHJkbnhJWnhJUTIzc2pXOTZWNHQvM05v?=
 =?utf-8?B?TkRwc3BkcXh5Q0tOaU5SWlRNV0RoTVRZYVJ3VjRvSDJla3doOXFKVllMZjZ3?=
 =?utf-8?B?UGNab1RUcWpodGtQalRhcXM2MTgwQStXNEZZSXo1bWZEbS9KZEQzVU5hdkps?=
 =?utf-8?B?VTRraXRoN2E4WHlVVm9MQnY1ZjVNejh5c09MaTZoVDZ4Wjl0R0lUNmg2UE4w?=
 =?utf-8?B?VFRLTFBUcWIwcEVvTGV4TWlUSXhZSW5RaVk4akx3enRMYlhTd3pYMVE3SnVS?=
 =?utf-8?Q?jeHRr2j7UvcHpOus49Hln64Ou841hQxtR8Gu0Ta?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1919a799-0838-41cc-f6d2-08d98ca9c659
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 11:25:05.5688
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JR8oXakqCYnZtPJrKOyQsYMu6C3YpchB5Omy9Gnw1zQfygv0moM3oHn1NhhwsD41uma1L65EooYQja5RfU+gng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1849
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/11/21 4:31 PM, Gong, Richard wrote:
> 
> On 10/11/2021 12:56 AM, Vijendar Mukunda wrote:
>> ACP is a PCI audio device.
>> This patch adds PCI driver to bind to this device and get
>> PCI resources.
>>
>> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
>> ---
>>   sound/soc/amd/yc/acp6x.h     | 21 +++++++++
>>   sound/soc/amd/yc/pci-acp6x.c | 89 ++++++++++++++++++++++++++++++++++++
>>   2 files changed, 110 insertions(+)
>>   create mode 100644 sound/soc/amd/yc/acp6x.h
>>   create mode 100644 sound/soc/amd/yc/pci-acp6x.c
>>
>> diff --git a/sound/soc/amd/yc/acp6x.h b/sound/soc/amd/yc/acp6x.h
>> new file mode 100644
>> index 000000000000..62a05db5e34c
>> --- /dev/null
>> +++ b/sound/soc/amd/yc/acp6x.h
>> @@ -0,0 +1,21 @@
>> +/* SPDX-License-Identifier: GPL-2.0+ */
> Use // here

Will fix it and post the new version.

>> +/*
>> + * AMD ALSA SoC PDM Driver
>> + *
>> + * Copyright (C) 2021 Advanced Micro Devices, Inc. All rights reserved.
>> + */
>> +
>> +#include "acp6x_chip_offset_byte.h"
>> +
>> +#define ACP_DEVICE_ID 0x15E2
>> +#define ACP6x_PHY_BASE_ADDRESS 0x1240000
>> +
>> +static inline u32 acp6x_readl(void __iomem *base_addr)
>> +{
>> +    return readl(base_addr - ACP6x_PHY_BASE_ADDRESS);
>> +}
>> +
>> +static inline void acp6x_writel(u32 val, void __iomem *base_addr)
>> +{
>> +    writel(val, base_addr - ACP6x_PHY_BASE_ADDRESS);
>> +}
>> diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
>> new file mode 100644
>> index 000000000000..2965e8b00314
>> --- /dev/null
>> +++ b/sound/soc/amd/yc/pci-acp6x.c
>> @@ -0,0 +1,89 @@
>> +// SPDX-License-Identifier: GPL-2.0+
> It's correct to use // here.
>> +//
>> +// AMD Renoir ACP PCI Driver
>> +//
>> +//Copyright 2021 Advanced Micro Devices, Inc.
>> +
> Use /*  */ rather than //

Will fix it and post the new version.

-Vijendar
>> +#include <linux/pci.h>
>> +#include <linux/module.h>
>> +#include <linux/io.h>
>> +
>> +#include "acp6x.h"
>> +
>> +struct acp6x_dev_data {
>> +    void __iomem *acp6x_base;
>> +};
>> +
>> +static int snd_acp6x_probe(struct pci_dev *pci,
>> +               const struct pci_device_id *pci_id)
>> +{
>> +    struct acp6x_dev_data *adata;
>> +    int ret;
>> +    u32 addr;
>> +
>> +    /* Yellow Carp device check */
>> +    if (pci->revision != 0x60)
>> +        return -ENODEV;
>> +
>> +    if (pci_enable_device(pci)) {
>> +        dev_err(&pci->dev, "pci_enable_device failed\n");
>> +        return -ENODEV;
>> +    }
>> +
>> +    ret = pci_request_regions(pci, "AMD ACP3x audio");
>> +    if (ret < 0) {
>> +        dev_err(&pci->dev, "pci_request_regions failed\n");
>> +        goto disable_pci;
>> +    }
>> +
>> +    adata = devm_kzalloc(&pci->dev, sizeof(struct acp6x_dev_data),
>> +                 GFP_KERNEL);
>> +    if (!adata) {
>> +        ret = -ENOMEM;
>> +        goto release_regions;
>> +    }
>> +
>> +    addr = pci_resource_start(pci, 0);
>> +    adata->acp6x_base = devm_ioremap(&pci->dev, addr,
>> +                     pci_resource_len(pci, 0));
>> +    if (!adata->acp6x_base) {
>> +        ret = -ENOMEM;
>> +        goto release_regions;
>> +    }
>> +    pci_set_master(pci);
>> +    pci_set_drvdata(pci, adata);
>> +    return 0;
>> +release_regions:
>> +    pci_release_regions(pci);
>> +disable_pci:
>> +    pci_disable_device(pci);
>> +
>> +    return ret;
>> +}
>> +
>> +static void snd_acp6x_remove(struct pci_dev *pci)
>> +{
>> +    pci_release_regions(pci);
>> +    pci_disable_device(pci);
>> +}
>> +
>> +static const struct pci_device_id snd_acp6x_ids[] = {
>> +    { PCI_DEVICE(PCI_VENDOR_ID_AMD, ACP_DEVICE_ID),
>> +    .class = PCI_CLASS_MULTIMEDIA_OTHER << 8,
>> +    .class_mask = 0xffffff },
>> +    { 0, },
>> +};
>> +MODULE_DEVICE_TABLE(pci, snd_acp6x_ids);
>> +
>> +static struct pci_driver yc_acp6x_driver  = {
>> +    .name = KBUILD_MODNAME,
>> +    .id_table = snd_acp6x_ids,
>> +    .probe = snd_acp6x_probe,
>> +    .remove = snd_acp6x_remove,
>> +};
>> +
>> +module_pci_driver(yc_acp6x_driver);
>> +
>> +MODULE_AUTHOR("Vijendar.Mukunda@amd.com");
>> +MODULE_DESCRIPTION("AMD ACP Yellow Carp PCI driver");
>> +MODULE_LICENSE("GPL v2");