Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1608776pxb; Mon, 11 Oct 2021 09:24:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBwqLv3ld7NM5GXeGRjqHPKjFAHVRrtwofJb0mKKfQw87Iy3tkSWkplaDfHMUytNWfIMpC X-Received: by 2002:a17:903:31c2:b0:13c:9de8:d314 with SMTP id v2-20020a17090331c200b0013c9de8d314mr25474030ple.1.1633969458324; Mon, 11 Oct 2021 09:24:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633969458; cv=none; d=google.com; s=arc-20160816; b=TLPp7Zbv+nvUY+RJlRhxbeYXNZ9GGKuQuJ19jubfBNrpRT+7ehLOQh5iuCb8WoFzvL gvk7+bL/AwHLmKakABkniCEpunLHAY4oAh7VatnPyEOM/ly65rnjGQj5bCaDc7Oe1/cw 8myuba6L7W+xZ3uTFkKZ+91CkxAz0ZnGX5fSZ0zw94t3jQWwlzvQ+TQAG8sC3RajpHrf e85DLGneFIbf6xsEfCAu/cxmfo6gzDrwjKXHz8rtqISfej8s5FQvJeZQRX7Q/juNb1x7 rxbZycz/ukdLK5R83cGR1Liuh6OAIYGqNIYLhB3BzVfk5QmhS3zUXmtgm60YL/2eqcek ZXEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=SrpD2c97KaYgGK3Axg9BIypRPhTpPzU98oWYia36mpE=; b=OuIgar4rW0p1v2WYeeSKBappxBlkAkhG2E6NwwNhhT9Ilm+WRBJuKV2ZQatdzlFQwJ hLagNVUHSmNPdXZXaOVmdpBz3dgfw6tudVYQALn0Rmt2rkCRO5eTpAqyzYInADT/XbgU Ck9+Vv3njv7QfunMFsA2duZpZ78hjlvxZTOJ+i85URqpxBZYoYz4psL9ufscE+F7xWFJ 28Or1od7fJ1eQCYO2Y9X5UckPt2Yhlxzgkny1YsqsJT4qvOm+RR0QQ/vZ9qwlAf2dOPd O1vasyf1QLoHgIc0Dcm+3W+74XEx1OikV1ktYAgdTIggs12hbkyNtMV9Mvd1MLaXb9g/ wzAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i14si11622135pgk.326.2021.10.11.09.24.05; Mon, 11 Oct 2021 09:24:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236454AbhJKMKB (ORCPT + 99 others); Mon, 11 Oct 2021 08:10:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236439AbhJKMJ4 (ORCPT ); Mon, 11 Oct 2021 08:09:56 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee2:21ea]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0CB0C06161C; Mon, 11 Oct 2021 05:07:56 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4HScxh5lgHz4xbX; Mon, 11 Oct 2021 23:07:52 +1100 (AEDT) From: Michael Ellerman To: Christophe Leroy , Benjamin Herrenschmidt , Andrew Morton Cc: linuxppc-dev@lists.ozlabs.org, Stan Johnson , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Finn Thain , dri-devel@lists.freedesktop.org In-Reply-To: <884a54f1e5cb774c1d9b4db780209bee5d4f6718.1631712563.git.christophe.leroy@csgroup.eu> References: <884a54f1e5cb774c1d9b4db780209bee5d4f6718.1631712563.git.christophe.leroy@csgroup.eu> Subject: Re: [PATCH] video: fbdev: use memset_io() instead of memset() Message-Id: <163395400552.4094789.12015421663855128336.b4-ty@ellerman.id.au> Date: Mon, 11 Oct 2021 23:06:45 +1100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Sep 2021 15:34:35 +0200, Christophe Leroy wrote: > While investigating a lockup at startup on Powerbook 3400C, it was > identified that the fbdev driver generates alignment exception at > startup: > > --- interrupt: 600 at memset+0x60/0xc0 > NIP: c0021414 LR: c03fc49c CTR: 00007fff > REGS: ca021c10 TRAP: 0600 Tainted: G W (5.14.2-pmac-00727-g12a41fa69492) > MSR: 00009032 CR: 44008442 XER: 20000100 > DAR: cab80020 DSISR: 00017c07 > GPR00: 00000007 ca021cd0 c14412e0 cab80000 00000000 00100000 cab8001c 00000004 > GPR08: 00100000 00007fff 00000000 00000000 84008442 00000000 c0006fb4 00000000 > GPR16: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00100000 > GPR24: 00000000 81800000 00000320 c15fa400 c14d1878 00000000 c14d1800 c094e19c > NIP [c0021414] memset+0x60/0xc0 > LR [c03fc49c] chipsfb_pci_init+0x160/0x580 > --- interrupt: 600 > [ca021cd0] [c03fc46c] chipsfb_pci_init+0x130/0x580 (unreliable) > [ca021d20] [c03a3a70] pci_device_probe+0xf8/0x1b8 > [ca021d50] [c043d584] really_probe.part.0+0xac/0x388 > [ca021d70] [c043d914] __driver_probe_device+0xb4/0x170 > [ca021d90] [c043da18] driver_probe_device+0x48/0x144 > [ca021dc0] [c043e318] __driver_attach+0x11c/0x1c4 > [ca021de0] [c043ad30] bus_for_each_dev+0x88/0xf0 > [ca021e10] [c043c724] bus_add_driver+0x190/0x22c > [ca021e40] [c043ee94] driver_register+0x9c/0x170 > [ca021e60] [c0006c28] do_one_initcall+0x54/0x1ec > [ca021ed0] [c08246e4] kernel_init_freeable+0x1c0/0x270 > [ca021f10] [c0006fdc] kernel_init+0x28/0x11c > [ca021f30] [c0017148] ret_from_kernel_thread+0x14/0x1c > Instruction dump: > 7d4601a4 39490777 7d4701a4 39490888 7d4801a4 39490999 7d4901a4 39290aaa > 7d2a01a4 4c00012c 4bfffe88 0fe00000 <4bfffe80> 9421fff0 38210010 48001970 > > [...] Applied to powerpc/next. [1/1] video: fbdev: use memset_io() instead of memset() https://git.kernel.org/powerpc/c/f2719b26ae27282c145202ffd656d5ff1fe737cc cheers