Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 Oct 2021 15:09:31 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Saurav Girepunje <saurav.girepunje@gmail.com>
Cc:     gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
        ross.schm.dev@gmail.com, deborahbrouwer3563@gmail.com,
        hdegoede@redhat.com, marcocesati@gmail.com, phil@philpotter.co.uk,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: rtl8723bs: core: simplify the if condition
Message-ID: <20211011120930.GI2048@kadam>
References: <YWEwFf0YMi4W1xKN@user>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YWEwFf0YMi4W1xKN@user>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Kg4y2b+Lyaq3YDxlZln66o4UtEC+AHw/zTvTlhrZoqkdDqRRdy/cEDSUt9Dc?=
 =?us-ascii?Q?N5+pv72fKqwJ0znb5QS7EPWlghUk+sgBGK0ssQqhX24/GKFfH9rFXqsqGHSg?=
 =?us-ascii?Q?lJJEDzkJlxKIESWC/HC8gr8sYu0sIsLF/Jkh/NT/06ZkNrwBliU2kO87IoSL?=
 =?us-ascii?Q?k14LsnUI3RXdczQZOc6pRtC8kRk11RNJjiieD7z9H2Aty7p6AYQdJTp7Rwt0?=
 =?us-ascii?Q?42CNFqXYDNusPrFLKBjg+fD4rzzfPC8NJN1M63zl0qE5JuJX22ozzPrEr83q?=
 =?us-ascii?Q?cNUTfhPU4oebxdbHnlCgDYBjUH6vQzFzBrjd0g6+qKosnH6i4FtOc28tR3Et?=
 =?us-ascii?Q?+D5kGSbPgqaCYSLOMl+/iTeHFYCjfEVJjff+ZHHJbPpUCxGuaShex8fxCGm+?=
 =?us-ascii?Q?IclgX1vesYXAUADlykMxIKRQkUOGbXl+zIoJRFTvVs2LBd4AmAhWS2rPPdqQ?=
 =?us-ascii?Q?aMKwaYLEeEXWMvhuZ8mHQn83tCOEdLN5aLYWXgonNGIxNOlh1d177YBse/Cn?=
 =?us-ascii?Q?Z+Yo8k9mXFJtUe4XprRZ14X80FE55QDRXvA/XYuBoxdAJkXjUAYpm9EuQJqH?=
 =?us-ascii?Q?7P03sQ7o+ERdjgQd8trrqav8UdhaWLK/33IIYlMmoACcpwMGxtM7dNzEutrw?=
 =?us-ascii?Q?Osa6UwbdKG3u1YZpped2CMScPbhk3DRk6qDUljW3WNWlAMVYwUcCHho+9HJp?=
 =?us-ascii?Q?5qHVmo6FQjAzmDSCUjQd+fpk0PVAOW2y23rxRs2Ej6ZfLiOJ56V1CZna9fNy?=
 =?us-ascii?Q?DnPjvf5L0MqSEbwJoVjyXFJL13TDKILKruA+BeeAI2foCTNHebYeEteYE9vf?=
 =?us-ascii?Q?nyvZkLJnvWm8G6iC0mVliBmgi5I2rxsCNxltlJ5c1oZx8ZAjKDp9zjJQe/iX?=
 =?us-ascii?Q?iqzMQFbUgesM35/0BzkTMY3Ta9qcZ5jQ3C+EwWBtkFwFQD62EOrBXdPxVnF8?=
 =?us-ascii?Q?XLb34rUu/vh07kFFp1+I7SX2IOPtyQ6UbH/A2HHfEfjXGWq3pLYBx8SIZTft?=
 =?us-ascii?Q?jvg7eH307etwXKtzUL6osxniZ3ZJVGmeiIyD9Bu6u2GDPcIJ409w41k/k50k?=
 =?us-ascii?Q?8BF5+Twey5IVjthdmfUCe/BPMMLmQqEARGdQ7BNzwXadIxKRXiD7uq6KOAIR?=
 =?us-ascii?Q?kQ1N90QOJqhFSWzZ+3xD1CRFmrb11UQwc469dDasZGXvFdOI71tj3610muwe?=
 =?us-ascii?Q?B0MHeAWi7LU2V0Fch9B21o6ea6ik8hBkJozFBY7uuPERVv8x5BQ5RW0YtYef?=
 =?us-ascii?Q?FfNkRl6NOXCjXMHhfB0G2hPLwjokTz6aDb0kJWnt84+m0GF4vDsM06VmqmX6?=
 =?us-ascii?Q?SdH2GTlNFw1XgYaqjM3b5Gy7?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5437c761-da94-4aca-165f-08d98cb005f4
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 12:09:49.5159
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zAD+kx/sTr6Tvf0Y71O07M0u5HYZzIKm2AgCGX16xH2cqI8Fsefd+0pHUtXbkOJQdr86+o0JYePs5mo2ogjoK6hsqvF304ZDDO1zkFoTAFo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2157
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10133 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=881
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110110070
X-Proofpoint-GUID: DabQV6NOArK-mZL4Y4r9TjIY9kan0rwO
X-Proofpoint-ORIG-GUID: DabQV6NOArK-mZL4Y4r9TjIY9kan0rwO
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

You didn't compile test the patch.

On Sat, Oct 09, 2021 at 11:30:53AM +0530, Saurav Girepunje wrote:
> if psta is NULL, function is returning with fail. On next if condition
> again checking if psta is not a NULL. Remove multiple if condition check.
> 

I don't think this is an accurate description of what the patch does.

> Function is already using goto exit statement to exit.Replace multiple
> return with goto exit statement.

No.  Do nothing labels only hurt readability and introduce "forgot to
set the error code bugs."

regards,
dan carpenter