Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1609746pxb; Mon, 11 Oct 2021 09:25:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNnIvIldo31K4+P8s3THFkPsNe0S1Jkrw5v3pvVoTqFXnum4wjeCQ9a+ml3z9z237Vq1zt X-Received: by 2002:a17:902:7d89:b0:13c:a5e1:f0f1 with SMTP id a9-20020a1709027d8900b0013ca5e1f0f1mr25483635plm.24.1633969525667; Mon, 11 Oct 2021 09:25:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633969525; cv=none; d=google.com; s=arc-20160816; b=YalT42EJ4U96du6VKLzGRBRm0BuzrhDA6gwpyzGjUYWS2hFHmARrIpMNtQm6JEdXtp X37Ic4lppVCH0bjKe5slc51h+jLmzDNK+laYd97uX38ukAy36d0fXjb6Q59DtA1f8iza t5cTGVGOEy56GFUtnfOSk5k+Gr9wwkVgwHvlZrvTxhc8dItf4T1M6rDtDLgnXAMwPuUn 3d5ZfdXXYB7jayBGKPEiVVg0XuCAeJxZ21G2sWeDuEHpQGRbS57/QoSrrAl8jyFWsR4L gR48EnGng7s2tfWDLGnko2ofq52d/RBEsdkyKCWMJ2XS717Qj0cBxS+AFLnkcdhIYWFH 7f1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GIyRuvfib8GRNJz7ecQG89JjO013H49WTTUqm4s95lE=; b=tCRQ4QbmqsKoYUoHtbi8jNULRG5jBXVCDdsilFI8epj8bkJ40LvHwtYn5uU5mSGzs7 ltFeksZyRIsEcjkVts8jO9B1nJz3QvuQA37pzDjuXVpLnehwj6BbFsiUolUPTQMldPf3 oPPw8ghvfPcetx7RO854DV+/C4DdaAVsjtw3r197RhcR1YqXr7Q/ZaZuMy+fVgbgXhvL JJVzy1020gcaRQXtmgtN+FW987YxQbp48e3i5UA5PyP6TG2M+xbXX2FR4GnAvXY+O4Ck SgQjRDzF+S0v3hF1RnXqCWP2FYq4AjBgLvOwSYeEV8+cVnpf9WwLTBn1RsPhcVzOlraU QWUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J9lQ3EUO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g131si10018539pfb.68.2021.10.11.09.25.11; Mon, 11 Oct 2021 09:25:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J9lQ3EUO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236507AbhJKMRi (ORCPT + 99 others); Mon, 11 Oct 2021 08:17:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:48006 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235092AbhJKMRh (ORCPT ); Mon, 11 Oct 2021 08:17:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 99E2A60EBB; Mon, 11 Oct 2021 12:15:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633954537; bh=GIyRuvfib8GRNJz7ecQG89JjO013H49WTTUqm4s95lE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J9lQ3EUOdqaP704DLMq5cH1RZLeT15um3TdK0/HL96AWF7HZmLHJSiKJbHQM7wjRW 0NuTbLzdE9pSM8dlEO78qxrluR1D1j8jNibWcf9GHjWGmPUuUPHeIH/rZP+BbcIySe f6to+Cj8eeL4L+o9i5fuf2nS4UA4Okju5xFrr//kUbgmcLxDTf4T7xsmxW0GtoVsIF RFvPiOd3VtpMUNg04qt6c0Gz97sGnxSe6Ak5Su3XtZ4plBgs9omxl3mbnRt1F4Q2DD 9oCdR7PcGGLZa9GnC9wuculRyruZGj1DFWETzwjeatO9n29trO5Nj4JFk2NVygk9YD PJjC1K+mYymrA== Date: Mon, 11 Oct 2021 13:15:33 +0100 From: Mark Brown To: Kamal Dasu Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, yendapally.reddy@broadcom.com, Kamal Dasu Subject: Re: [PATCH 2/3] spi: bcm-qspi: clear MSPI spifie interrupt during probe Message-ID: References: <20211008203603.40915-1-kdasu.kdev@gmail.com> <20211008203603.40915-3-kdasu.kdev@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xOqAsnaWS/lHizBU" Content-Disposition: inline In-Reply-To: <20211008203603.40915-3-kdasu.kdev@gmail.com> X-Cookie: Your ignorance cramps my conversation. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xOqAsnaWS/lHizBU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 08, 2021 at 04:36:02PM -0400, Kamal Dasu wrote: > From: Kamal Dasu >=20 > Intermittent Kernel crash has been observed on probe in > bcm_qspi_mspi_l2_isr() handler when the MSPI spifie interrupt bit > has not been cleared before registering for interrupts. > Fix the driver to move SoC specific custom interrupt handling code > before we register IRQ in probe. Also clear MSPI interrupt status > resgiter prior to registering IRQ handlers. Fixes should come at the start of a series before any new code so that they can be sent as bug fixes without pulling in any of the new work. --xOqAsnaWS/lHizBU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFkKuQACgkQJNaLcl1U h9DQXgf/eTSW4vbBBCQmn3yS4uGqsr8gvwfs+OSutnuLs9VwMhWpCQ5mmUReZ/do UqEJg9KpkBugYA9YCCtrooc1lHoEFRzVdgdYiBiX4FFOwCvoSgx4rA0PXigZ3TB5 n977UKdIWlbAD50f+YEf3KdmXoSb8kW//a17BTkm0g5J44Q2jgRkKIJ/XCUT/wHh tt5sRG1PFtSXk1JjWaPiT8WTDNRDSlp/8+AodGxiaPDx04RcHAZhRVL2Hr1kZ5kQ c+9G0efJGip4k+XgYigjibn7VzdLjhcUbx8dSYkAooVcKI/3io01ISg1+atRYhT4 Omn1lllpWd0E4slaC58/9miCHCLHBg== =ikRg -----END PGP SIGNATURE----- --xOqAsnaWS/lHizBU--