Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 Oct 2021 15:36:38 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Shawn Guo <shawnguo@kernel.org>
Cc:     Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Peng Fan <peng.fan@nxp.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Frieder Schrempf <frieder.schrempf@kontron.de>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: [PATCH] soc: imx: imx8m-blk-ctrl: off by one in
 imx8m_blk_ctrl_xlate()
Message-ID: <20211011123638.GB15188@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pkffLgjEKigmf+iJ/6ds4Zo7oBbpKQ1hNhzOHTpobwMtKm7VwFG8Ji3mYhTO?=
 =?us-ascii?Q?ckGiBeeipyLzcSY6vaVykHt2qBGxA10MFTpbJ7w9eIbJmFCYf8jbybqQmh6y?=
 =?us-ascii?Q?nf1rUGHCJKZfwqqY+TKgaztu59zrYmh74w0zbetAId5uxyEDsyBPsseoBPQz?=
 =?us-ascii?Q?6tlpTT/V7MYCa8bp1PnAy49ApPQgRroIcbXRxlsiaVJI8dmyY9dW5Un/qllI?=
 =?us-ascii?Q?rshVLsRZPdvPV2ySyy+LUy+qyD9PxZvp45O1g5wZPsuYwgOvP43IsiZHzftt?=
 =?us-ascii?Q?5kZnGpxGzope2mBoiTKO/YasovwwlAL11p403xYBf5G+9JOYoUXUD0P8i+0P?=
 =?us-ascii?Q?xk+trNR8wVrB8Hn4R0eYIIxMIrjK9S2NykiACtuVlw5a6aBLpWuO0GdIy4M8?=
 =?us-ascii?Q?FbCEClvZ/V3A0Wcu9jNNAp3+Lilneq0zh0M5l83+33jPdYhxY/nwqO+NJI8R?=
 =?us-ascii?Q?0sYw/MCSR3eUm35NFhwOoOH0hR0eiSpmB6NR6qx576uTyu9LDBKGWoFZtHgQ?=
 =?us-ascii?Q?BocwtD0tLJKznR49r+D0tLBi5Tfw6GSMKfCE3e8CbRYMRZlo4LGORrQEzOTD?=
 =?us-ascii?Q?/Cu/EHhoPCaJdSllIamNheLaMdLoscyCIvhsWMBNe3Toqg/BpksQZOR4i15M?=
 =?us-ascii?Q?ZYCfCW2F0GusHPVTUns9N4shKtSsHdTsmPf5zgTlA+fKVtf5r9ca2zmQfqSK?=
 =?us-ascii?Q?LcWn70xK0nQLTAPi5xSA3P2tprSVHfvlIFjgSiB47S0WJ1G4taSgcN7h/8DU?=
 =?us-ascii?Q?8gsEjULVpfCq2QgRe6NPeWy8M/LZs87OJ8SdOXl86bxdviZfizzq3U5P2PcL?=
 =?us-ascii?Q?ia6VfmYSwKa47t3sFwCMhdD/ID+Z3TGrm8wa4mpboh8FPjN50SqPsnjWFKgr?=
 =?us-ascii?Q?SNWGzIzjKJYb1USTQGxVyUz0KzbAjQUMCKfRyO73oe8U6yXDprEPMGXFbXmq?=
 =?us-ascii?Q?57JRi5Uv5htf6cYwzw+ZNHu9SRgHoEufnWsmNP9szf4LxmTXFEFXlAiU8xo/?=
 =?us-ascii?Q?uosbQC/OfvwZ46cHnpvGf2SQ//QZxsFEUhqHUBC+2TPdPLApmNSAnap3HVTJ?=
 =?us-ascii?Q?ww+QKWmpgnM8+kaol/4XAH5PGZhP4aY/85WBSb4LpPGBbTBq7f+WLOICyYcQ?=
 =?us-ascii?Q?YUtVg+aVqEu95XtLtL7IqDYCzKVmIkKNovFipyviF/yU70sIsuZ/F39YmzYe?=
 =?us-ascii?Q?r0jeHFKtESgaiIxZCKQjCVY7ir5UqmXTqSf3oN2saD07A8Kz6fqRKaPqNg7z?=
 =?us-ascii?Q?C98DbfCN11FClGO/CBp/j4K3NjQF6w7cfnkScbcC2n5QwSdGdviytKiMHs2u?=
 =?us-ascii?Q?sJuapDn1cDNfQw1s4tKe/aLm?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8bc677a-1214-440a-f325-08d98cb3ccc5
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 12:36:51.5063
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 95ordyweOEB4g3AsM/kPm9tj2ya/rRXqDfIZMY1JgtoyhRzF0vLggaJlMhoOIZOWTPbcjfzEpfbPmlyiqztmoO1q/Ig0iwGfLjzI52RZd/0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1822
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10133 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110110072
X-Proofpoint-GUID: rwsD7UHnFrOVhRh6e7MIsaf_1eFHBFnE
X-Proofpoint-ORIG-GUID: rwsD7UHnFrOVhRh6e7MIsaf_1eFHBFnE
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The > comparison should be >= to prevent reading one element beyond the
end of the array.  The onecell_data->domains[] array is allocated in
imx8m_blk_ctrl_probe() and it has "onecell_data->num_domains" elements.

Fixes: 5b340e7813d4 ("soc: imx: add i.MX8M blk-ctrl driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/soc/imx/imx8m-blk-ctrl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
index e172d295c441..519b3651d1d9 100644
--- a/drivers/soc/imx/imx8m-blk-ctrl.c
+++ b/drivers/soc/imx/imx8m-blk-ctrl.c
@@ -139,7 +139,7 @@ imx8m_blk_ctrl_xlate(struct of_phandle_args *args, void *data)
 	unsigned int index = args->args[0];
 
 	if (args->args_count != 1 ||
-	    index > onecell_data->num_domains)
+	    index >= onecell_data->num_domains)
 		return ERR_PTR(-EINVAL);
 
 	return onecell_data->domains[index];
-- 
2.20.1