Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <bf5648ef0933536661e42cc73aa06722522d5862.1633872027.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <bf5648ef0933536661e42cc73aa06722522d5862.1633872027.git.christophe.jaillet@wanadoo.fr>
From:   Hyunchul Lee <hyc.lee@gmail.com>
Date:   Mon, 11 Oct 2021 21:19:32 +0900
Message-ID: <CANFS6bY-BOKVzDSPSnKOJRxn8dkW+V+xKy0JR_WtfHoiJV4CxA@mail.gmail.com>
Subject: Re: [PATCH] ksmbd: Remove redundant 'flush_workqueue()' calls
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Namjae Jeon <linkinjeon@kernel.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Steve French <sfrench@samba.org>,
        linux-cifs <linux-cifs@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Acked-by: Hyunchul Lee <hyc.lee@gmail.com>

2021=EB=85=84 10=EC=9B=94 10=EC=9D=BC (=EC=9D=BC) =EC=98=A4=ED=9B=84 10:29,=
 Christophe JAILLET
<christophe.jaillet@wanadoo.fr>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> -       flush_workqueue(E);
>         destroy_workqueue(E);
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  fs/ksmbd/ksmbd_work.c     | 1 -
>  fs/ksmbd/transport_rdma.c | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/fs/ksmbd/ksmbd_work.c b/fs/ksmbd/ksmbd_work.c
> index fd58eb4809f6..14b9caebf7a4 100644
> --- a/fs/ksmbd/ksmbd_work.c
> +++ b/fs/ksmbd/ksmbd_work.c
> @@ -69,7 +69,6 @@ int ksmbd_workqueue_init(void)
>
>  void ksmbd_workqueue_destroy(void)
>  {
> -       flush_workqueue(ksmbd_wq);
>         destroy_workqueue(ksmbd_wq);
>         ksmbd_wq =3D NULL;
>  }
> diff --git a/fs/ksmbd/transport_rdma.c b/fs/ksmbd/transport_rdma.c
> index 3a7fa23ba850..0fa7b9c17af3 100644
> --- a/fs/ksmbd/transport_rdma.c
> +++ b/fs/ksmbd/transport_rdma.c
> @@ -2026,7 +2026,6 @@ int ksmbd_rdma_destroy(void)
>         smb_direct_listener.cm_id =3D NULL;
>
>         if (smb_direct_wq) {
> -               flush_workqueue(smb_direct_wq);
>                 destroy_workqueue(smb_direct_wq);
>                 smb_direct_wq =3D NULL;
>         }
> --
> 2.30.2
>


--=20
Thanks,
Hyunchul