Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1610855pxb; Mon, 11 Oct 2021 09:26:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMq97gBRHGyzU9DSKdhhLQ+T4NOex6Qbgb3S96mOuHVDRvlkBxFo1hU+4P0Lzueys1C+2n X-Received: by 2002:a50:bb67:: with SMTP id y94mr41680315ede.308.1633969605740; Mon, 11 Oct 2021 09:26:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633969605; cv=none; d=google.com; s=arc-20160816; b=RxsA7hsggfV663UQfC3mWifos72gLr7AyNz51vGxOWcG1aRLjq/DfG56UW+pXpXMQz Ja/cvhy7F+zplyq7h09zA57Ad1RqEGHAS2cWpYK2rYepfnaZWYUz8Ml3EJQBQA8vXn0q sv4r87ZwtC1k7DDCjYvOgtY1RP6mJTy4mO8zvHddA8upRD89YlZkjLhG74jRLZtM16R1 FmoTV4wNl0l7yBLtFDSlvPG3h7jKErBXVY3y7liFHgk/U9wDkpP1z56ioYTAN99e0g6/ GkDivtTRKT8QyMYrjblk97A1pxQxM1Vj+QAzMOHc9N70yVw0YqXpUYM5SohabjUfdCEL 9vEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=wW4bvzsFetfuCZAv7VsHtna8WYq4agNGYBzGaBuz88c=; b=QmmxUQBxqZqJtyKS6NNZX33Uv0hZsm0Yb8pyJdT7/PIynvnTLK0yEl3SDcdyhc3QL1 o80puLyMsL8iEk8o+4FKR+ZDU7zLY77SOL0vUB1uu+WendqZ2LxRA4uwrX//yS0Ia1QF yMqbaze+g3NcbFWJ84URIQ2+nCcMtRch3GSgpFgO+0cRvABGAOXk/VSjaHx3hGEXo7KG MpSF4S3LVE7ps5SD9b40Vyp7MPdMMgRlGAjRdF3Uu1z5lhwk3FtGkk47ICX8AYCybtt+ KRjeeHarWidXxtiCfsAFeATQJrUc7z5w+Ns0BXvGgQeRd+Cr6DI83/Tlt0XmdZgJpgLA Smsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=I9DAsOaL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cc7si14470927edb.467.2021.10.11.09.26.21; Mon, 11 Oct 2021 09:26:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=I9DAsOaL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235317AbhJKNSh (ORCPT + 99 others); Mon, 11 Oct 2021 09:18:37 -0400 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]:38548 "EHLO smtp-relay-canonical-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235144AbhJKNSg (ORCPT ); Mon, 11 Oct 2021 09:18:36 -0400 Received: from localhost (1.general.cking.uk.vpn [10.172.193.212]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id A1E9B3FE74; Mon, 11 Oct 2021 13:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1633958195; bh=wW4bvzsFetfuCZAv7VsHtna8WYq4agNGYBzGaBuz88c=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=I9DAsOaLvXHx5K/S+7EeZNw5reVK9tO5kWqNKzhaEMO/3i/DXQvvaEDS8sDlu2Lr/ WkOE8T1hSbHJPTOcLjQRBNFs1hVScTWDOpic5hiJOcukBcbNoKZnKLMSgKMuaC5uaG QR16PcZHS55MxtLmJ4zWGMdb079TZ4J9/QlgN5E4/7y5giXN1hlKoNCRSF7KVz5vaQ xWoahxI8D6j06aZhBb6n8fweqa77FxYlFqAF1GqF4fUqNXSmazBWJLl6yqmSjBT/0l FmLPy/YBt4E7YAxQQthgxrcoAN7tulm+mrvSe3HRdLbxz+1sOeUar1naAeg+wgu6l2 OppeZDaPgh3Hg== From: Colin King To: Alexander Viro , linux-fsdevel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] coredump: Remove redundant initialization of variable core_waiters Date: Mon, 11 Oct 2021 14:16:35 +0100 Message-Id: <20211011131635.30852-1-colin.king@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The variable core_waiters is being initialized with a value that is never read, it is being updated later on. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- fs/coredump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/coredump.c b/fs/coredump.c index a6b3c196cdef..2f79f8f7bd56 100644 --- a/fs/coredump.c +++ b/fs/coredump.c @@ -390,7 +390,7 @@ static int zap_threads(struct task_struct *tsk, static int coredump_wait(int exit_code, struct core_state *core_state) { struct task_struct *tsk = current; - int core_waiters = -EBUSY; + int core_waiters; init_completion(&core_state->startup); core_state->dumper.task = tsk; -- 2.32.0