Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] usb: xhci: Enable runtime-pm by default on AMD Yellow
 Carp platform
To:     mathias.nyman@intel.com, gregkh@linuxfoundation.org
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Basavaraj Natikar <Basavaraj.Natikar@amd.com>
References: <20210920154100.3195683-1-Nehal-Bakulchandra.shah@amd.com>
From:   "Shah, Nehal-bakulchandra" <nehal-bakulchandra.shah@amd.com>
Message-ID: <dce6c013-c2aa-aec6-a2c5-370e6c774e6f@amd.com>
Date:   Mon, 11 Oct 2021 18:29:17 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210920154100.3195683-1-Nehal-Bakulchandra.shah@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmU0UVVVdHBVTnByZ3JWajg5a2p3amg5MXhZZGVncHovaGxJOU9GZDlqYU9h?=
 =?utf-8?B?Um5KZzBpT0ZvUGR3S1JCdHpPaWRTR21qSHZNU3p1MEc4WGgxR0pCQjJQT1FU?=
 =?utf-8?B?UHdtK0NrTzF3YVh5Z1ExWmdnaWd4WDBHS2JxWnl0UE1SL0owTExoWHJqb3B3?=
 =?utf-8?B?L0RJSGorNUJPSEtXUzNVNTU2NlgraW5sM3I4YnVsN3BUcHhKUzRkbWpPRGla?=
 =?utf-8?B?TFEzQ3hHdEZyRkVHSS9QTDdxTU1iWDN4VWRQYnB4TENCOW4zUE9iWEFFQ2J6?=
 =?utf-8?B?RllDUldEOWNDVkFObFdkWTQ3VTFWa1RXTEgraVZ6SFpsQzB5blJXaDF4b3FF?=
 =?utf-8?B?WjVyL2xpR2pBMjZtMXRJZ3pQVGNKa1FEMG5LUG1lWnNPVG9ZYVU4c01HNGdk?=
 =?utf-8?B?T2M4dm5UYjMwVFNrWGNmMHd4YnBGSVVqTVMyTlk0WW9HbFZsaTJIejNnT2cx?=
 =?utf-8?B?aXNCZmEydDNQYkxHUVplc2lMODhTWElpQlJqcy93MWxWdzBVTjBqUndLV2Iv?=
 =?utf-8?B?eTNHMnovMVh4R2RHUlEvd0JWTWVzdHpYT3hZdkxTUU43NSt2SFVCa1YzbXBq?=
 =?utf-8?B?dy9vTExIcTM0ZnAzT1pFNWlhN0szczFxSkZERmxod1h6ZXR6cGlrQWtBbXZq?=
 =?utf-8?B?S0pyeVFYVTlDRXFwUFZQVDRndERqajdua3p1VHYvMTY4b1dCc21LY20rckNi?=
 =?utf-8?B?SFdGR3ZrLzdzamNURU1MWnNlNVpLMWY2VUpQYVpjaFYxUy9zWncrK2NIYTM4?=
 =?utf-8?B?L05nTmxmNnkzRnd2c0FXYnhmK0hSNy9DeFJRT093bW1iVEhvcnlTOE9JS1dV?=
 =?utf-8?B?UVN2dVpGZlpqSkkwZGhwd2NOKzJSUlVQSTEzOXFyTjFwdjJCVU0vUkVwdVAv?=
 =?utf-8?B?MWN3S3pEOXFCRU5NZ2xRUmtWNzlJN3BLWjZuRllGcGxDZnZGRHY3NVJ6bU01?=
 =?utf-8?B?RENCM2dPMGZNblgxK2MyMUxjcmdHeXlkZVpwVUpKaDZkZ3RwTzhIdVdQVzFB?=
 =?utf-8?B?S2xLTXp3N1BtR1UzTFo2ZmppNmhzZmZXN0ovdHZMckhMR1hnUC9HMFRZbWhi?=
 =?utf-8?B?blFWalQ5MVowQjFKMmxuem1maUx5MDYxemRZMVh0VHdsSUJ1UlAxSTUzdjgz?=
 =?utf-8?B?ZitveG92emhNVFhFb2xISTg0MVRWam9EeFZGUW5ZdGNVdzdUSmhMWFM4aEU1?=
 =?utf-8?B?djJHN1dJM3lqV0pUS3g5czJiV3hKY0ZKYkwrS09UNXc3aHVvMyttMEpQVysw?=
 =?utf-8?B?cHhBRlZCMTMyamJmNUFKbUhKZys2OU5EZXBEZnQ3empudytjL1lxQWF0NS85?=
 =?utf-8?B?aU9KQzhxNjVmTjdTN3N5Zm9FMWpCNFN0VXczeDJDcmhmSWhQM3IrMXNNcVZE?=
 =?utf-8?B?cTFrSHNycTNlc0M4bVl4ZVRjQ3FHeW56OWVLSlhLOVRpV3IzSVVTQXlINDVN?=
 =?utf-8?B?RGZZcExycmt1dEpySXZ6SVcyZzl1N1dOUE5IMGRxYmdOMXhseGN6YTVmZ3Ft?=
 =?utf-8?B?VU55VGhzZGN5MjBlbm9rWlFpTzF0MjM1NVVWU1k2MWxCeWFxUTZQTVlKSG1h?=
 =?utf-8?B?SHVVc0pYVGozZXJWYVJtcEhoVUxpbVNrcVRwY0tGU0ZzMmx0YTZNTXdOS1A3?=
 =?utf-8?B?aHhrZUJYaWNaSEdZQ3VFaGRVUG5QSjlUYUxOOVh5SEFGcmI4eUFnSVlPVTRE?=
 =?utf-8?B?NjM3d2QybHF1TTFLWWRQbkNuWFdBZDJOQTluNE9NM1d1aTNndWJ3YVhzb2ZH?=
 =?utf-8?Q?CqJufx09olcG5Z8hcnrRnZyjbdwB2LofBTrUvym?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15ff8ad0-ed9b-4707-5d76-08d98cb6f6ee
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5052.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 12:59:30.9018
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TnycwRFppi6hKPBYu5+Nzj5hjRfN0hbLdeEv00lKesByq/0yMp/6Jb/EMLP1amPz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5193
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi

On 9/20/2021 9:11 PM, Nehal Bakulchandra Shah wrote:
> AMD's Yellow Carp platform supports runtime power management for
> XHCI Controllers, so enable the same by default for all XHCI Controllers.
> 
> Signed-off-by: Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@amd.com>
> Reviewed-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Reviewed-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
> ---
>   drivers/usb/host/xhci-pci.c | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
> 
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 2c9f25ca8edd..0e571d6af2ab 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -69,6 +69,12 @@
>   #define PCI_DEVICE_ID_ASMEDIA_1142_XHCI			0x1242
>   #define PCI_DEVICE_ID_ASMEDIA_2142_XHCI			0x2142
>   #define PCI_DEVICE_ID_ASMEDIA_3242_XHCI			0x3242
> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_1	0x161a
> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_2	0x161b
> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_3	0x161d
> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_4	0x161e
> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_5	0x15d6
> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_6	0x15d7
>   
>   static const char hcd_name[] = "xhci_hcd";
>   
> @@ -313,6 +319,15 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>   	     pdev->device == PCI_DEVICE_ID_AMD_PROMONTORYA_4))
>   		xhci->quirks |= XHCI_NO_SOFT_RETRY;
>   
> +	if (pdev->vendor == PCI_VENDOR_ID_AMD &&
> +	    (pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_1 ||
> +	    pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_2 ||
> +	    pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_3 ||
> +	    pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_4 ||
> +	    pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_5 ||
> +	    pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_6))
> +		xhci->quirks |= XHCI_DEFAULT_PM_RUNTIME_ALLOW;
> +
>   	if (xhci->quirks & XHCI_RESET_ON_RESUME)
>   		xhci_dbg_trace(xhci, trace_xhci_dbg_quirks,
>   				"QUIRK: Resetting on resume");
> 

ping

Thanks
Nehal