Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1614076pxb; Mon, 11 Oct 2021 09:30:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykJ2slZ6fOCDpPUTw9MSAS5nL9Tccv4ZUH1U0Pf8cf7+rDyKGzIjM0oVytPXsMiajhH++8 X-Received: by 2002:a17:907:77c8:: with SMTP id kz8mr10236703ejc.188.1633969846908; Mon, 11 Oct 2021 09:30:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633969846; cv=none; d=google.com; s=arc-20160816; b=O7FApVQmk//tFVcYVMoyFjHJPhma3vU/WQ8eXon5W+9TB3k+5MYPwzFI0LJ7uK+ZqE LWkEvqcKC+9uhF4wBLu9nAInDssxFexnx1logim+uI5UkCMZqW/0KBUVVE2AmiGjaVKZ kwoY8kYLvm+TugudohUzg7mhrzg16C8LxSbxN1qubajlM9ZFInNM7pE/yiaDzsphpPos svJMiAROCB+/oPwVUueDGUHwYhpGqV/A9epns4pYAGa8K1OpKDYU1+eEU9bwJuzEvIlp H1VOTdN8dU5BBQK21djZqEeNUGDVr3zHUN0olm/GJra7ZIw0OWShw7ItJmFdRgQytec4 YyTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=u6DOb9W+mr1GjdJH/2XbWUql9BRZsSj2QfBWX7iXaJU=; b=WZmAJ2x0zh0iQ9/KnmNAm5exB1ZgvLLSIyA1So4cGyjNLgZ1W5se0hhYHt4wOoCdoH Fi/Mh6IzAixpq7h7I3KaaZaoCUFvJmMSpErJDfPYcIhgUg0UMjODD8X+daOEceDkWtNq cx35vdjwOFY1Fyyxwl2R6xXJMSCasj4Jk/cw3DiGeaotT2DJrQpE6T+NDpoEBorgElm1 rmptm8braiuf/tnwg1NTI6cYfJgUgZqLEZzjYbBOQu41hxd1eIjLQZu8wjn/FqAZ5sM3 rf8SYTLShr2JGPzOXOzXxD/7itYWi9kca4ALHpL3XgkxhOpx+ggz9zj8iUIv3KgSvLG7 Xetw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=S7twIDh8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cc7si14470927edb.467.2021.10.11.09.30.21; Mon, 11 Oct 2021 09:30:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=S7twIDh8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236332AbhJKNsm (ORCPT + 99 others); Mon, 11 Oct 2021 09:48:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:60174 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234354AbhJKNsh (ORCPT ); Mon, 11 Oct 2021 09:48:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633959997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u6DOb9W+mr1GjdJH/2XbWUql9BRZsSj2QfBWX7iXaJU=; b=S7twIDh8n4hdFfYSWxaxlAbZhpYmv6QpWFUDmYaxxzAJ9+7cUo/tx6m7DHO55+a+bUvMmc wQFc/6LP0/D7s4qKRUAHaWDOAnBA/jOvwDKjGKFQ4DVJmyfT6Br0anz9/hWn4KNBB7sMOy I5wOhNxMQxNL8PU0iI0u9SO/095DWMo= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-40-Lrute8EdMnmvnkHub_OpEg-1; Mon, 11 Oct 2021 09:46:36 -0400 X-MC-Unique: Lrute8EdMnmvnkHub_OpEg-1 Received: by mail-ed1-f72.google.com with SMTP id t28-20020a508d5c000000b003dad7fc5caeso15917945edt.11 for ; Mon, 11 Oct 2021 06:46:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=u6DOb9W+mr1GjdJH/2XbWUql9BRZsSj2QfBWX7iXaJU=; b=Utoxp+tw0qTXMdo7B+wSKPBrvkXPHhh3lHTeucgHeKxwbyUJD2q4DCDsBq0cDhptnM ym37jtqJ2haJk7HiEQCHi1NcG1C5LowSsUYgkPr+8V/KXOVx3VY8j3tMhjJAuuz1q5yn 68YnNkP1wnu+C3LXQvE6H0ycgcX3mw2B/jEJ9I4fd7t/VVdrRSYGEaTf0XgbMxEdOKIS bR7VXuQvMkTlIr+nYl+EWL2Oje6wavab+dU0yfx6PUG7XsXh/EXNOA8bK9qu36/tXWmq LwaPTvPnBapw/k/tP7E/sq3Ypm7SZ84/SRKCMS/eCX6awEbpBlCEFNZBGyAKBzmK0ZL/ A28w== X-Gm-Message-State: AOAM530jG8daP8f4C5vSkiO8NacTM1F1b6Qsi0ksyiq4xAmKS6qRGgCm 4IvZfUnygmddfTEQOwR+8U0c3Lj4hnyGTwXYk4jBiQqaNf1N77xSALl5u/LrrqFYTsr9WoxWAdt l4c0d/sCrnpd9PEDAkUIaRGtK X-Received: by 2002:aa7:db8a:: with SMTP id u10mr43526199edt.189.1633959993699; Mon, 11 Oct 2021 06:46:33 -0700 (PDT) X-Received: by 2002:aa7:db8a:: with SMTP id u10mr43526174edt.189.1633959993550; Mon, 11 Oct 2021 06:46:33 -0700 (PDT) Received: from x1.localdomain ([81.30.35.201]) by smtp.gmail.com with ESMTPSA id f12sm757429edx.90.2021.10.11.06.46.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Oct 2021 06:46:33 -0700 (PDT) Subject: Re: [PATCH 1/2] platform/x86: amd-pmc: Add alternative acpi id for PMC controller To: Sachi King , Shyam-sundar.S-k@amd.com, mgross@linux.intel.com, mario.limonciello@amd.com, rafael@kernel.org, lenb@kernel.org Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, stable@vger.kernel.org References: <20211002041840.2058647-1-nakato@nakato.io> From: Hans de Goede Message-ID: <038d2490-0cfd-e68c-2129-b386e1c9d071@redhat.com> Date: Mon, 11 Oct 2021 15:46:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20211002041840.2058647-1-nakato@nakato.io> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/2/21 6:18 AM, Sachi King wrote: > The Surface Laptop 4 AMD has used the AMD0005 to identify this > controller instead of using the appropriate ACPI ID AMDI0005. Include > AMD0005 in the acpi id list. > > Cc: # 5.14+ > Signed-off-by: Sachi King Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. I will also include this in my upcoming pdx86-fixes pull-req for 5.15 . Regards, Hans > --- > drivers/platform/x86/amd-pmc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c > index d6a7c896ac86..fc95620101e8 100644 > --- a/drivers/platform/x86/amd-pmc.c > +++ b/drivers/platform/x86/amd-pmc.c > @@ -476,6 +476,7 @@ static const struct acpi_device_id amd_pmc_acpi_ids[] = { > {"AMDI0006", 0}, > {"AMDI0007", 0}, > {"AMD0004", 0}, > + {"AMD0005", 0}, > { } > }; > MODULE_DEVICE_TABLE(acpi, amd_pmc_acpi_ids); >