DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent:sender;
        b=NNkZTf8gkJKsobpiwpJj+sWBLD2LrUtHF5/Gn0IfCMaBE4HWm9BYAchyDGpxwQrJP5NrXERzJm1yCRfU7x47csCFoQTT+JGcgR7EKrFJTIm0wJyNm5zC334Rnm6VbeRGsyNwIOaGK+NXPOZ+Hyp3EA95Yli6aowySChSSXurKQY=
Date: Fri, 22 Dec 2006 08:05:39 +0000
From: Frederik Deweerdt <deweerdt@free.fr>
To: Andrew Morton <akpm@osdl.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>, linux-kernel@vger.kernel.org
Subject: Re: [-mm patch] ptrace: make {put,get}reg work again for gs and fs
Message-ID: <20061222080539.GE18827@slug>
References: <20061214225913.3338f677.akpm@osdl.org> <20061221183518.GA18827@slug> <458ADEDD.8010903@goop.org> <20061221215942.GC18827@slug> <458B3C51.4030905@goop.org> <20061221181108.6cede9ba.akpm@osdl.org> <20061222060618.GD18827@slug> <20061221225414.de09c7df.akpm@osdl.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20061221225414.de09c7df.akpm@osdl.org>
User-Agent: mutt-ng/devel-r804 (Linux)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1917
Lines: 47

On Thu, Dec 21, 2006 at 10:54:14PM -0800, Andrew Morton wrote:
> On Fri, 22 Dec 2006 06:06:18 +0000
> Frederik Deweerdt <deweerdt@free.fr> wrote:
> 
> > On Thu, Dec 21, 2006 at 06:11:08PM -0800, Andrew Morton wrote:
> > > On Thu, 21 Dec 2006 18:00:49 -0800
> > > Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> > > 
> > > > Frederik Deweerdt wrote:
> > > > > This is a -mm1 kernel + your efl_offset fix + the attached patch.
> > > > > So the problem came from putreg still saving %gs to the stack where
> > > > > there's no slot for it, whereas getreg got things right.
> > > > >   
> > > > 
> > > > That patch looks good, but I think it is already effectively in Andrew's
> > > > queue, because I noticed some problems in there when I reviewed  the
> > > > convert-to-%fs patch.
> > > > 
> > > 
> > > The below is what I have queued for urgent mainlining to address these
> > > problems.
> > > 
> > > Is it sufficient?
> > > 
> > No, it's not. The patch below fixes the place where we get eflags, this
> > triggered the "BUG while gdb'ing" reports.
> > The one I sent was to fix a problem that only I reported, AFAIK: when
> > you use gdb/ptrace to modify %fs, the value gets written in the wrong
> > place (see gdb sessions). So, unless you have another patch fixing the
> > way putreg() writes %fs, the patch[1] I sent should also be queued for
> > mainline.
> 
> OK, but you're using -mm, yes?  And -mm has (the rather irritating)
> convert-i386-pda-code-to-use-%fs.patch in it.
> 
> So perhaps your fix is a -mm-only thing?
> 
It is sorry, I mixed things up. BTW, your mails don't seem to make it to
the lkml (see http://lkml.org/lkml/2006/12/22/10)

Regards,
Frederik
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/