Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] iio: core: do not create debugfs when has no dev name
To:     Yang Yingliang <yangyingliang@huawei.com>,
        linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Cc:     ars@metafoo.de, jic23@kernel.org, alexandru.ardelean@analog.com,
        andy.shevchenko@gmail.com
References: <20211011135654.282958-1-yangyingliang@huawei.com>
From:   Lars-Peter Clausen <lars@metafoo.de>
Message-ID: <2430dc94-ecf8-c246-beaf-52cc0905e3d4@metafoo.de>
Date:   Mon, 11 Oct 2021 16:12:55 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211011135654.282958-1-yangyingliang@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

On 10/11/21 3:56 PM, Yang Yingliang wrote:
> I got a null-ptr-deref report when doing fault injection test:
>
> BUG: kernel NULL pointer dereference, address: 0000000000000000
> PGD 0 P4D 0
> Oops: 0000 [#1] SMP KASAN PTI
> RIP: 0010:strlen+0x0/0x20
> Call Trace:
>   start_creating+0x199/0x2f0
>   debugfs_create_dir+0x25/0x430
>   __iio_device_register+0x4da/0x1b40 [industrialio]
>   __devm_iio_device_register+0x22/0x80 [industrialio]
>   max1027_probe+0x639/0x860 [max1027]
>   spi_probe+0x183/0x210
>   really_probe+0x285/0xc30
>
> If dev_set_name() fails, the dev_name() is null, add check for
> device name before creating debugfs.

If dev_set_name() fails, shouldn't we better return an error in 
iio_device_alloc()? Otherwise the device has no name and will show up as 
<null> in sysfs.

>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: e553f182d55b ("staging: iio: core: Introduce debugfs support...")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>   drivers/iio/industrialio-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index 2dc837db50f7..8974490ad536 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -466,7 +466,7 @@ static void iio_device_register_debugfs(struct iio_dev *indio_dev)
>   	if (indio_dev->info->debugfs_reg_access == NULL)
>   		return;
>   
> -	if (!iio_debugfs_dentry)
> +	if (!iio_debugfs_dentry || !dev_name(&indio_dev->dev))
>   		return;
>   
>   	iio_dev_opaque = to_iio_dev_opaque(indio_dev);