Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211007231647.3553604-1-seanjc@google.com>
In-Reply-To: <20211007231647.3553604-1-seanjc@google.com>
From:   Oliver Upton <oupton@google.com>
Date:   Mon, 11 Oct 2021 09:35:11 -0500
Message-ID: <CAOQ_Qsj9yiChnBZmotdYFYgsd=C0J5XXR8mthdiC+iXX22F7jw@mail.gmail.com>
Subject: Re: [PATCH] KVM: x86: Account for 32-bit kernels when handling
 address in TSC attrs
To:     Sean Christopherson <seanjc@google.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Oct 7, 2021 at 6:16 PM Sean Christopherson <seanjc@google.com> wrot=
e:
>
> When handling TSC attributes, cast the userspace provided virtual address
> to an unsigned long before casting it to a pointer to fix warnings on
> 32-bit kernels due to casting a 64-bit integer to a 32-bit pointer.
>
> Add a check that the truncated address matches the original address, e.g.
> to prevent userspace specifying garbage in bits 63:32.
>
>   arch/x86/kvm/x86.c: In function =E2=80=98kvm_arch_tsc_get_attr=E2=80=99=
:
>   arch/x86/kvm/x86.c:4947:22: error: cast to pointer from integer of diff=
erent size
>    4947 |  u64 __user *uaddr =3D (u64 __user *)attr->addr;
>         |                      ^
>   arch/x86/kvm/x86.c: In function =E2=80=98kvm_arch_tsc_set_attr=E2=80=99=
:
>   arch/x86/kvm/x86.c:4967:22: error: cast to pointer from integer of diff=
erent size
>    4967 |  u64 __user *uaddr =3D (u64 __user *)attr->addr;
>         |                      ^
>
> Cc: Oliver Upton <oupton@google.com>
> Fixes: 469fde25e680 ("KVM: x86: Expose TSC offset controls to userspace")
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>  arch/x86/kvm/x86.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>

Reviewed-by: Oliver Upton <oupton@google.com>