Received: by 2002:a05:6520:1682:b0:147:d1a0:b502 with SMTP id ck2csp5597557lkb; Mon, 11 Oct 2021 09:40:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwNnKi7wjcg7JRTdcoIeLCr+lTJ3o3K2mRuLpQXRZ2dNdUYw/l+NApIT8wyvOvLRV3AS/Q X-Received: by 2002:a17:902:c410:b0:13e:cfac:45ad with SMTP id k16-20020a170902c41000b0013ecfac45admr25719229plk.68.1633970409621; Mon, 11 Oct 2021 09:40:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633970409; cv=none; d=google.com; s=arc-20160816; b=zvAkgykTEIwMuZZmwHOYZgbOHnELl8OHgNRkXR3alk0yKKhh6Iyy6lI7a+RIQBIUuq Qi8ITLF3o67XdxdQ15OhGMxA5sLdLL13ePC4ALc5i7bsHxGDvO+hjTN6WiEcDYvK3dvu uyQF8EMXvRts3lXy3QJaWj6Qu6fGOtx5cVrecdFCuFdTHIyW/Uhbx+NIcDsa+gLB4GmM 9lrozp4BDIlBryUcBksfSZp/1JiqTFDP6YyHkyr1bq1KW0+3QiMP+nzv1JwEjaeb1v3U deG7Pot3msxCM0rEBC78fyLPwEW7j001fYBkwEtPREDdXIzasL/pTjE33uw1VPhRWLBP twLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=XSafMxd/TP0ieByDFAQ62CeBnbiUsvqnta9Pz4fAerQ=; b=QLWCv6Um3S71yybZHC00pqGrCwmAGpobKIzxeIdJKFLDY6NCrAGEgyGSh5xkpDBwyI t3f70Oh3M3sq4tR7/LkzgO43W4FuBL05dpi2aEgPbGL56ol2EegyE4p5Z7yH2KQ05El4 gxsilIdewFrfKRzc5f8Cm+Df3V+8z4z6CYl/rkNixmpN65BP1INt3CahnSyCAs8qrNFM 9XPpDXraAazUEGAnyDmgBgO+CmaJmNiuCnThpfPps4tHVwEFMyx/doXBPuUxlLWeEpgx u7SAPwcCrSH1t9vpi9OFYc0QV+wdHIVzYo0yKXuePT3K5r1dH5EjrZoyBsFO1E8HfUrs GefQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k18si12804084plk.170.2021.10.11.09.39.56; Mon, 11 Oct 2021 09:40:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243900AbhJKOoN (ORCPT + 99 others); Mon, 11 Oct 2021 10:44:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243759AbhJKOn7 (ORCPT ); Mon, 11 Oct 2021 10:43:59 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D88ABC0612EA; Mon, 11 Oct 2021 07:39:06 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1mZwSF-0001fN-Sj; Mon, 11 Oct 2021 16:39:03 +0200 From: Florian Westphal To: linux-security-module@vger.kernel.org Cc: john.johansen@canonical.com, jmorris@namei.org, serge@hallyn.com, linux-kernel@vger.kernel.org, Florian Westphal Subject: [PATCH apparmor] apparmor: remove unneeded one-line hook wrappers Date: Mon, 11 Oct 2021 16:38:54 +0200 Message-Id: <20211011143854.17917-1-fw@strlen.de> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the common function directly. Signed-off-by: Florian Westphal --- security/apparmor/lsm.c | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c index f72406fe1bf2..eafb44aa553a 100644 --- a/security/apparmor/lsm.c +++ b/security/apparmor/lsm.c @@ -1773,32 +1773,16 @@ static unsigned int apparmor_ip_postroute(void *priv, } -static unsigned int apparmor_ipv4_postroute(void *priv, - struct sk_buff *skb, - const struct nf_hook_state *state) -{ - return apparmor_ip_postroute(priv, skb, state); -} - -#if IS_ENABLED(CONFIG_IPV6) -static unsigned int apparmor_ipv6_postroute(void *priv, - struct sk_buff *skb, - const struct nf_hook_state *state) -{ - return apparmor_ip_postroute(priv, skb, state); -} -#endif - static const struct nf_hook_ops apparmor_nf_ops[] = { { - .hook = apparmor_ipv4_postroute, + .hook = apparmor_ip_postroute, .pf = NFPROTO_IPV4, .hooknum = NF_INET_POST_ROUTING, .priority = NF_IP_PRI_SELINUX_FIRST, }, #if IS_ENABLED(CONFIG_IPV6) { - .hook = apparmor_ipv6_postroute, + .hook = apparmor_ip_postroute, .pf = NFPROTO_IPV6, .hooknum = NF_INET_POST_ROUTING, .priority = NF_IP6_PRI_SELINUX_FIRST, -- 2.32.0