Received: by 2002:a05:6520:1682:b0:147:d1a0:b502 with SMTP id ck2csp5598376lkb; Mon, 11 Oct 2021 09:40:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyghf1YNfSTSnSfmkceVh38oYmYH2sDx4rS/7/h3Ouh+zIjcviNjGalwO00HM8a0NYVQP51 X-Received: by 2002:a05:6402:4d1:: with SMTP id n17mr43780937edw.337.1633970455173; Mon, 11 Oct 2021 09:40:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633970455; cv=none; d=google.com; s=arc-20160816; b=p9jD5SHE80TR1Y501U8moWCA3C7fATMz8bv6VT4vwvnw0HOjMop90N1K46txYiYhf/ eQsS7SZNVGxtiCTKYnMH0nyKiHBQYULKPfBy71yKE2K2GQ8wt22b/Fu1g8MjbKoKCslV STvSkvudBZ4Z67OXKmnl1uQ4tTlIwk4+58I3NZKMdHI70I+N6u+EAePSA2DxwBQsLiu2 dP7K2XOZxwdvB3tpmlErmMgPeOlUtGwAIGOrXJUvWmvNLmyMRo0gEwOb+E4D5SNhkYUK 58gxM4yJG2u20QTtgMi8oewlBVMtNO2tciOOcWXWuqHc3bybv7CqFnP0vETRMMkoLTAW eiig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=rsJuXZOGikg0LA+Y2J/vsmp9Ot+GsyhSJXvWhYlu+r8=; b=Yl0iJD4Z6nCkG8eaXQ7V2/jEWcw7JdrGY5mlkXj/Y2jjdvcJ/zdsi/xKomY2ANMAk/ QwfcKGYIXEg9ikyH0kVtUEt60sxtDMyFvAkOJbKFWaNIUAtqFihqKccplvmQoQVdYYwq 6HSsbt4M1d7jPi29CguNlJtvqQjwBpwFl7Zjc4QpTxRVze23JgHc643Pv9lUrskL1R2k l1WXEt5CXOiNGz6kLPd9uiGa1MvfCLes5juXKUNRQgK4o3ktuh6SMN9R6DljOyG+CL61 BmTd8tY9T6aW3+xaajMmxxJ+0W+BGDP6ZlQ5tctk32rW9tTcX5IrBxWYlTjM3MWc7uOn lGPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k13si11079962eja.414.2021.10.11.09.40.30; Mon, 11 Oct 2021 09:40:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239172AbhJKPfh (ORCPT + 99 others); Mon, 11 Oct 2021 11:35:37 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:44525 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234930AbhJKPfd (ORCPT ); Mon, 11 Oct 2021 11:35:33 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.97]) with ESMTPSA (Nemesis) id 1M4rkF-1mZgaR44Gt-001wyI for ; Mon, 11 Oct 2021 17:33:25 +0200 Received: by mail-wr1-f50.google.com with SMTP id r18so57582494wrg.6 for ; Mon, 11 Oct 2021 08:33:24 -0700 (PDT) X-Gm-Message-State: AOAM530IyQO+9yDEC5yYyWWvpAHNhuSALrLJWL3UjqmgQhDnmTekdvUy A7YLA3VUge2dlBz3mbxeYuewJoXihSd9qGZi+GQ= X-Received: by 2002:adf:b1c4:: with SMTP id r4mr25714356wra.428.1633966404628; Mon, 11 Oct 2021 08:33:24 -0700 (PDT) MIME-Version: 1.0 References: <20211011151443.12040-1-vegard.nossum@oracle.com> In-Reply-To: <20211011151443.12040-1-vegard.nossum@oracle.com> From: Arnd Bergmann Date: Mon, 11 Oct 2021 17:33:08 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] habanalabs: select CRC32 To: Vegard Nossum Cc: Oded Gabbay , Arnd Bergmann , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:jS8H6+8c9aEzbfJGfvbZ7FRjBUHtOyMILu86YAkp/Fe1f75H5G0 jObyMZDmbNhMwNNWPmM7Zh5Q1fGWZNinIQ+MdG26bnMPoHci9Y304t5NZlY3EPoLN/kM1/K plkR4SOmCXNPDZxR4BG+ZFp/EVR2TJrVC0CoI0eD1ILaMm8d7SyG+LZp71VhZO72MMWb2W0 UK5Rw0ZVEU6RH3og6+Eew== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:f9JlVrfxYbc=:IFNbehV/61j5sI1Bo+8B3Z KG09WRvP+SCIvmZxEbIsvi6oDpqQBIu/RxXeAikfJgxK94jY6zkuxN/a8D7QjVHb9XRmBLbS6 6cnGRBvuGiGAFsYZVQbmr/CuP+qmZr737DhtNXI5Q0HXy5kLNCagVD5JNmAXmEYuqrqc9OXD6 ARM3eGtH57G8UqTeNpSPxb/LhtECZWlbFRdodDMuN/+9ihBxNo/mK5YsEkAsCEz14veRwtV5u +kYWdCtaPj6pwKe96an3jvxVRJJy9bHmmapKD2xMNYv1AY/ECW9Yinv/Wb2QKgSzCyuf0wZ3q YsXMMQdm4voxY9WGYRSyK8cKBSNI7WnXruPBeqgtaa4jj82n/wYotl5Z/VXhORWluYbvsTOKS MZp/qgjyphwSPncrHdAJ3Q3QZxVj34rbQ7yzCnPXQnYM/oCG8cAkYRs4oUx3ouCbjwOXKY6dB DLxepyTqCqLtmStgKFfBgrZEypoX7q6FqF+H4MK/xIuUXNR1ZSPu1n6wZ9ZEuGw8nn/Az62Es qMckzmBwtl5BtLNh/cfu+4/xsGjZqE+SgYBgx0M2X5vfSI+47EYqoD3wSwjv8QImWEdqz++gE KSb4ag7054KrMO0jRg2/5l0Efv21AupEWhpWhz7YhojdPk79d8WAwC/Nq2uhNXIQ1pENuQsVc oxbHTTkrmF3XspmQBLtJ1b3Fqnq+AH998OcQ9phJxLv1nF5KGkY/tchss7rt48Xk8lp8glnU9 XPju4uoQdtgsvq4/hYmQ85trj4QEFC3zQUFQrA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 11, 2021 at 5:14 PM Vegard Nossum wrote: > > Fix the following build/link error by adding a dependency on the CRC32 > routines: > > ld: drivers/misc/habanalabs/common/firmware_if.o: in function `hl_fw_dynamic_request_descriptor': > firmware_if.c:(.text.unlikely+0xc89): undefined reference to `crc32_le' > > Signed-off-by: Vegard Nossum Patch looks good to me, I wonder how I never caught that with my own randconfig build testing. May I ask how you found it? Fixes: 8a43c83fec12 ("habanalabs: load boot fit to device") Acked-by: Arnd Bergmann