Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 Oct 2021 18:23:35 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Liguang Zhang <zhangliguang@linux.alibaba.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
        Tony Luck <tony.luck@intel.com>, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ACPI / APEI: restore interrupt before panic in sdei flow
Message-ID: <YWRlBzBXq7T1Vo4c@zn.tnic>
References: <20211011151028.105215-1-zhangliguang@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20211011151028.105215-1-zhangliguang@linux.alibaba.com>
Precedence: bulk

On Mon, Oct 11, 2021 at 11:10:28PM +0800, Liguang Zhang wrote:
> We use ACPI_HEST_NOTIFY_SOFTWARE_DELEGATED Notify type for ras event.
> 
> In ATF:
> ehf_activate_priority()
>    dispatch sdei()
> ehf_deactivate_priority()
> 
> If ras error severity is fatal, panic was called in sdei(),
> ehf_deactivate_priority was not called. we should restore interrupt before panic
> otherwise kdump will trigger error.

I have *absolutely* no clue what this commit message is trying to tell
me - sorry you'd have to try again. Maybe structuring it this way, would
help:

--
Problem is A.

It happens because of B.

Fix it by doing C.

(Potentially do D).

For more detailed info, see
Documentation/process/submitting-patches.rst, Section "2) Describe your
changes".

Also, to the tone, from Documentation/process/submitting-patches.rst:

 "Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
  instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
  to do frotz", as if you are giving orders to the codebase to change
  its behaviour."

Also, do not talk about what your patch does - that should hopefully be
visible in the diff itself. Rather, talk about *why* you're doing what
you're doing.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette